Page MenuHomePhabricator

[mlir][linalg] Finish refactor of TC ops to YAML
ClosedPublic

Authored by rsuderman on Aug 16 2021, 3:28 PM.

Details

Summary

Multiple operations were still defined as TC ops that had equivalent versions
as YAML operations. Reducing to a single compilation path guarantees that
frontends can lower to their equivalent operations without missing the
optimized fastpath.

Some operations are maintained purely for testing purposes (mainly conv{1,2,3}D
as they are included as sole tests in the vectorizaiton transforms.

Diff Detail

Event Timeline

rsuderman created this revision.Aug 16 2021, 3:28 PM
rsuderman requested review of this revision.Aug 16 2021, 3:28 PM
nicolasvasilache added inline comments.
mlir/include/mlir/Dialect/Linalg/IR/LinalgNamedStructuredOps.yaml
634

I would drop the mention of testing here and everywhere: 1d conv is a perfectly valid operation and it may prove to be very useful when lowering other things into it on the path to vector code.

This revision is now accepted and ready to land.Aug 19 2021, 12:00 AM

Removed testing comment.

This revision was automatically updated to reflect the committed changes.