This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Optimize amdgpu-no-* attributes
ClosedPublic

Authored by arsenm on Aug 16 2021, 1:36 PM.

Details

Summary

This allows clobbering a few extra registers in the fixed ABI, and
avoids some workitem ID packing instructions.

Diff Detail

Event Timeline

arsenm created this revision.Aug 16 2021, 1:36 PM
arsenm requested review of this revision.Aug 16 2021, 1:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2021, 1:36 PM
Herald added a subscriber: wdng. · View Herald Transcript
jdoerfert resigned from this revision.Aug 16 2021, 10:08 PM

Not qualified to look at the ISel and other AMDGPU parts, one comment though.

llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
805

Can we merge inputregs and impliciAttrNames into one array of structs so there is a proper one to one mapping, this is very implicit and harder to understand.

arsenm updated this revision to Diff 367009.Aug 17 2021, 2:10 PM

Use pair between enum and string

This revision is now accepted and ready to land.Dec 1 2021, 5:55 AM
arsenm closed this revision.Dec 1 2021, 5:55 AM