This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][test] Add new tests for mul optimization in the zba extension with SH*ADD
ClosedPublic

Authored by benshi001 on Aug 10 2021, 4:55 AM.

Diff Detail

Event Timeline

benshi001 created this revision.Aug 10 2021, 4:55 AM
benshi001 requested review of this revision.Aug 10 2021, 4:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2021, 4:55 AM
benshi001 updated this revision to Diff 365464.Aug 10 2021, 7:00 AM
This revision is now accepted and ready to land.Aug 10 2021, 6:34 PM
jrtc27 added inline comments.Aug 10 2021, 6:35 PM
llvm/test/CodeGen/RISCV/rv64zba.ll
7

Ugh this is confusing, should be RV64IBZBA, not RV64IBA (which would mean integer, bitmanip and atomics, albeit in a non-canonical order, which makes no sense for this test)

benshi001 marked an inline comment as done.Aug 10 2021, 6:37 PM
benshi001 added inline comments.
llvm/test/CodeGen/RISCV/rv64zba.ll
7

Sure. I will correct that before 'git push'

benshi001 marked an inline comment as done.Aug 10 2021, 6:40 PM
craig.topper added inline comments.Aug 10 2021, 6:40 PM
llvm/test/CodeGen/RISCV/rv64zba.ll
7

Why RV64IBZBA and not RV64IZBA? Should the M be mentioned for the +m?

All of the B extension tests are like this and have been since they were created.

7

Please don't. All the tests should be corrected at once and not part of this patch.

jrtc27 added inline comments.Aug 10 2021, 6:42 PM
llvm/test/CodeGen/RISCV/rv64zba.ll
7

Oh, yes, RV64IZBA is what I mean here. The M probably should be there too, I think in general we either do something approximating the full arch string or we do just RV64X for the specific extension being tested (i.e. you'd drop the I for the IB and I(Z)BA ones), which would also be fine by me.

benshi001 marked an inline comment as done.Aug 10 2021, 6:46 PM
benshi001 added inline comments.
llvm/test/CodeGen/RISCV/rv64zba.ll
7

OK. I will only push the part I have added.