Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/CodeGen/RISCV/rv64zba.ll | ||
|---|---|---|
| 7 | Ugh this is confusing, should be RV64IBZBA, not RV64IBA (which would mean integer, bitmanip and atomics, albeit in a non-canonical order, which makes no sense for this test) | |
| llvm/test/CodeGen/RISCV/rv64zba.ll | ||
|---|---|---|
| 7 | Sure. I will correct that before 'git push' | |
| llvm/test/CodeGen/RISCV/rv64zba.ll | ||
|---|---|---|
| 7 | Oh, yes, RV64IZBA is what I mean here. The M probably should be there too, I think in general we either do something approximating the full arch string or we do just RV64X for the specific extension being tested (i.e. you'd drop the I for the IB and I(Z)BA ones), which would also be fine by me. | |
| llvm/test/CodeGen/RISCV/rv64zba.ll | ||
|---|---|---|
| 7 | OK. I will only push the part I have added. | |
Ugh this is confusing, should be RV64IBZBA, not RV64IBA (which would mean integer, bitmanip and atomics, albeit in a non-canonical order, which makes no sense for this test)