This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][FIX] Only avoid visiting PHI uses multiple times (PR51249)
ClosedPublic

Authored by jdoerfert on Aug 9 2021, 8:35 PM.

Details

Summary

AAPointerInfoFloating needs to visit all uses and some multiple times if
we go through PHI nodes. Attributor::checkForAllUses keeps a visited set
so we don't recurs endlessly. We now allow recursion for non-phi uses so
we track all pointer offsets via PHI nodes properly without endless
recursion.

This replaces the first attempt D107579.

Diff Detail

Event Timeline

jdoerfert created this revision.Aug 9 2021, 8:35 PM
jdoerfert requested review of this revision.Aug 9 2021, 8:35 PM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

This alone is not sufficient, follow up is coming.

jdoerfert updated this revision to Diff 365394.Aug 10 2021, 2:34 AM

Rebase on more tests

This revision is now accepted and ready to land.Aug 10 2021, 12:11 PM