This can be useful when one needs to know which unrolled iteration an Op belongs to, for example, conveying noalias information among memory-affecting ops in parallel-access loops.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Time | Test | |
---|---|---|
310 ms | x64 debian > MLIR.Dialect/SCF::loop-unroll.mlir Script:
--
: 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/SCF/loop-unroll.mlir -test-loop-unrolling='unroll-factor=2' | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/SCF/loop-unroll.mlir --check-prefix UNROLL-BY-2
| |
290 ms | x64 windows > MLIR.Dialect/SCF::loop-unroll.mlir Script:
--
: 'RUN: at line 1'; c:\ws\w8\llvm-project\premerge-checks\build\bin\mlir-opt.exe C:\ws\w8\llvm-project\premerge-checks\mlir\test\Dialect\SCF\loop-unroll.mlir -test-loop-unrolling='unroll-factor=2' | c:\ws\w8\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w8\llvm-project\premerge-checks\mlir\test\Dialect\SCF\loop-unroll.mlir --check-prefix UNROLL-BY-2
|
Event Timeline
Comment Actions
To clarify: are you asking me to commit for you (don't have commit access) or do you ask confirmation that you can land it now?
mlir/test/Dialect/SCF/loop-unroll.mlir | ||
---|---|---|
198 | One nit: in general I prefer targeted testing. // UNROLL-BY-2-ANNOTATE: memref.store {{.*}} unrolled_iteration = 0 // UNROLL-BY-2-ANNOTATE: memref.store {{.*}} unrolled_iteration = 1 The rest is already tested in other tests. |
This comment was removed by nimiwio.
Comment Actions
I guess both.. This is my first commit (so I definitely don't have commit access) and I'm also unsure of what amount of review/consensus sufficient to land a change. If it's okay to commit now, that would be good with me.