- User Since
- Nov 24 2020, 10:05 AM (121 w, 5 d)
Jan 10 2022
Thank you for the review! Can this be landed?
Dec 22 2021
Dec 13 2021
Dec 8 2021
Add checks for trip count and tests
Sorry didn't mean to send this for review quite yet, I still need to tweak this a bit, and add tests.
Oct 18 2021
Thank you both for the discussion.. I'm not quite sure how to proceed on this though. As things stand right now, it seems like it is not safe for a pass to add custom attributes to a ForOp. Is this true for any Ops belonging to a Dialect not "owned" by a pass? The notion of "external" vs "intrinsic" attributes seems to make sense to me but if there's not agreement on that, is there some other way that we can propagate custom information about an Op besides through attributes? I'm not necessarily attached to this change, but I'm just not sure of a workable alternative right now.
Oct 15 2021
Oct 14 2021
Sep 22 2021
Thank you for the review! Can you please land this change?
Sep 21 2021
Ah, we wrote the same patch :) I missed the XFAIL on this test, I'll revert this one and let ftynse@ push the change through.
Sep 1 2021
Thank you for the reviews! Could you please land this when you get a chance?
Aug 31 2021
Aug 24 2021
@mehdi_amini Unless there are other comments, could you please commit this change?
Aug 18 2021
Aug 11 2021
Address clang-tidy warnings
Aug 10 2021
Thank you for the review! Can this be committed?