Page MenuHomePhabricator

nimiwio (Tyler Augustine)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 24 2020, 10:05 AM (53 w, 22 h)

Recent Activity

Oct 18 2021

nimiwio added a comment to D111837: Retain attributes of original scf::ForOp when folding.

Thank you both for the discussion.. I'm not quite sure how to proceed on this though. As things stand right now, it seems like it is not safe for a pass to add custom attributes to a ForOp. Is this true for any Ops belonging to a Dialect not "owned" by a pass? The notion of "external" vs "intrinsic" attributes seems to make sense to me but if there's not agreement on that, is there some other way that we can propagate custom information about an Op besides through attributes? I'm not necessarily attached to this change, but I'm just not sure of a workable alternative right now.

Oct 18 2021, 3:51 PM · Restricted Project

Oct 15 2021

nimiwio added a comment to D111837: Retain attributes of original scf::ForOp when folding.

It is a bit tricky, because we can't really know what these attributes are here for. For example they could refer to individual operands of the loop, but we just shuffled them (removed some).

Oct 15 2021, 9:51 AM · Restricted Project

Oct 14 2021

nimiwio requested review of D111837: Retain attributes of original scf::ForOp when folding.
Oct 14 2021, 2:00 PM · Restricted Project

Sep 22 2021

nimiwio added a comment to D110205: Fix bug for Ops with default valued attributes and successors/variadic regions..

Thank you for the review! Can you please land this change?

Sep 22 2021, 1:29 PM · Restricted Project

Sep 21 2021

nimiwio requested review of D110205: Fix bug for Ops with default valued attributes and successors/variadic regions..
Sep 21 2021, 3:29 PM · Restricted Project
nimiwio abandoned D110189: Fix alias.scope lowering.
Sep 21 2021, 11:31 AM · Restricted Project
nimiwio added a comment to D110189: Fix alias.scope lowering.

Ah, we wrote the same patch :) I missed the XFAIL on this test, I'll revert this one and let ftynse@ push the change through.

Sep 21 2021, 11:16 AM · Restricted Project
nimiwio requested review of D110189: Fix alias.scope lowering.
Sep 21 2021, 11:09 AM · Restricted Project

Sep 1 2021

nimiwio added a comment to D109025: Support alias.scope and noalias metadata lowering on intrinsics..

Thank you for the reviews! Could you please land this when you get a chance?

Sep 1 2021, 9:16 AM · Restricted Project

Aug 31 2021

nimiwio requested review of D109025: Support alias.scope and noalias metadata lowering on intrinsics..
Aug 31 2021, 2:22 PM · Restricted Project

Aug 24 2021

nimiwio added a comment to D107870: Support alias.scope and noalias metadata.

@mehdi_amini Unless there are other comments, could you please commit this change?

Aug 24 2021, 11:33 AM · Restricted Project

Aug 18 2021

nimiwio added inline comments to D107870: Support alias.scope and noalias metadata.
Aug 18 2021, 2:58 PM · Restricted Project
nimiwio updated the diff for D107870: Support alias.scope and noalias metadata.

Address comments

Aug 18 2021, 2:58 PM · Restricted Project

Aug 11 2021

nimiwio updated the diff for D107789: Support post-processing Ops in unrolled loop iterations.

Fix test

Aug 11 2021, 3:38 PM · Restricted Project
nimiwio updated the diff for D107870: Support alias.scope and noalias metadata.

Address clang-tidy warnings

Aug 11 2021, 11:23 AM · Restricted Project
nimiwio added a comment to D107789: Support post-processing Ops in unrolled loop iterations.

Thank you for the review! Can this be committed?

To clarify: are you asking me to commit for you (don't have commit access) or do you ask confirmation that you can land it now?

Aug 11 2021, 10:00 AM · Restricted Project
nimiwio updated the diff for D107789: Support post-processing Ops in unrolled loop iterations.

Minified test

Aug 11 2021, 9:55 AM · Restricted Project
nimiwio updated the diff for D107789: Support post-processing Ops in unrolled loop iterations.
Aug 11 2021, 9:52 AM · Restricted Project

Aug 10 2021

nimiwio requested review of D107870: Support alias.scope and noalias metadata.
Aug 10 2021, 2:34 PM · Restricted Project
nimiwio added a comment to D107789: Support post-processing Ops in unrolled loop iterations.

Thank you for the review! Can this be committed?

Aug 10 2021, 9:44 AM · Restricted Project
nimiwio added inline comments to D107789: Support post-processing Ops in unrolled loop iterations.
Aug 10 2021, 9:43 AM · Restricted Project
nimiwio updated the diff for D107789: Support post-processing Ops in unrolled loop iterations.

Addressed comments.

Aug 10 2021, 9:42 AM · Restricted Project

Aug 9 2021

nimiwio requested review of D107789: Support post-processing Ops in unrolled loop iterations.
Aug 9 2021, 3:42 PM · Restricted Project