Thank you for the review! Can this be landed?

Address comments

In D115365#3186504, @bondhugula wrote:

Is this ready for review?

Use test.foo

Add checks for trip count and tests

Sorry didn't mean to send this for review quite yet, I still need to tweak this a bit, and add tests.

Thank you both for the discussion.. I'm not quite sure how to proceed on this though. As things stand right now, it seems like it is not safe for a pass to add custom attributes to a ForOp. Is this true for any Ops belonging to a Dialect not "owned" by a pass? The notion of "external" vs "intrinsic" attributes seems to make sense to me but if there's not agreement on that, is there some other way that we can propagate custom information about an Op besides through attributes? I'm not necessarily attached to this change, but I'm just not sure of a workable alternative right now.

In D111837#3066067, @mehdi_amini wrote:

It is a bit tricky, because we can't really know what these attributes are here for. For example they could refer to individual operands of the loop, but we just shuffled them (removed some).

Thank you for the review! Can you please land this change?

Ah, we wrote the same patch :) I missed the XFAIL on this test, I'll revert this one and let ftynse@ push the change through.

Thank you for the reviews! Could you please land this when you get a chance?

@mehdi_amini Unless there are other comments, could you please commit this change?

Address comments

Fix test

Address clang-tidy warnings

In D107789#2938910, @mehdi_amini wrote:

In D107789#2937367, @nimiwio wrote:

Thank you for the review! Can this be committed?

To clarify: are you asking me to commit for you (don't have commit access) or do you ask confirmation that you can land it now?

Minified test

Thank you for the review! Can this be committed?

Addressed comments.