This is an archive of the discontinued LLVM Phabricator instance.

[IR] Let ConstantVector::getSplat use poison instead of undef
ClosedPublic

Authored by david-arm on Aug 9 2021, 3:43 AM.

Details

Summary

This patch updates ConstantVector::getSplat to use poison instead
of undef when using insertelement/shufflevector to splat.

This follows on from D93793.

Diff Detail

Event Timeline

david-arm created this revision.Aug 9 2021, 3:43 AM
david-arm requested review of this revision.Aug 9 2021, 3:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2021, 3:43 AM

Looks ok to me but I've not been following the move away from undef, so I'll leave it for one of the reviewers who has.

aqjune accepted this revision.Aug 9 2021, 7:09 AM

LGTM, thank you for writing this patch.
Since the poison values in the insertelement and shufflevector are not visible from shufflevector's users, I believe this change is harmless.

This revision is now accepted and ready to land.Aug 9 2021, 7:09 AM
This revision was landed with ongoing or failed builds.Aug 10 2021, 12:52 AM
This revision was automatically updated to reflect the committed changes.