This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][GlobalISel] Emit extloads for ZExt/SExt values in assignValueToAddress
ClosedPublic

Authored by paquette on Aug 2 2021, 2:36 PM.

Details

Summary

When a value is expected to be extended, we should emit an extended load rather than a normal G_LOAD.

Add checklines to arm64-abi.ll which show that we now emit the correct loads.

For ease of comparison: https://godbolt.org/z/8WvY6EfdE

Diff Detail

Event Timeline

paquette created this revision.Aug 2 2021, 2:36 PM
paquette requested review of this revision.Aug 2 2021, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 2:36 PM
paquette abandoned this revision.Aug 2 2021, 2:37 PM
This comment was removed by paquette.
paquette reclaimed this revision.Aug 2 2021, 2:37 PM

agh left the comment on the wrong patch

aemerson accepted this revision.Aug 2 2021, 2:40 PM

LGTM.

This revision is now accepted and ready to land.Aug 2 2021, 2:40 PM
This revision was landed with ongoing or failed builds.Aug 2 2021, 2:50 PM
This revision was automatically updated to reflect the committed changes.