Page MenuHomePhabricator

[mlir][spirv] Fix storing bool with proper storage capabilities
ClosedPublic

Authored by antiagainst on Jul 29 2021, 3:52 PM.

Details

Summary

If the source value to store is bool, and we have native storage
capability support for the target bitwidth, we still cannot directly
store; we need to perform casting to match the target memref
element's bitwidth.

Diff Detail

Event Timeline

antiagainst created this revision.Jul 29 2021, 3:52 PM
antiagainst requested review of this revision.Jul 29 2021, 3:52 PM
antiagainst retitled this revision from [mlir][spirv] Fix storing bool with i8 storage capabilities to [mlir][spirv] Fix storing bool with proper storage capabilities.Jul 29 2021, 3:55 PM
antiagainst edited the summary of this revision. (Show Details)
hanchung accepted this revision.Jul 30 2021, 1:42 PM
This revision is now accepted and ready to land.Jul 30 2021, 1:42 PM
This revision was landed with ongoing or failed builds.Jul 30 2021, 3:07 PM
This revision was automatically updated to reflect the committed changes.