It looks like this array was missed in 4276d4a8d08b7640eb57cabf6988a5cf65b228b6
Fixed tests that expected elements to be empty or depeneded on the order of the empty DINode.
Paths
| Differential D107024
[DIBuilder] Do not replace empty enum types ClosedPublic Authored by ellis on Jul 28 2021, 8:01 PM.
Details
Summary It looks like this array was missed in 4276d4a8d08b7640eb57cabf6988a5cf65b228b6 Fixed tests that expected elements to be empty or depeneded on the order of the empty DINode.
Diff Detail
Event TimelineHerald added subscribers: dexonsmith, lxfind, hiraditya. · View Herald TranscriptJul 28 2021, 8:01 PM Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 28 2021, 8:01 PM Comment Actions I think that looks fine — I wonder if we should change the IR pretty printer to display empty arrays inline as elements: !{}, too. Comment Actions
I think that's a good idea, but it would require changing lots of tests. This revision is now accepted and ready to land.Aug 27 2021, 12:28 PM Closed by commit rG47b239eb5a17: [DIBuilder] Do not replace empty enum types (authored by ellis, committed by kyulee). · Explain WhyAug 30 2021, 12:34 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 369522 clang/test/CodeGen/debug-info-codeview-heapallocsite.c
clang/test/CodeGen/debug-info-macro.c
clang/test/CodeGenCXX/debug-info-codeview-var-templates.cpp
clang/test/CodeGenCXX/debug-info-cxx1y.cpp
clang/test/CodeGenCXX/debug-info-template.cpp
clang/test/CodeGenCXX/debug-info-var-template-partial-spec.cpp
clang/test/CodeGenCoroutines/coro-dwarf.cpp
llvm/lib/IR/DIBuilder.cpp
llvm/test/CodeGen/AArch64/GlobalISel/constant-mir-debugify.mir
llvm/test/CodeGen/AArch64/GlobalISel/phi-mir-debugify.mir
llvm/test/DebugInfo/debugify.ll
|