Page MenuHomePhabricator

[DIBuilder] Do not replace empty enum types
ClosedPublic

Authored by ellis on Jul 28 2021, 8:01 PM.

Details

Summary

It looks like this array was missed in 4276d4a8d08b7640eb57cabf6988a5cf65b228b6

Fixed tests that expected elements to be empty or depeneded on the order of the empty DINode.

Diff Detail

Event Timeline

ellis created this revision.Jul 28 2021, 8:01 PM
ellis requested review of this revision.Jul 28 2021, 8:01 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 28 2021, 8:01 PM
ellis updated this revision to Diff 362614.Jul 28 2021, 8:05 PM

Remove whitespace changes

ellis updated this revision to Diff 362637.Jul 28 2021, 10:13 PM

Fix broken coro test

I think that looks fine — I wonder if we should change the IR pretty printer to display empty arrays inline as elements: !{}, too.

ellis added a comment.Aug 4 2021, 3:31 PM

I think that looks fine — I wonder if we should change the IR pretty printer to display empty arrays inline as elements: !{}, too.

I think that's a good idea, but it would require changing lots of tests.

@aprantl @dblaikie Can I get a review soon to avoid merge conflicts on these tests?

aprantl accepted this revision.Fri, Aug 27, 12:28 PM

Thanks!

This revision is now accepted and ready to land.Fri, Aug 27, 12:28 PM
This revision was automatically updated to reflect the committed changes.