This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][AsmParser] NFC: Parser.getTok().getLoc() -> getLoc()
ClosedPublic

Authored by c-rhodes on Jul 22 2021, 11:41 PM.

Diff Detail

Event Timeline

c-rhodes created this revision.Jul 22 2021, 11:41 PM
c-rhodes requested review of this revision.Jul 22 2021, 11:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2021, 11:41 PM
tmatheson added inline comments.
llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
3164

Does parseExpression above update the current token and hence the location?

c-rhodes updated this revision to Diff 361250.Jul 23 2021, 9:15 AM

address @tmatheson comment

c-rhodes added inline comments.Jul 23 2021, 9:19 AM
llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
3164

Does parseExpression above update the current token and hence the location?

Yeah thanks for pointing that out I missed that. There's actually a test for this already in llvm/test/MC/AArch64/shift_extend_op_w_symbol.s but whitespace was being ignored so the ^ could have been anywhere and it would pass. I've updated it to use --match-full-lines --strict-whitespace.

tmatheson accepted this revision.Jul 26 2021, 1:22 AM
This revision is now accepted and ready to land.Jul 26 2021, 1:22 AM
This revision was landed with ongoing or failed builds.Jul 26 2021, 2:37 AM
This revision was automatically updated to reflect the committed changes.