This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Use CommandMangler in TestTU
ClosedPublic

Authored by kadircet on Jul 22 2021, 3:12 AM.

Details

Summary

This makes testing setup look closer to production.

Diff Detail

Event Timeline

kadircet created this revision.Jul 22 2021, 3:12 AM
kadircet requested review of this revision.Jul 22 2021, 3:12 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 22 2021, 3:12 AM
sammccall accepted this revision.Jul 22 2021, 3:17 AM
This revision is now accepted and ready to land.Jul 22 2021, 3:17 AM

I guess this is technically untested, but will be covered after D106527?

This revision was landed with ongoing or failed builds.Jul 23 2021, 8:15 AM
This revision was automatically updated to reflect the committed changes.
thakis added a subscriber: thakis.Jul 23 2021, 8:45 AM

One of your 4 commits in https://github.com/llvm/llvm-project/compare/f86570cd5241...ba5dd945ad91 broke check-clangd on arm macs:

http://45.33.8.238/macm1/14648/step_9.txt

Please take a look, and revert for now if it takes a while to fix. (And consider spreading out commits a bit, so it's clearer which one is to blame.)

[clangd] Get rid of arg adjusters in CommandMangler can crash BuildCompilerInvocation.DropsPlugins.

I am testing ninja check-clangd and will push the revert shortly.

Can you provide a reproducer or build bot failure for the crash Fangrui ?

Can you provide a reproducer or build bot failure for the crash Fangrui ?

I already provided an internal bug :)