[SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8

[NancyWang2222]

Summary

This PR to fix a few test cases related to class https://en.cppreference.com/w/cpp/locale/codecvt , as mentioned in document, class is converting UTF16 and UTF8 or UTF32 and UTF8, character type is deprecated in c++20 and it needs explicitly specify it is UTF8 string literal. Current test cases assume 1 byte character is ASCII or Unicode character which is not true on z/OS platform. UTF8/16/32 information can be found in https://naveenr.net/unicode-character-set-and-utf-8-utf-16-utf-32-encoding/ and EBCDIC and ASCII character value can be found in http://www.simotime.com/asc2ebc1.htm

[NancyWang2222]

do we know why build are failing ?

[• Quuxplusone]

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp

34

do we know why builds are failing?

Same as in the other patch D106151: u8"some text" is a syntax error in C++03, so (only) the C++03 run is failing.

[NancyWang2222]

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp

34

OK. should we disable those test to avoid run with c++20 then ? I can modify test case to run only ASCII mode if we keep old form.

[NancyWang2222]

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp

34

OK. I can keep old form. just run ASCII mode on z/OS for both patch.

[NancyWang2222]

change test cases to be unsupported on z/OS

[NancyWang2222]

hi Arthur O'Dwyer , I have updated test, can you review it? Thanks

[• Quuxplusone]

Same as D106151: if @ldionne approves the use of the regex (either here or there or both), then I'd think you can land both D106151 and D106153.

[ldionne]

LGTM, but please add a 1-2 line comment for each UNSUPPORTED explaining why it fails. You can copy/paste the comment, it's fine. Actually, it even helps cause you can then grep for:

// <the-comment>
// UNSUPPORTED: target={{.+}}-zos{{.*}}

and you'll find all tests that are marked as unsupported for the same reason.

[ldionne]

In D106153#2890692, @ldionne wrote:

LGTM, but please add a 1-2 line comment for each UNSUPPORTED explaining why it fails. You can copy/paste the comment, it's fine. Actually, it even helps cause you can then grep for:

// <the-comment>
// UNSUPPORTED: target={{.+}}-zos{{.*}}

and you'll find all tests that are marked as unsupported for the same reason.

@muiez

Please read the comments even when you get an approval. https://reviews.llvm.org/rG7704fedfff6ef5676adb6415f3be0ac927d1a746 didn't apply my requested change. I LGTM'd the patch because I trusted you'd apply the feedback and didn't want to block you until I could look at it again -- not because no changes were required.

[NancyWang2222]

In D106153#2891424, @ldionne wrote:

In D106153#2890692, @ldionne wrote:

LGTM, but please add a 1-2 line comment for each UNSUPPORTED explaining why it fails. You can copy/paste the comment, it's fine. Actually, it even helps cause you can then grep for:

// <the-comment>
// UNSUPPORTED: target={{.+}}-zos{{.*}}

and you'll find all tests that are marked as unsupported for the same reason.

@muiez

Please read the comments even when you get an approval. https://reviews.llvm.org/rG7704fedfff6ef5676adb6415f3be0ac927d1a746 didn't apply my requested change. I LGTM'd the patch because I trusted you'd apply the feedback and didn't want to block you until I could look at it again -- not because no changes were required.

hi nothing to do w3ith Muiez, I asked his help to commit it for me. I didnt notice your comments. I can add comment no problem

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp

 
 // result in(stateT& state,
 //           const externT* from, const externT* from_end, const externT*& from_next,
 //           internT* to, internT* to_end, internT*& to_next) const;
 
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// UNSUPPORTED: target={{.+}}-zos{{.*}}
+
 #include <locale>
 #include <string>
 #include <vector>
 #include <cassert>
 
 #include "test_macros.h"
 
 typedef std::codecvt<char16_t, char, std::mbstate_t> F;
 
 int main(int, char**)
 {
     std::locale l = std::locale::classic();
     const char from[] = "some text";
     F::intern_type to[9];
     const F& f = std::use_facet<F>(l);
     std::mbstate_t mbs = {};
     const char* from_next = 0;
     F::intern_type* to_next = 0;
     assert(f.in(mbs, from, from + 9, from_next,
                      to, to + 9, to_next) == F::ok);
     assert(from_next - from == 9);
     assert(to_next - to == 9);
     for (unsigned i = 0; i < 9; ++i)
         assert(to[i] == from[i]);
 
   return 0;
 }

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp

 
 // template <> class codecvt<char16_t, char, mbstate_t>
 
 // int length(stateT& state, const externT* from, const externT* from_end, size_t max) const;
 
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// UNSUPPORTED: target={{.+}}-zos{{.*}}
+
 #include <locale>
 #include <cassert>
 
 #include "test_macros.h"
 
 typedef std::codecvt<char16_t, char, std::mbstate_t> F;
 
 int main(int, char**)

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp

 
 // result in(stateT& state,
 //           const externT* from, const externT* from_end, const externT*& from_next,
 //           internT* to, internT* to_end, internT*& to_next) const;
 
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// UNSUPPORTED: target={{.+}}-zos{{.*}}
+
 #include <locale>
 #include <string>
 #include <vector>
 #include <cassert>
 
 #include "test_macros.h"
 
 typedef std::codecvt<char32_t, char, std::mbstate_t> F;

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp

 
 // template <> class codecvt<char32_t, char, mbstate_t>
 
 // int length(stateT& state, const externT* from, const externT* from_end, size_t max) const;
 
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// UNSUPPORTED: target={{.+}}-zos{{.*}}
+
 #include <locale>
 #include <cassert>
 
 #include "test_macros.h"
 
 typedef std::codecvt<char32_t, char, std::mbstate_t> F;
 
 int main(int, char**)