This is an archive of the discontinued LLVM Phabricator instance.

Differential D106404

[SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151
ClosedPublic

Authored by NancyWang2222 on Jul 20 2021, 3:08 PM.

Details

Reviewers
ldionne
• Quuxplusone
SeanP
uweigand
muiez
fanbo-meng
Group Reviewers
Restricted Project
Commits
rG6ba493d81b07: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151
Summary

This patch is to add the missing comments in https://reviews.llvm.org/D106153 and https://reviews.llvm.org/D106151 to address comments from @ldionne , sorry for the inconvenience.

Diff Detail

Event Timeline

NancyWang2222 requested review of this revision.Jul 20 2021, 3:08 PM
NancyWang2222 created this revision.
Harbormaster completed remote builds in B115205: Diff 360288.Jul 20 2021, 4:39 PM
ldionne accepted this revision.Jul 21 2021, 7:50 AM

Thanks!

This revision is now accepted and ready to land.Jul 21 2021, 7:50 AM
Closed by commit rG6ba493d81b07: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151 (authored by NancyWang2222, committed by muiez). · Explain WhyJul 21 2021, 10:50 AM
This revision was automatically updated to reflect the committed changes.
muiez added a commit: rG6ba493d81b07: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151.
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2021, 10:50 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript

Revision Contents

PathSize
libcxx/
test/
std/
localization/
locale.categories/
category.ctype/
locale.codecvt/
locale.codecvt.members/
3 lines
3 lines
3 lines
3 lines
3 lines
3 lines

Diff 360521

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp

Show All 11 Lines
// result in(stateT& state, // result in(stateT& state,
// const externT* from, const externT* from_end, const externT*& from_next, // const externT* from, const externT* from_end, const externT*& from_next,
// internT* to, internT* to_end, internT*& to_next) const; // internT* to, internT* to_end, internT*& to_next) const;
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20. // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
// Test is intended to convert between UTF8 and UTF16/32, it will fail on
// z/OS since at default char type on z/OS is EBCDIC character which has
// value different from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}} // UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale> #include <locale>
#include <string> #include <string>
#include <vector> #include <vector>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
Show All 21 Lines

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp

Show All 9 Lines
// template <> class codecvt<char16_t, char, mbstate_t> // template <> class codecvt<char16_t, char, mbstate_t>
// int length(stateT& state, const externT* from, const externT* from_end, size_t max) const; // int length(stateT& state, const externT* from, const externT* from_end, size_t max) const;
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20. // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
// Test is intended to convert between UTF8 and UTF16/32, it will fail on
// z/OS since at default char type on z/OS is EBCDIC character which has
// value different from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}} // UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
typedef std::codecvt<char16_t, char, std::mbstate_t> F; typedef std::codecvt<char16_t, char, std::mbstate_t> F;
Show All 15 Lines

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp

Show All 11 Lines
// result out(stateT& state, // result out(stateT& state,
// const internT* from, const internT* from_end, const internT*& from_next, // const internT* from, const internT* from_end, const internT*& from_next,
// externT* to, externT* to_end, externT*& to_next) const; // externT* to, externT* to_end, externT*& to_next) const;
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20. // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
// Test is intended to convert between UTF8 and UTF16/32, it will fail on
// z/OS since at default char type on z/OS is EBCDIC character which has
// value different from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}} // UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale> #include <locale>
#include <string> #include <string>
#include <vector> #include <vector>
#include <cassert> #include <cassert>
#include <stdio.h> #include <stdio.h>
Show All 26 Lines

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp

Show All 11 Lines
// result in(stateT& state, // result in(stateT& state,
// const externT* from, const externT* from_end, const externT*& from_next, // const externT* from, const externT* from_end, const externT*& from_next,
// internT* to, internT* to_end, internT*& to_next) const; // internT* to, internT* to_end, internT*& to_next) const;
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20. // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
// Test is intended to convert between UTF8 and UTF16/32, it will fail on
// z/OS since at default char type on z/OS is EBCDIC character which has
// value different from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}} // UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale> #include <locale>
#include <string> #include <string>
#include <vector> #include <vector>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
Show All 21 Lines

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp

Show All 9 Lines
// template <> class codecvt<char32_t, char, mbstate_t> // template <> class codecvt<char32_t, char, mbstate_t>
// int length(stateT& state, const externT* from, const externT* from_end, size_t max) const; // int length(stateT& state, const externT* from, const externT* from_end, size_t max) const;
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20. // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
// Test is intended to convert between UTF8 and UTF16/32, it will fail on
// z/OS since at default char type on z/OS is EBCDIC character which has
// value different from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}} // UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale> #include <locale>
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
typedef std::codecvt<char32_t, char, std::mbstate_t> F; typedef std::codecvt<char32_t, char, std::mbstate_t> F;
Show All 15 Lines

libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp

Show All 11 Lines
// result out(stateT& state, // result out(stateT& state,
// const internT* from, const internT* from_end, const internT*& from_next, // const internT* from, const internT* from_end, const internT*& from_next,
// externT* to, externT* to_end, externT*& to_next) const; // externT* to, externT* to_end, externT*& to_next) const;
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20. // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
// Test is intended to convert between UTF8 and UTF16/32, it will fail on
// z/OS since at default char type on z/OS is EBCDIC character which has
// value different from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}} // UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale> #include <locale>
#include <string> #include <string>
#include <vector> #include <vector>
#include <cassert> #include <cassert>
#include <stdio.h> #include <stdio.h>
Show All 26 Lines