Page MenuHomePhabricator

[mlir] Fully qualify types and expressions in Interfaces
ClosedPublic

Authored by zero9178 on Jul 8 2021, 3:04 AM.

Details

Summary

This patch adds full qualification to the types and function calls used inside of (Static)InterfaceMethod in OpInterfaces. Without this patch using many of these interfaces in a downstream project yields compiler errors as the types and default implementations are mostly copied verbatim. Without then putting using namespace mlir; in the header file of the implementations of those interfaces, compilation is impossible.

Using fully qualified lookup fixes this issue.

Diff Detail

Event Timeline

zero9178 created this revision.Jul 8 2021, 3:04 AM
zero9178 requested review of this revision.Jul 8 2021, 3:04 AM
zero9178 updated this revision to Diff 357179.Jul 8 2021, 3:13 AM

Add a few more I have missed in the first diff

lattner accepted this revision.Jul 8 2021, 6:34 AM

nice

This revision is now accepted and ready to land.Jul 8 2021, 6:34 AM
This revision was automatically updated to reflect the committed changes.