This is an archive of the discontinued LLVM Phabricator instance.

Differential D105434

[mlir] Unbreak building mlir-reduce
ClosedPublic

Authored by marbre on Jul 5 2021, 8:04 AM.

Details

Reviewers
rriddle
Chia-hungDuan
mehdi_amini
ftynse
Commits
rG96e3fb2416f6: [mlir] Unbreak building mlir-reduce
Summary

Unbreaks building mlir-reduce when DLLVM_INCLUDE_TESTS is set to OFF.
The dependency MLIRTestDialect is only available if building with tests.

Diff Detail

Event Timeline

marbre created this revision.Jul 5 2021, 8:04 AM
Herald added subscribers: dcaballe, cota, teijeong and 15 others. · View Herald TranscriptJul 5 2021, 8:04 AM
marbre requested review of this revision.Jul 5 2021, 8:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2021, 8:04 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ftynse accepted this revision.Jul 5 2021, 8:06 AM
ftynse added a subscriber: ftynse.

Feel free to submit build fixes directly to through git.

This revision is now accepted and ready to land.Jul 5 2021, 8:06 AM
This revision was landed with ongoing or failed builds.Jul 5 2021, 8:10 AM
Closed by commit rG96e3fb2416f6: [mlir] Unbreak building mlir-reduce (authored by marbre). · Explain Why
This revision was automatically updated to reflect the committed changes.
marbre added a commit: rG96e3fb2416f6: [mlir] Unbreak building mlir-reduce.
Harbormaster completed remote builds in B112451: Diff 356508.Jul 5 2021, 8:33 AM
Chia-hungDuan added a comment.Jul 5 2021, 3:18 PM

Sorry about this, thanks for fixing it!

Revision Contents

PathSize
mlir/
tools/
mlir-reduce/
8 lines

Diff 356510

mlir/tools/mlir-reduce/CMakeLists.txt

get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS) get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS) get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
if(MLIR_INCLUDE_TESTS)
set(test_libs
MLIRTestDialect
)
endif()
set(LIBS set(LIBS
${conversion_libs} ${conversion_libs}
${dialect_libs} ${dialect_libs}
${test_libs}
MLIRDialect MLIRDialect
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRReduceLib MLIRReduceLib
MLIRTestDialect
) )
add_llvm_tool(mlir-reduce add_llvm_tool(mlir-reduce
mlir-reduce.cpp mlir-reduce.cpp
DEPENDS DEPENDS
${LIBS} ${LIBS}
) )
target_link_libraries(mlir-reduce PRIVATE ${LIBS}) target_link_libraries(mlir-reduce PRIVATE ${LIBS})
llvm_update_compile_flags(mlir-reduce) llvm_update_compile_flags(mlir-reduce)
mlir_check_all_link_libraries(mlir-reduce) mlir_check_all_link_libraries(mlir-reduce)