This is an archive of the discontinued LLVM Phabricator instance.

Differential D105400

[clangd][iwyu] explicitly includes `<atomic>`
ClosedPublic

Authored by cjdb on Jul 3 2021, 7:19 PM.

Details

Reviewers
nridge
Commits
rG478092d33116: [clangd][iwyu] explicitly includes `<atomic>`
Summary

Compiling clangd with Clang modules and libc++ revealed that
support/Threading.h uses std::atomic but wasn't including the
correct header.

Diff Detail

Event Timeline

cjdb created this revision.Jul 3 2021, 7:19 PM
Herald added subscribers: usaxena95, kadircet, jfb, arphaman. · View Herald TranscriptJul 3 2021, 7:19 PM
cjdb requested review of this revision.Jul 3 2021, 7:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2021, 7:19 PM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
Harbormaster completed remote builds in B112340: Diff 356357.Jul 3 2021, 7:57 PM
nridge accepted this revision.Jul 3 2021, 9:43 PM
nridge added a subscriber: nridge.

Thanks!

This revision is now accepted and ready to land.Jul 3 2021, 9:43 PM
Closed by commit rG478092d33116: [clangd][iwyu] explicitly includes `<atomic>` (authored by cjdb). · Explain WhyJul 3 2021, 11:01 PM
This revision was automatically updated to reflect the committed changes.
cjdb added a commit: rG478092d33116: [clangd][iwyu] explicitly includes `<atomic>`.

Revision Contents

PathSize
clang-tools-extra/
clangd/
support/
1 line

Diff 356367

clang-tools-extra/clangd/support/Threading.h

//===--- Threading.h - Abstractions for multithreading -----------*- C++-*-===// //===--- Threading.h - Abstractions for multithreading -----------*- C++-*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_SUPPORT_THREADING_H #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_SUPPORT_THREADING_H
#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_SUPPORT_THREADING_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_SUPPORT_THREADING_H
#include "support/Context.h" #include "support/Context.h"
#include "llvm/ADT/FunctionExtras.h" #include "llvm/ADT/FunctionExtras.h"
#include "llvm/ADT/Twine.h" #include "llvm/ADT/Twine.h"
#include <atomic>
#include <cassert> #include <cassert>
#include <condition_variable> #include <condition_variable>
#include <future> #include <future>
#include <memory> #include <memory>
#include <mutex> #include <mutex>
#include <thread> #include <thread>
#include <vector> #include <vector>
▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines