Page MenuHomePhabricator

[mlir][Vector] NFC - Compress vector to outerproduct lowering.

Authored by nicolasvasilache on Jul 2 2021, 9:34 AM.



The implementation has become too unwieldy and cognitive overhead wins.
Instead compress the implementation in preparation for additional lowering paths.

Diff Detail

Event Timeline

nicolasvasilache requested review of this revision.Jul 2 2021, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2021, 9:34 AM
ThomasRaoux accepted this revision.Jul 2 2021, 9:38 AM
This revision is now accepted and ready to land.Jul 2 2021, 9:38 AM
This revision was landed with ongoing or failed builds.Jul 2 2021, 9:42 AM
This revision was automatically updated to reflect the committed changes.

This change broke the Windows mlir bot:

It also broke the GCC testing. I suspect the output code is made dependent on the order of evaluation of function arguments.

Reverted for now.

mehdi_amini added inline comments.Jul 2 2021, 11:00 AM

Here: e.t(lhs), e.t(rhs) are not ordered unfortunately.


(same here)

hmm the build was green on all platforms in this diff's buildbot..
trying again in

Hmm actually it was not, sorry about that, I must have misinterpreted the green checkbox, I'll be extra careful with the followup.