This is an archive of the discontinued LLVM Phabricator instance.

LGTM. I assume we pick the integer value 202011 for everything C++2b-related until the standard ships with a real value in it, and then we update our integer to match.

This revision is now accepted and ready to land.Jun 26 2021, 1:45 PM

In D104984#2842656, @Quuxplusone wrote:

LGTM. I assume we pick the integer value 202011 for everything C++2b-related until the standard ships with a real value in it, and then we update our integer to match.

Yeah that is what I am going for here.

This revision was landed with ongoing or failed builds.Jun 26 2021, 2:05 PM

Closed by commit rGd6144c30fb6a: [clang] add C++ feature test macro for P2266 simpler implicit move (authored by mizvekov). · Explain Why

This revision was automatically updated to reflect the committed changes.

mizvekov added a commit: rGd6144c30fb6a: [clang] add C++ feature test macro for P2266 simpler implicit move.

Harbormaster completed remote builds in B111152: Diff 354703.Jun 26 2021, 2:19 PM

Revision Contents

Path

Size

clang/

lib/

Frontend/

InitPreprocessor.cpp

4 lines

test/

Lexer/

cxx-features.cpp

4 lines

Diff 354709

clang/lib/Frontend/InitPreprocessor.cpp

Show First 20 Lines • Show All 591 Lines • ▼ Show 20 Lines	if (LangOpts.CPlusPlus20) {
Builder.defineMacro("__cpp_constinit", "201907L");		Builder.defineMacro("__cpp_constinit", "201907L");
//Builder.defineMacro("__cpp_coroutines", "201902L");		//Builder.defineMacro("__cpp_coroutines", "201902L");
Builder.defineMacro("__cpp_designated_initializers", "201707L");		Builder.defineMacro("__cpp_designated_initializers", "201707L");
Builder.defineMacro("__cpp_impl_three_way_comparison", "201907L");		Builder.defineMacro("__cpp_impl_three_way_comparison", "201907L");
//Builder.defineMacro("__cpp_modules", "201907L");		//Builder.defineMacro("__cpp_modules", "201907L");
Builder.defineMacro("__cpp_using_enum", "201907L");		Builder.defineMacro("__cpp_using_enum", "201907L");
}		}
// C++2b features.		// C++2b features.
if (LangOpts.CPlusPlus2b)		if (LangOpts.CPlusPlus2b) {
		Builder.defineMacro("__cpp_implicit_move", "202011L");
Builder.defineMacro("__cpp_size_t_suffix", "202011L");		Builder.defineMacro("__cpp_size_t_suffix", "202011L");
		}
if (LangOpts.Char8)		if (LangOpts.Char8)
Builder.defineMacro("__cpp_char8_t", "201811L");		Builder.defineMacro("__cpp_char8_t", "201811L");
Builder.defineMacro("__cpp_impl_destroying_delete", "201806L");		Builder.defineMacro("__cpp_impl_destroying_delete", "201806L");

// TS features.		// TS features.
if (LangOpts.Coroutines)		if (LangOpts.Coroutines)
Builder.defineMacro("__cpp_coroutines", "201703L");		Builder.defineMacro("__cpp_coroutines", "201703L");
}		}
▲ Show 20 Lines • Show All 672 Lines • Show Last 20 Lines

clang/test/Lexer/cxx-features.cpp

	Show All 25 Lines
	#elif __cplusplus == 202002L			#elif __cplusplus == 202002L
	#define check(macro, cxx98, cxx11, cxx14, cxx17, cxx20, cxx23) (cxx20 == 0 ? defined(__cpp_##macro) : __cpp_##macro != cxx20)			#define check(macro, cxx98, cxx11, cxx14, cxx17, cxx20, cxx23) (cxx20 == 0 ? defined(__cpp_##macro) : __cpp_##macro != cxx20)
	#else			#else
	#define check(macro, cxx98, cxx11, cxx14, cxx17, cxx20, cxx23) (cxx23 == 0 ? defined(__cpp_##macro) : __cpp_##macro != cxx23)			#define check(macro, cxx98, cxx11, cxx14, cxx17, cxx20, cxx23) (cxx23 == 0 ? defined(__cpp_##macro) : __cpp_##macro != cxx23)
	#endif			#endif

	// --- C++2b features ---			// --- C++2b features ---

				#if check(implicit_move, 0, 0, 0, 0, 0, 202011)
				#error "wrong value for __cpp_implicit_move"
				#endif

	#if check(size_t_suffix, 0, 0, 0, 0, 0, 202011)			#if check(size_t_suffix, 0, 0, 0, 0, 0, 202011)
	#error "wrong value for __cpp_size_t_suffix"			#error "wrong value for __cpp_size_t_suffix"
	#endif			#endif

	// --- C++20 features ---			// --- C++20 features ---

	#if check(aggregate_paren_init, 0, 0, 0, 0, 0, 0)			#if check(aggregate_paren_init, 0, 0, 0, 0, 0, 0)
	// FIXME: 201902 in C++20			// FIXME: 201902 in C++20
	▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[clang] add C++ feature test macro for P2266 simpler implicit moveClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 354709

clang/lib/Frontend/InitPreprocessor.cpp

clang/test/Lexer/cxx-features.cpp

[clang] add C++ feature test macro for P2266 simpler implicit move
ClosedPublic