Page MenuHomePhabricator

[lldb] Remove more redundant SetStatus(eReturnStatusFailed)
ClosedPublic

Authored by DavidSpickett on Jun 22 2021, 3:35 AM.

Details

Summary

Mostly by converting uses of GetErrorStream to AppendError,
so that the call to SetStatus is implicit.

Some remain where it isn't certain that you'll have a message
to set, or you want the output to be on stdout.

One place in CommandObjectWatchpoint previously didn't set
the status to failed at all. However it's pretty obvious
that it should do so.

Diff Detail

Event Timeline

DavidSpickett requested review of this revision.Jun 22 2021, 3:35 AM
DavidSpickett created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2021, 3:35 AM
teemperor accepted this revision.Jun 22 2021, 3:40 AM
teemperor added inline comments.
lldb/source/Commands/CommandObjectReproducer.cpp
141

You can drop the c_str()

This revision is now accepted and ready to land.Jun 22 2021, 3:40 AM

Remove c_str() in Reproducer.

This revision was landed with ongoing or failed builds.Jun 22 2021, 8:28 AM
This revision was automatically updated to reflect the committed changes.
DavidSpickett marked an inline comment as done.Jun 22 2021, 8:28 AM