I believe the approach is agreed.
Tag dispatching implementation is complete with all planned changes to do.
Welcome again for review:)
Depends on: https://reviews.llvm.org/D114624
Paths
| Differential D104492
[libc++][pstl] Implement tag dispatching ClosedPublic Authored by rarutyun on Jun 17 2021, 3:53 PM.
Details
Summary I believe the approach is agreed. Tag dispatching implementation is complete with all planned changes to do. Welcome again for review:) Depends on: https://reviews.llvm.org/D114624
Diff Detail
Event Timeline
• Quuxplusone added inline comments.
rarutyun added inline comments.
rarutyun added a parent revision: D114624: [pstl] Fix incorrect usage of std::invoke_result.Nov 26 2021, 3:12 AM rarutyun marked an inline comment as done. Comment ActionsAdd tag_dispatching mechanism for OpenMP backend
Comment Actions In spite of my minor comments it LGTM.
Comment Actions CI is green, @MikeDvorskiy and @rodgert approved that previously. I believe we can finally merge it. Closed by commit rG843c12d6a0cd: [libc++][pstl] Implement tag dispatching mechanism for Parallel STL (authored by rarutyun). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 390120 pstl/include/pstl/internal/algorithm_fwd.h
pstl/include/pstl/internal/algorithm_impl.h
pstl/include/pstl/internal/execution_defs.h
pstl/include/pstl/internal/execution_impl.h
pstl/include/pstl/internal/glue_algorithm_impl.h
pstl/include/pstl/internal/glue_memory_impl.h
pstl/include/pstl/internal/glue_numeric_impl.h
pstl/include/pstl/internal/numeric_fwd.h
pstl/include/pstl/internal/numeric_impl.h
pstl/include/pstl/internal/omp/parallel_for.h
pstl/include/pstl/internal/omp/parallel_invoke.h
pstl/include/pstl/internal/omp/parallel_merge.h
pstl/include/pstl/internal/omp/parallel_reduce.h
pstl/include/pstl/internal/omp/parallel_scan.h
pstl/include/pstl/internal/omp/parallel_stable_partial_sort.h
pstl/include/pstl/internal/omp/parallel_stable_sort.h
pstl/include/pstl/internal/omp/parallel_transform_reduce.h
pstl/include/pstl/internal/omp/parallel_transform_scan.h
pstl/include/pstl/internal/parallel_backend_serial.h
pstl/include/pstl/internal/parallel_backend_tbb.h
pstl/include/pstl/internal/parallel_impl.h
pstl/test/std/numerics/numeric.ops/scan.fail.cpp
pstl/test/support/utils.h
|
I believe you need to add pstl/include to
https://github.com/google/llvm-premerge-checks/blob/main/scripts/clang-tidy.ignore
(Although why this file is in a Google repo instead of the llvm-project repo, I don't know!)