Page MenuHomePhabricator

rarutyun (Ruslan Arutyunyan)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 4 2020, 3:30 PM (41 w, 6 d)

Recent Activity

Fri, Jun 18

rarutyun updated the diff for D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.

Partially apply comments. Others are in progress.

Fri, Jun 18, 5:17 PM · Restricted Project

Thu, Jun 17

rarutyun added inline comments to D104492: [libc++][pstl] Implement tag dispatching.
Thu, Jun 17, 3:57 PM · Restricted Project
rarutyun requested review of D104492: [libc++][pstl] Implement tag dispatching.
Thu, Jun 17, 3:53 PM · Restricted Project

Fri, Jun 11

rarutyun added a comment to D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.

Ping. @rarutyun this is blocking other work now; will you have time to work on this next week, or would you prefer I take over?

Fri, Jun 11, 1:51 PM · Restricted Project

Wed, Jun 2

rarutyun requested review of D103581: [libc++][compare]Implement compare_three_way_result[_t].
Wed, Jun 2, 5:42 PM · Restricted Project

Tue, Jun 1

rarutyun requested review of D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.
Tue, Jun 1, 11:29 AM · Restricted Project

Feb 16 2021

rarutyun added inline comments to D96657: [libcxx] adds common_reference to <type_traits>.
Feb 16 2021, 6:27 AM · Restricted Project

Feb 1 2021

rarutyun updated the diff for D90968: Fix for the Bug 41784.
Feb 1 2021, 4:06 AM · Restricted Project

Jan 31 2021

rarutyun updated the diff for D90968: Fix for the Bug 41784.
Jan 31 2021, 1:54 PM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Jan 31 2021, 1:04 PM · Restricted Project
rarutyun added a comment to D90968: Fix for the Bug 41784.

That's all I can think of. We could have checked for !std::is_constructible<std::atomic<T>, std::atomic<T> const volatile&>, but as you say, the spec seems to allow it right now.

Done. I decided to do it for copy-constructor and both volatile and non-volatile overload of copy-assignment. And the same is done for pointer specialization for all three methods.

Jan 31 2021, 12:35 PM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Jan 31 2021, 12:30 PM · Restricted Project

Jan 25 2021

rarutyun added a comment to D90968: Fix for the Bug 41784.

In addition to the comments I made, can you please add tests using the type traits like static_assert(!std::is_copy_constructible_v<std::atomic<int>>);?

Jan 25 2021, 2:49 PM · Restricted Project
rarutyun added inline comments to D90968: Fix for the Bug 41784.
Jan 25 2021, 2:47 PM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Jan 25 2021, 2:45 PM · Restricted Project
rarutyun added inline comments to D90968: Fix for the Bug 41784.
Jan 25 2021, 2:44 PM · Restricted Project
rarutyun requested review of D95372: Follow up build fix for P0655R1 visit<R>: Explicit Return Type for visit.
Jan 25 2021, 9:20 AM · Restricted Project

Jan 18 2021

rarutyun added a comment to D90968: Fix for the Bug 41784.

What about this patch? should I ping Olivier that he has a look?

Jan 18 2021, 2:56 PM · Restricted Project
rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Do you need help committing this?

I think so.

I would prefer to go through this path myself, to make commits directly (if it's possible and if I have enough permissions to do that). It's just may save the time of other people and your time in particular:) Currently, I just don't know what to do. So if you (or somebody else) can teach me it would be great.

But I don't mind if you merge it yourself. Please choose the way that works better for you.

The steps to gain commit access are explained here: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. It's generally for people with a history of submitting patches already, so I'll let you judge whether you think it's right for you or not.

In the meantime, I'm happy to apply your patch. Can you please provide Author Name <email@domain> so I can properly attribute the commit?

Jan 18 2021, 2:54 PM · Restricted Project
rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Do you need help committing this?

Jan 18 2021, 1:41 PM · Restricted Project

Jan 12 2021

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Jan 12 2021, 8:58 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Jan 12 2021, 8:26 AM · Restricted Project
rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

@rarutyun Can you please rebase onto main so that the CI will trigger? I added the LLVM monorepo tag to the review.

Jan 12 2021, 7:54 AM · Restricted Project
rarutyun updated the diff for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Jan 12 2021, 7:32 AM · Restricted Project

Jan 11 2021

rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Michael approved this review. Can we proceed?

Jan 11 2021, 1:45 AM · Restricted Project

Dec 29 2020

rarutyun added a comment to D90968: Fix for the Bug 41784.

Any progress on that review? Should I rebase it one more time?

Dec 29 2020, 1:56 AM · Restricted Project

Dec 28 2020

rarutyun added inline comments to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Dec 28 2020, 1:55 PM · Restricted Project
rarutyun updated the diff for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Dec 28 2020, 1:51 PM · Restricted Project

Dec 14 2020

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Dec 14 2020, 8:47 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Dec 14 2020, 8:47 AM · Restricted Project

Dec 10 2020

rarutyun added inline comments to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Dec 10 2020, 3:15 PM · Restricted Project
rarutyun updated the diff for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Dec 10 2020, 2:46 PM · Restricted Project

Dec 9 2020

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Dec 9 2020, 8:45 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Dec 9 2020, 8:43 AM · Restricted Project

Dec 8 2020

rarutyun added inline comments to D90968: Fix for the Bug 41784.
Dec 8 2020, 9:40 AM · Restricted Project
rarutyun updated the diff for D90968: Fix for the Bug 41784.
Dec 8 2020, 9:33 AM · Restricted Project

Nov 26 2020

rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

I also faintly remember that we already tried implementing this in libc++, didn't we?

Nov 26 2020, 3:27 AM · Restricted Project

Nov 24 2020

rarutyun removed 1 blocking reviewer(s) for D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit: Restricted Project.
Nov 24 2020, 10:06 AM · Restricted Project
rarutyun added a comment to D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.

Didn't find corresponding feature macro. Let me know if we need to do something with that.

Nov 24 2020, 10:05 AM · Restricted Project
rarutyun requested review of D92044: Implement P0655R1 visit<R>: Explicit Return Type for visit.
Nov 24 2020, 10:00 AM · Restricted Project

Nov 11 2020

rarutyun added a comment to D87171: Implement P0919R3.

I prepared the small change with adding the proper release version but I cannot upload the new diff. I guess that's because I am not author anymore @ldionne, is it possible to make me author again? I didn't find the way to do it myself, I guess I don't have permissions for that.

Nov 11 2020, 2:23 PM · Restricted Project

Nov 10 2020

rarutyun added a comment to D87171: Implement P0919R3.

By the way currently the tests failed on GCC with friend approach.

Nov 10 2020, 3:31 PM · Restricted Project
rarutyun added a comment to D87171: Implement P0919R3.

I think this is pretty much good to go, however there's a specific way I'd like to structure the test harness to make the approach clearer. I'll commandeer this because it's a lot easier than explaining exactly what I mean, but LMK if you're OK with my approach. It's very very close to yours.

Nov 10 2020, 2:39 PM · Restricted Project

Nov 6 2020

rarutyun requested review of D90968: Fix for the Bug 41784.
Nov 6 2020, 1:08 PM · Restricted Project

Oct 29 2020

rarutyun added a comment to D87171: Implement P0919R3.

@ldionne any thoughts on the current state of the review?

Oct 29 2020, 3:08 PM · Restricted Project

Oct 28 2020

rarutyun added inline comments to D87171: Implement P0919R3.
Oct 28 2020, 4:42 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 28 2020, 4:18 AM · Restricted Project

Oct 27 2020

rarutyun added inline comments to D87171: Implement P0919R3.
Oct 27 2020, 10:03 AM · Restricted Project

Oct 20 2020

rarutyun added a comment to D87171: Implement P0919R3.

@rarutyun Please look at the tests in D59886 and take anything that increases the coverage.

Oct 20 2020, 11:20 AM · Restricted Project

Oct 19 2020

rarutyun added inline comments to D87171: Implement P0919R3.
Oct 19 2020, 8:22 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 19 2020, 7:56 AM · Restricted Project

Oct 9 2020

rarutyun added a comment to D87171: Implement P0919R3.

Hi @zoecarver. I am also sorry about duplicating the work. I looked at the cxx2a_status.html and saw that it is not taken. I created the review with just having the update of cxx2a_status.html with marking that feature as In progress. Unfortunately, I didn't have information who should be invited to the review. I knew only Marshall and added him. Seems nobody was informed I took this part of work. As you can see the review was created on September the 5th. After that it was very hard to find the time to finish the feature implementation. Finally I found the bandwidth and implemented all of this stuff for a couple of days.

Oct 9 2020, 1:58 PM · Restricted Project
rarutyun added inline comments to D87171: Implement P0919R3.
Oct 9 2020, 6:20 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 9 2020, 5:35 AM · Restricted Project
rarutyun added a reviewer for D87171: Implement P0919R3: ldionne.
Oct 9 2020, 5:31 AM · Restricted Project
rarutyun updated the diff for D87171: Implement P0919R3.
Oct 9 2020, 5:16 AM · Restricted Project

Sep 4 2020

rarutyun requested review of D87171: Implement P0919R3.
Sep 4 2020, 3:45 PM · Restricted Project