This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Rename event to tag
ClosedPublic

Authored by aheejin on Jun 16 2021, 3:07 PM.

Details

Summary

We recently decided to change 'event' to 'tag', and 'event section' to
'tag section', out of the rationale that the section contains a
generalized tag that references a type, which may be used for something
other than exceptions, and the name 'event' can be confusing in the web
context.

See

Diff Detail

Event Timeline

aheejin created this revision.Jun 16 2021, 3:07 PM
aheejin requested review of this revision.Jun 16 2021, 3:07 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 16 2021, 3:07 PM
aheejin planned changes to this revision.Jun 16 2021, 3:08 PM

Oh, forgot to fix comments... will fix soon

aheejin updated this revision to Diff 352570.Jun 16 2021, 3:22 PM

Update comment

aheejin updated this revision to Diff 352571.Jun 16 2021, 3:36 PM

Typo fixes

aheejin updated this revision to Diff 352590.Jun 16 2021, 5:19 PM

clang-tidy fix

aheejin edited the summary of this revision. (Show Details)Jun 16 2021, 6:04 PM
aheejin edited the summary of this revision. (Show Details)
tlively accepted this revision.Jun 16 2021, 9:02 PM

LGTM! My only comments are about wording in some of the code comments.

lld/wasm/Symbols.h
419
421–425
422
423–425
427–430
429
lld/wasm/SyntheticSections.h
175
This revision is now accepted and ready to land.Jun 16 2021, 9:02 PM
aheejin edited the summary of this revision. (Show Details)Jun 16 2021, 9:25 PM
aheejin marked 7 inline comments as done.Jun 17 2021, 8:06 PM
aheejin updated this revision to Diff 352903.Jun 17 2021, 8:06 PM
aheejin edited the summary of this revision. (Show Details)

Address comments

This revision was landed with ongoing or failed builds.Jun 17 2021, 8:35 PM
This revision was automatically updated to reflect the committed changes.