This is an archive of the discontinued LLVM Phabricator instance.

Change PathMappingList::FindFile to return an optional result (NFC)
ClosedPublic

Authored by aprantl on Jun 16 2021, 11:32 AM.

Details

Summary

This is an NFC modernization refactoring that replaces the combination of a bool return + reference argument, with an Optional return value.

Diff Detail

Event Timeline

aprantl requested review of this revision.Jun 16 2021, 11:32 AM
aprantl created this revision.
aprantl updated this revision to Diff 353700.Jun 22 2021, 10:25 AM

Update to the correct patch

shafik accepted this revision.Jun 25 2021, 10:47 PM

LGTM

lldb/source/Core/SourceManager.cpp
444

This whole comment reads awkward and does not totally make sense and ends with . then

lldb/source/Target/PathMappingList.cpp
231

Make sense to move FileSpec new_spec; declaration down to here.

This revision is now accepted and ready to land.Jun 25 2021, 10:47 PM
JDevlieghere accepted this revision.Jun 28 2021, 10:34 AM

LGTM modulo formatting

This revision was landed with ongoing or failed builds.Jun 29 2021, 3:10 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2021, 3:10 PM