This is an archive of the discontinued LLVM Phabricator instance.

[ptr_provenance] Parser support for the optional ptr_provenance operand
AcceptedPublic

Authored by jeroen.dobbelaere on Jun 14 2021, 2:55 PM.

Details

Summary

This patch introduces parser support for the optional ptr_provenance operand for load/store instructions.

Note: this patch corresponds to D68489

Diff Detail

Event Timeline

jeroen.dobbelaere requested review of this revision.Jun 14 2021, 2:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2021, 2:55 PM
jeroen.dobbelaere edited the summary of this revision. (Show Details)Jun 14 2021, 3:04 PM
ormris removed a subscriber: ormris.Jun 15 2021, 1:40 PM
jeroen.dobbelaere added a reviewer: asbirlea.

Also test that parsing unknown_provenance works.

Updated after LLLexer change in D111160

Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2022, 7:00 AM

This looks fine, one comment to consider.

llvm/lib/AsmParser/LLParser.cpp
2351–2352

Are we sure AteExtraComma is initialized here? Often people pass an unitialized value into a reference.

asbirlea accepted this revision.Nov 29 2022, 10:22 AM
This revision is now accepted and ready to land.Nov 29 2022, 10:22 AM