Page MenuHomePhabricator

Fix misspelled instruction in X86 assembly parser
ClosedPublic

Authored by epastor on Jun 13 2021, 8:05 AM.

Details

Summary

Did not correctly handle "jecxz short <address>".

Discovered while working on LLVM-ML; shows up in z_Windows_NT-586_asm.asm from the OpenMP runtime

Diff Detail

Event Timeline

epastor created this revision.Jun 13 2021, 8:05 AM
epastor requested review of this revision.Jun 13 2021, 8:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
RKSimon added a subscriber: RKSimon.

test case?

More concretely, branch instruction tests in llvm/test/MC/X86/x86-32.s can be moved outside, then you can add a test for jecxz. jexcz seems untested.

epastor updated this revision to Diff 351745.Jun 13 2021, 3:19 PM

Add test case

More concretely, branch instruction tests in llvm/test/MC/X86/x86-32.s can be moved outside, then you can add a test for jecxz. jexcz seems untested.

Thanks for the concrete feedback! I couldn't figure out where the tests for this were. It looks like the "jcc short" family is all tested in intel-syntax.s, so I've added it there.

MaskRay accepted this revision.Jun 13 2021, 3:30 PM

Looks great!

This revision is now accepted and ready to land.Jun 13 2021, 3:30 PM
This revision was landed with ongoing or failed builds.Jun 13 2021, 3:34 PM
This revision was automatically updated to reflect the committed changes.