Page MenuHomePhabricator

epastor (Eric Astor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:23 PM (159 w, 4 d)

Recent Activity

Thu, Jun 30

epastor requested review of D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).
Thu, Jun 30, 2:13 PM · Restricted Project, Restricted Project

Jun 3 2022

epastor added a comment to D126931: [llvm-ml] Remove all file extension restrictions.

LGTM, but I'll defer to hans here since he's guided thus far.

Jun 3 2022, 1:42 PM · Restricted Project, Restricted Project

May 31 2022

epastor added a comment to D126425: [llvm-ml] Add support for the .S extension.

It appears to me that MASM doesn't care much about the file extension at all:

[test results omitted]

The fact that /Ta exists suggest maybe it did care at some point, but that may have changed.

May 31 2022, 7:08 AM · Restricted Project, Restricted Project

May 25 2022

epastor accepted D126425: [llvm-ml] Add support for the .S extension.
May 25 2022, 7:08 PM · Restricted Project, Restricted Project
epastor added inline comments to D126425: [llvm-ml] Add support for the .S extension.
May 25 2022, 6:35 PM · Restricted Project, Restricted Project

May 13 2022

epastor added inline comments to D125582: [llvm-ml] Add support for extern proc.
May 13 2022, 2:04 PM · Restricted Project, Restricted Project
epastor accepted D125582: [llvm-ml] Add support for extern proc.
May 13 2022, 2:03 PM · Restricted Project, Restricted Project
epastor added inline comments to D125582: [llvm-ml] Add support for extern proc.
May 13 2022, 1:41 PM · Restricted Project, Restricted Project

May 10 2022

epastor committed rG82c5e302f9e6: [llvm-ml] Implement support for MASM's extern directive (authored by ayzhao).
[llvm-ml] Implement support for MASM's extern directive
May 10 2022, 11:36 AM · Restricted Project, Restricted Project
epastor closed D125273: [llvm-ml] Imlement support for MASM's extern directive.
May 10 2022, 11:36 AM · Restricted Project, Restricted Project
epastor accepted D125273: [llvm-ml] Imlement support for MASM's extern directive.
May 10 2022, 7:08 AM · Restricted Project, Restricted Project

Apr 28 2022

epastor committed rG3333c28fc0dc: [llvm-ml] Improve indirect call parsing (authored by ayzhao).
[llvm-ml] Improve indirect call parsing
Apr 28 2022, 10:18 AM · Restricted Project, Restricted Project
epastor closed D124413: [llvm-ml] Improve indirect call parsing.
Apr 28 2022, 10:17 AM · Restricted Project, Restricted Project

Apr 27 2022

epastor accepted D124413: [llvm-ml] Improve indirect call parsing.

Looks good to me, but probably make sure Hans agrees first.

Apr 27 2022, 6:59 AM · Restricted Project, Restricted Project

Apr 25 2022

epastor added inline comments to D124413: [llvm-ml] Improve indirect call parsing.
Apr 25 2022, 1:39 PM · Restricted Project, Restricted Project

Apr 21 2022

epastor committed rG82ecf9a0b1b3: [LLVM-ML] Add standard LLVM debug flags (authored by epastor).
[LLVM-ML] Add standard LLVM debug flags
Apr 21 2022, 7:15 AM · Restricted Project, Restricted Project
epastor closed D123545: [LLVM-ML] Add standard LLVM debug flags.
Apr 21 2022, 7:15 AM · Restricted Project, Restricted Project

Apr 11 2022

epastor requested review of D123545: [LLVM-ML] Add standard LLVM debug flags.
Apr 11 2022, 1:51 PM · Restricted Project, Restricted Project

Apr 6 2022

epastor accepted D123173: [llvm-ml] Add support for the -o flag.

I'm fine with this and want to remove my request for changes - but please make sure Hans approves as well.

Apr 6 2022, 11:23 AM · Restricted Project, Restricted Project

Apr 5 2022

epastor requested changes to D123173: [llvm-ml] Add support for the -o flag.
Apr 5 2022, 6:21 PM · Restricted Project, Restricted Project

Apr 4 2022

epastor accepted D123068: Add the /nologo flag to llvm-ml.

Thanks!

Apr 4 2022, 1:08 PM · Restricted Project, Restricted Project

Sep 8 2021

epastor added a comment to D109425: [MC] Add Subtarget for MAsmParser call to emitCodeAlignment.

This code is similar to code in AsmParser.cpp (https://github.com/llvm-mirror/llvm/blob/master/lib/MC/MCParser/AsmParser.cpp#L3344-L3351) - looks like that will probably need an update as well, to keep MaxBytesToFill from being interpreted as a pointer?

Yes, I managed to catch that one in D45961 that reference from llvm-mirror might be a little bit out of date. I think https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCParser/AsmParser.cpp#L3457 is where the code is now. Hope I've not missed something.

Sep 8 2021, 7:30 AM · Restricted Project
epastor added a comment to D109425: [MC] Add Subtarget for MAsmParser call to emitCodeAlignment.

This code is similar to code in AsmParser.cpp (https://github.com/llvm-mirror/llvm/blob/master/lib/MC/MCParser/AsmParser.cpp#L3344-L3351) - looks like that will probably need an update as well, to keep MaxBytesToFill from being interpreted as a pointer?

Sep 8 2021, 6:03 AM · Restricted Project

Jul 22 2021

epastor committed rGa4e964a28219: [ms] [llvm-ml] Fix macro case-insensitivity (authored by epastor).
[ms] [llvm-ml] Fix macro case-insensitivity
Jul 22 2021, 12:51 PM
epastor closed D106453: [ms] [llvm-ml] Fix macro case-insensitivity.
Jul 22 2021, 12:51 PM · Restricted Project
epastor updated the diff for D106453: [ms] [llvm-ml] Fix macro case-insensitivity.

Fix copy/paste error in test label

Jul 22 2021, 12:30 PM · Restricted Project
epastor updated the diff for D106454: [ms] [llvm-ml] Match ML's handling of macro parameter expansion.

Rebase on parent

Jul 22 2021, 10:45 AM · Restricted Project
epastor updated the diff for D106453: [ms] [llvm-ml] Fix macro case-insensitivity.

Add all-lowercase test for a mixed-case macro

Jul 22 2021, 10:44 AM · Restricted Project

Jul 21 2021

epastor requested review of D106454: [ms] [llvm-ml] Match ML's handling of macro parameter expansion.
Jul 21 2021, 8:57 AM · Restricted Project
epastor requested review of D106453: [ms] [llvm-ml] Fix macro case-insensitivity.
Jul 21 2021, 8:53 AM · Restricted Project
epastor committed rG69551486fd35: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable… (authored by epastor).
[ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable…
Jul 21 2021, 8:50 AM
epastor closed D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.
Jul 21 2021, 8:50 AM · Restricted Project
epastor committed rG5fba6058965c: [ms] [llvm-ml] Support built-in text macros (authored by epastor).
[ms] [llvm-ml] Support built-in text macros
Jul 21 2021, 8:46 AM
epastor closed D104965: [ms] [llvm-ml] Support built-in text macros.
Jul 21 2021, 8:46 AM · Restricted Project
epastor committed rG4cbb912d7576: [ms] [llvm-ml] Add support for numeric built-in symbols (authored by epastor).
[ms] [llvm-ml] Add support for numeric built-in symbols
Jul 21 2021, 8:43 AM
epastor closed D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.
Jul 21 2021, 8:43 AM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Switch back to gmtime/localtime (not thread-safe, but in a generally-safe location - and more cross-platform)

Jul 21 2021, 7:14 AM · Restricted Project
epastor added inline comments to D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.
Jul 21 2021, 6:55 AM · Restricted Project

Jul 12 2021

epastor updated the diff for D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.

Rebase on parent

Jul 12 2021, 12:43 PM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Rebase on parent

Jul 12 2021, 12:42 PM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Addressed feedback (and rebased on HEAD)

Jul 12 2021, 12:42 PM · Restricted Project
epastor added inline comments to D104965: [ms] [llvm-ml] Support built-in text macros.
Jul 12 2021, 12:16 PM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Add -timestamp and -utc flags to support deterministic builds

Jul 12 2021, 12:14 PM · Restricted Project

Jul 4 2021

epastor retitled D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references from [ms] [llvm-ml] Restrict implicit RIP-relative addressing to symbol references to [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.
Jul 4 2021, 7:29 AM · Restricted Project
epastor updated the diff for D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.

Restrict further to only named-variable references

Jul 4 2021, 7:17 AM · Restricted Project

Jul 2 2021

epastor requested review of D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.
Jul 2 2021, 1:18 PM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Rebase on parent

Jul 2 2021, 11:50 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Fix symbol usage bug

Jul 2 2021, 11:50 AM · Restricted Project
epastor committed rG678211de6d5f: [ms] [llvm-ml] Standardize blocking of lexical substitution (authored by epastor).
[ms] [llvm-ml] Standardize blocking of lexical substitution
Jul 2 2021, 11:20 AM
epastor closed D104196: [ms] [llvm-ml] Standardize blocking of lexical substitution.
Jul 2 2021, 11:20 AM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Rebase on parent

Jul 2 2021, 11:15 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Fix accidental fold with the child commit

Jul 2 2021, 11:05 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Fix an accidental import of MasmParser.cpp from a child commit

Jul 2 2021, 11:02 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Rebase on parent

Jul 2 2021, 10:59 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Rebase on parent

Jul 2 2021, 10:54 AM · Restricted Project
epastor updated the diff for D104196: [ms] [llvm-ml] Standardize blocking of lexical substitution.

Address feedback (including clang-tidy)

Jul 2 2021, 9:47 AM · Restricted Project
epastor added a comment to D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Can you check if ml.exe allows defining a local variable overriding e.g. @Line? What happens then? Does it error? Can you add a test for that?

Jul 2 2021, 8:55 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Error on redefinition of built-in symbols (matching ML.EXE)

Jul 2 2021, 8:54 AM · Restricted Project

Jun 25 2021

epastor committed rGe074d580b28b: [ms] [llvm-ml] Disable C-style comments (authored by epastor).
[ms] [llvm-ml] Disable C-style comments
Jun 25 2021, 8:13 PM
epastor requested review of D104965: [ms] [llvm-ml] Support built-in text macros.
Jun 25 2021, 8:07 PM · Restricted Project
epastor requested review of D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.
Jun 25 2021, 7:46 PM · Restricted Project
epastor committed rGc8d0d8a8a16e: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives (authored by epastor).
[ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives
Jun 25 2021, 2:27 PM
epastor closed D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Jun 25 2021, 2:27 PM · Restricted Project

Jun 24 2021

epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Rebase on trunk to re-trigger build (after removing parent commit)

Jun 24 2021, 7:57 AM · Restricted Project
epastor added inline comments to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Jun 24 2021, 7:43 AM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Added comment explaining anonymous substructures

Jun 24 2021, 7:43 AM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Addressed comments (removed copy/paste cruft that proved unnecessary)

Jun 24 2021, 7:36 AM · Restricted Project

Jun 13 2021

epastor committed rGf09e200b31f4: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive (authored by epastor).
[ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive
Jun 13 2021, 3:37 PM
epastor committed rGd81c059c3ed2: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives (authored by epastor).
[ms] [llvm-ml] Fix capitalization of the ignored CPU directives
Jun 13 2021, 3:37 PM
epastor closed D104195: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive.
Jun 13 2021, 3:37 PM · Restricted Project
epastor closed D104206: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives.
Jun 13 2021, 3:37 PM · Restricted Project
epastor committed rG56edcbc2ad8c: Fix misspelled instruction in X86 assembly parser (authored by epastor).
Fix misspelled instruction in X86 assembly parser
Jun 13 2021, 3:35 PM
epastor closed D104194: Fix misspelled instruction in X86 assembly parser.
Jun 13 2021, 3:34 PM · Restricted Project
epastor requested review of D104206: [ms] [llvm-ml] Fix capitalization of the ignored CPU directives.
Jun 13 2021, 3:31 PM · Restricted Project
epastor added a comment to D104194: Fix misspelled instruction in X86 assembly parser.

More concretely, branch instruction tests in llvm/test/MC/X86/x86-32.s can be moved outside, then you can add a test for jecxz. jexcz seems untested.

Jun 13 2021, 3:20 PM · Restricted Project
epastor updated the diff for D104194: Fix misspelled instruction in X86 assembly parser.

Add test case

Jun 13 2021, 3:19 PM · Restricted Project
epastor requested review of D104196: [ms] [llvm-ml] Standardize blocking of lexical substitution.
Jun 13 2021, 8:19 AM · Restricted Project
epastor requested review of D104195: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive.
Jun 13 2021, 8:13 AM · Restricted Project
epastor requested review of D104194: Fix misspelled instruction in X86 assembly parser.
Jun 13 2021, 8:05 AM · Restricted Project

Jun 10 2021

epastor committed rGf03a3caac5e5: [ms] [llvm-ml] Warn on command-line redefinition (authored by epastor).
[ms] [llvm-ml] Warn on command-line redefinition
Jun 10 2021, 11:21 AM
epastor closed D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Jun 10 2021, 11:20 AM · Restricted Project
epastor updated the diff for D104008: [ms] [llvm-ml] Warn on command-line redefinition.

Dropping unnecessary implicit-check-not guard

Jun 10 2021, 10:27 AM · Restricted Project
epastor added inline comments to D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Jun 10 2021, 6:15 AM · Restricted Project
epastor updated the diff for D104008: [ms] [llvm-ml] Warn on command-line redefinition.

Directly check for the warning, rather than converting it to an error

Jun 10 2021, 6:14 AM · Restricted Project
epastor committed rG00ebbedd1c92: [ms] [llvm-ml] Make variable redefinition match ML.EXE (authored by epastor).
[ms] [llvm-ml] Make variable redefinition match ML.EXE
Jun 10 2021, 5:36 AM
epastor closed D103993: [ms] [llvm-ml] Make variable redefinition match ML.EXE.
Jun 10 2021, 5:36 AM · Restricted Project
epastor added inline comments to D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Jun 10 2021, 5:34 AM · Restricted Project
epastor added reviewers for D104008: [ms] [llvm-ml] Warn on command-line redefinition: thakis, rnk.
Jun 10 2021, 5:32 AM · Restricted Project

Jun 9 2021

epastor requested review of D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Jun 9 2021, 9:57 PM · Restricted Project
epastor abandoned D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

This required a few too many changes; I'll re-upload a working variant on top of a prerequisite (D103993).

Jun 9 2021, 9:33 PM · Restricted Project
epastor requested review of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Jun 9 2021, 9:20 PM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Fix handling of the second (and later) field after an ORG directive

Jun 9 2021, 9:19 PM · Restricted Project
epastor added a comment to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

While I was working on the comments above, I discovered a problem - after improving the tests and fixing various errors, the way we were dealing with determining field offsets caused a failure on the second field after an ORG offset change. I've been working on and off to adjust the code to handle this; it requires a nontrivial rework, as Structure has to track both its Size and the offset of the next field. I'll upload that revision shortly, and I'm afraid it will require a re-review. Sorry, thakis - and I'll try to find someone else if more appropriate.

Jun 9 2021, 9:16 PM · Restricted Project
epastor added a comment to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Does it wrap around 32-bit in 64-bit output too?

Oddly enough: yes.

Is this relied on? Or could we error out on negative values instead?

I don't think we can prove that it isn't relied on, especially when ORG explicitly allows putting things "outside bounds", so I'd rather maintain compatibility.

Well, we don't need to prove it if we make it an error: We'll know if the diag fires. So if we make this an error first and then build lots of files with it, we'll learn if we run into it. At that point we'll know we need to make it compatible, but maybe we won't have to. Doesn't it seem better to default to less surprising behavior and only put in the compat warts once there's evidence that we need them?

Jun 9 2021, 9:12 PM · Restricted Project
epastor added reviewers for D103993: [ms] [llvm-ml] Make variable redefinition match ML.EXE: thakis, rnk, mstorsjo.
Jun 9 2021, 3:53 PM · Restricted Project
epastor requested review of D103993: [ms] [llvm-ml] Make variable redefinition match ML.EXE.
Jun 9 2021, 3:52 PM · Restricted Project
epastor committed rG4b5317e937ac: [ms] [llvm-ml] Add support for INCLUDE environment variable (authored by epastor).
[ms] [llvm-ml] Add support for INCLUDE environment variable
Jun 9 2021, 2:55 PM
epastor closed D103989: [ms] [llvm-ml] Add support for INCLUDE environment variable.
Jun 9 2021, 2:54 PM · Restricted Project
epastor updated the diff for D103989: [ms] [llvm-ml] Add support for INCLUDE environment variable.

Fix lint

Jun 9 2021, 2:08 PM · Restricted Project
epastor requested review of D103989: [ms] [llvm-ml] Add support for INCLUDE environment variable.
Jun 9 2021, 1:05 PM · Restricted Project