Page MenuHomePhabricator
People epastor

epastor (Eric Astor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:23 PM (41 w, 6 d)

Recent Activity
View All

Today

epastor added reviewers for D77310: [ms] Add new /PDBSTREAM option to lld-link allowing injection of streams into PDB files.: • thakis, rnk.
Thu, Apr 2, 9:44 AM · Restricted Project
epastor created D77310: [ms] Add new /PDBSTREAM option to lld-link allowing injection of streams into PDB files..
Thu, Apr 2, 8:06 AM · Restricted Project

Yesterday

epastor added inline comments to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Wed, Apr 1, 2:38 PM · Restricted Project

Mar 1 2020

epastor updated the diff for D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.

Rebasing to HEAD

Mar 1 2020, 5:57 AM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Rebasing to HEAD

Mar 1 2020, 5:51 AM · Restricted Project
epastor updated the diff for D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.

Formatting fixup

Mar 1 2020, 5:39 AM · Restricted Project
epastor updated the diff for D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.

Address remaining C++17-only usage (non-void emplace_back), and fix clang-tidy errors.

Mar 1 2020, 5:33 AM · Restricted Project

Feb 28 2020

epastor updated the diff for D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.

Switch away from std::variant to allow compilation without C++17

Feb 28 2020, 3:30 PM · Restricted Project

Feb 27 2020

epastor added a parent revision for D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Feb 27 2020, 2:15 PM · Restricted Project
epastor added a child revision for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.: D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.
Feb 27 2020, 2:15 PM · Restricted Project
epastor created D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support.
Feb 27 2020, 2:15 PM · Restricted Project

Feb 26 2020

epastor committed rG85b641c27aec: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity. (authored by epastor).
[ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.
Feb 26 2020, 12:20 PM
epastor closed D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity..
Feb 26 2020, 12:20 PM · Restricted Project, Restricted Project
epastor added reviewers for D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.: rnk, • thakis.
Feb 26 2020, 11:04 AM · Restricted Project, Restricted Project
epastor added inline comments to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Feb 26 2020, 10:54 AM · Restricted Project
epastor removed a child revision for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Feb 26 2020, 10:54 AM · Restricted Project
epastor added a child revision for D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity.: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Feb 26 2020, 10:54 AM · Restricted Project, Restricted Project
epastor edited parent revisions for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM., added: 1; removed: 1.
Feb 26 2020, 10:54 AM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Responses to rnk's comments

Feb 26 2020, 10:54 AM · Restricted Project
epastor created D75198: [ms] Rename ParsingInlineAsm functions/variables to reflect MS-specificity..
Feb 26 2020, 10:54 AM · Restricted Project, Restricted Project

Feb 25 2020

epastor added a comment to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

MS-style inline assembly on x64 should also benefit now.

Feb 25 2020, 1:39 PM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Rebase

Feb 25 2020, 1:39 PM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Support default RIP-relative addressing on x64 MS-style assembly (including inline).

Feb 25 2020, 11:51 AM · Restricted Project
epastor added a comment to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
In D73227#1891917, @mstorsjo wrote:
In D73227#1891896, @epastor wrote:
In D73227#1891874, @thakis wrote:

What's the plan for 64-bit inline asm?

It should probably be the same, admittedly. To clarify: isParsingInlineAsm will only be true when parsing inline MS-style assembly? If so, I'll rename it to isParsingInlineMSAsm in this patch, and let the handling trigger off of both.

Are there any cases where MS style assembly can be injected inline on x86_64? As far as I know, MSVC didn't support any inline assembly at all on platforms other than i386.

If that's the case, I think the sane thing would be to keep handling inline asm like it always has been, as gcc style inline assembly. There could, concievably, be projects that contains gcc style inline assembly within #ifdef __clang__ (as this probably worked so far).

Feb 25 2020, 11:42 AM · Restricted Project
epastor added a comment to D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
In D73227#1891874, @thakis wrote:

Yuck.

Feb 25 2020, 11:24 AM · Restricted Project

Feb 24 2020

epastor committed rG95291a0e34c7: Reland "[ms] [llvm-ml] Improve data support, adding names and complex… (authored by epastor).
Reland "[ms] [llvm-ml] Improve data support, adding names and complex…
Feb 24 2020, 1:43 PM
epastor added a reverting change for rG9fe769a961dc: Revert "[ms] [llvm-ml] Improve data support, adding names and complex…: rG95291a0e34c7: Reland "[ms] [llvm-ml] Improve data support, adding names and complex….
Feb 24 2020, 1:43 PM
epastor added a comment to D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
In D73226#1890054, @stella.stamenova wrote:

It looks like this broke the Windows LLDB Buildbot:

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14117

Feb 24 2020, 1:34 PM · Restricted Project
epastor committed rG9fe769a961dc: Revert "[ms] [llvm-ml] Improve data support, adding names and complex… (authored by epastor).
Revert "[ms] [llvm-ml] Improve data support, adding names and complex…
Feb 24 2020, 1:16 PM
epastor added a reverting change for rGc2e272f8cf76: [ms] [llvm-ml] Improve data support, adding names and complex initializers.: rG9fe769a961dc: Revert "[ms] [llvm-ml] Improve data support, adding names and complex….
Feb 24 2020, 1:16 PM
epastor committed rGc2e272f8cf76: [ms] [llvm-ml] Improve data support, adding names and complex initializers. (authored by epastor).
[ms] [llvm-ml] Improve data support, adding names and complex initializers.
Feb 24 2020, 12:48 PM
epastor closed D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Feb 24 2020, 12:48 PM · Restricted Project
epastor added inline comments to D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Feb 24 2020, 10:02 AM · Restricted Project

Feb 21 2020

epastor added reviewers for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.: rnk, • thakis.
Feb 21 2020, 2:20 PM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Add basic regression test

Feb 21 2020, 2:11 PM · Restricted Project
epastor added inline comments to D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Feb 21 2020, 1:06 PM · Restricted Project
epastor added inline comments to D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Feb 21 2020, 12:40 PM · Restricted Project
epastor committed rGf0c642e82274: Remove unused functions in llvm-ml (authored by epastor).
Remove unused functions in llvm-ml
Feb 21 2020, 7:10 AM
epastor abandoned D74901: [ms] [llvm-ml] Remove unused functions.

Committed as f0c642e82274158f692d184de177be65eba814c1, without pre-submit review.

Feb 21 2020, 7:09 AM · Restricted Project

Feb 20 2020

epastor added reviewers for D74901: [ms] [llvm-ml] Remove unused functions: uabelho, lbenes.
Feb 20 2020, 6:59 AM · Restricted Project
epastor created D74901: [ms] [llvm-ml] Remove unused functions.
Feb 20 2020, 6:49 AM · Restricted Project

Feb 16 2020

epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Rebase on top of corrected predecessors

Feb 16 2020, 1:49 PM · Restricted Project
epastor updated the diff for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

Fix several clang-tidy and clang-format suggestions

Feb 16 2020, 1:49 PM · Restricted Project
epastor added reviewers for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.: rnk, • thakis.
Feb 16 2020, 1:39 PM · Restricted Project
epastor abandoned D74344: [ms] [llvm-ml] Add a draft MASM parser.

Accidental duplicate of D72680

Feb 16 2020, 1:39 PM · Restricted Project
epastor committed rGee2c0f76d74c: [ms] [llvm-ml] Add a draft MASM parser (authored by epastor).
[ms] [llvm-ml] Add a draft MASM parser
Feb 16 2020, 9:33 AM
epastor closed D72680: [ms] [llvm-ml] Add a draft MASM parser.
Feb 16 2020, 9:33 AM · Restricted Project
epastor updated the diff for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

Correct for casing & casting changes in previous rebase

Feb 16 2020, 9:33 AM · Restricted Project
epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Fix casing & casting errors due to rebase

Feb 16 2020, 8:48 AM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Rebase

Feb 16 2020, 8:03 AM · Restricted Project
epastor updated the diff for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

Rebase

Feb 16 2020, 8:02 AM · Restricted Project
epastor updated the diff for D74344: [ms] [llvm-ml] Add a draft MASM parser.

Final rebase (hopefully)

Feb 16 2020, 8:02 AM · Restricted Project
epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Rebase (hopefully final)

Feb 16 2020, 8:02 AM · Restricted Project

Feb 12 2020

epastor updated the diff for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

Add support for complex real-valued initializers

Feb 12 2020, 1:10 PM · Restricted Project

Feb 11 2020

epastor committed rG8d5bf0422bc3: [ms] [llvm-ml] Add support for attempted register parsing (authored by epastor).
[ms] [llvm-ml] Add support for attempted register parsing
Feb 11 2020, 7:51 AM
epastor closed D73486: [ms] [llvm-ml] Add support for attempted register parsing.
Feb 11 2020, 7:50 AM · Restricted Project

Feb 10 2020

epastor updated the diff for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..

Rebase

Feb 10 2020, 10:27 AM · Restricted Project
epastor updated the diff for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..

Rebase

Feb 10 2020, 10:27 AM · Restricted Project
epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Rebase

Feb 10 2020, 10:27 AM · Restricted Project
epastor created D74344: [ms] [llvm-ml] Add a draft MASM parser.
Feb 10 2020, 10:27 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Rebase

Feb 10 2020, 10:27 AM · Restricted Project
epastor added inline comments to D73486: [ms] [llvm-ml] Add support for attempted register parsing.
Feb 10 2020, 9:37 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Fix missed check in LanaiAsmParser (UnLex conditional on RestoreOnFailure)

Feb 10 2020, 9:37 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Fix UnLex ordering errors in tryParseRegister token restoration passes.

Feb 10 2020, 9:28 AM · Restricted Project

Feb 7 2020

epastor added inline comments to D73486: [ms] [llvm-ml] Add support for attempted register parsing.
Feb 7 2020, 3:01 PM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Fix formatting

Feb 7 2020, 2:16 PM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Finish merging logic between tryParseRegister and ParseRegister for remaining targets

Feb 7 2020, 12:26 PM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Merge logic to handle restoration after error more carefully, and with less duplication

Feb 7 2020, 11:48 AM · Restricted Project

Jan 27 2020

epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Actually fix MSP430 case (remove artifact of bad local changes)

Jan 27 2020, 11:55 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Fix MSP430 error.

Jan 27 2020, 11:25 AM · Restricted Project
epastor added a comment to D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Thanks for the feedback!

Jan 27 2020, 9:42 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Addressing comments.

Jan 27 2020, 9:32 AM · Restricted Project
epastor added a reviewer for D73486: [ms] [llvm-ml] Add support for attempted register parsing: • thakis.
Jan 27 2020, 8:14 AM · Restricted Project
epastor edited parent revisions for D72680: [ms] [llvm-ml] Add a draft MASM parser, added: 1; removed: 1.
Jan 27 2020, 8:14 AM · Restricted Project
epastor removed a child revision for D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc: D72680: [ms] [llvm-ml] Add a draft MASM parser.
Jan 27 2020, 8:14 AM · Restricted Project
epastor added a child revision for D73486: [ms] [llvm-ml] Add support for attempted register parsing: D72680: [ms] [llvm-ml] Add a draft MASM parser.
Jan 27 2020, 8:14 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Revert update from an incorrect commit

Jan 27 2020, 8:12 AM · Restricted Project
epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Split out tryParseRegister addition as a separate change, for easier review.

Jan 27 2020, 8:12 AM · Restricted Project
epastor updated the diff for D73486: [ms] [llvm-ml] Add support for attempted register parsing.

Split out tryParseRegister addition as a separate change, for easier review.

Jan 27 2020, 8:11 AM · Restricted Project
epastor created D73486: [ms] [llvm-ml] Add support for attempted register parsing.
Jan 27 2020, 8:11 AM · Restricted Project

Jan 24 2020

epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Resolving comments

Jan 24 2020, 2:45 PM · Restricted Project
epastor added a comment to D72680: [ms] [llvm-ml] Add a draft MASM parser.
In D72680#1839466, @thakis wrote:

Some parts of MasmParser looks like they're from the other class and not needed. Is the idea to copy most things over for now and then delete dead code later, to keep the git diff clearer?

Jan 24 2020, 2:39 PM · Restricted Project

Jan 22 2020

epastor added reviewers for D72680: [ms] [llvm-ml] Add a draft MASM parser: rnk, • thakis.
Jan 22 2020, 2:31 PM · Restricted Project
epastor created D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Jan 22 2020, 2:06 PM · Restricted Project
epastor added a parent revision for D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.: D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Jan 22 2020, 2:06 PM · Restricted Project
epastor added a child revision for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.: D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM..
Jan 22 2020, 2:06 PM · Restricted Project
epastor created D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Jan 22 2020, 2:04 PM · Restricted Project
epastor added a parent revision for D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers.: D72680: [ms] [llvm-ml] Add a draft MASM parser.
Jan 22 2020, 2:04 PM · Restricted Project
epastor added a child revision for D72680: [ms] [llvm-ml] Add a draft MASM parser: D73226: [ms] [llvm-ml] Improve data support, adding names and complex initializers..
Jan 22 2020, 2:04 PM · Restricted Project
epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Rebase, and add support for signed data types

Jan 22 2020, 1:57 PM · Restricted Project

Jan 21 2020

epastor added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.
In D72679#1832296, @kamaub wrote:

@epastor The lastest commit for this patch: r5f6dfa800e0b causes build failures on:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/23101
http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/43182
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/34405

Jan 21 2020, 2:05 PM · Restricted Project

Jan 20 2020

epastor updated the diff for D72680: [ms] [llvm-ml] Add a draft MASM parser.

Label all lit tests for llvm-ml as requiring X86 targets

Jan 20 2020, 1:59 PM · Restricted Project
epastor committed rG6ccebe004446: Fix build - removing legacy target reference. (authored by epastor).
Fix build - removing legacy target reference.
Jan 20 2020, 6:56 AM
epastor committed rG5f6dfa800e0b: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc (authored by epastor).
[ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc
Jan 20 2020, 6:26 AM
epastor closed D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.
Jan 20 2020, 6:26 AM · Restricted Project
epastor updated the diff for D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

Fix missing newline at end of file

Jan 20 2020, 6:17 AM · Restricted Project

Jan 19 2020

epastor added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.
In D72679#1828069, @RKSimon wrote:

Can you replicate the cmake settings in http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3114/steps/cmake-configure/logs/stdio ? The issue seems in part due to the available targets/triples:

llvm-ml.exe: error: : error: unable to get target for 'x86_64-pc-windows-msvc', see --version and --triple.
Jan 19 2020, 8:41 PM · Restricted Project
epastor updated the diff for D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

Rebasing past the reversion

Jan 19 2020, 8:36 PM · Restricted Project
epastor updated the diff for D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.

Tag non-trivial llvm-ml tests as requiring x86-registered-target, since llvm-ml's first draft only targets x86.

Jan 19 2020, 8:32 PM · Restricted Project

Jan 18 2020

epastor added a comment to D72679: [ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc.
In D72679#1828069, @RKSimon wrote:
In D72679#1828062, @epastor wrote:

Quick note: I've reverted this change in commit 0eeddf1ac59066567a096ad95344f43c38e6b04f due to the build breakages on all ARM platforms.

@RKSimon If you have any advice for relanding this safely, it'd be much appreciated!

Can you replicate the cmake settings in http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/3114/steps/cmake-configure/logs/stdio ? The issue seems in part due to the available targets/triples:

llvm-ml.exe: error: : error: unable to get target for 'x86_64-pc-windows-msvc', see --version and --triple.
Jan 18 2020, 10:35 AM · Restricted Project