Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

epastor (Eric Astor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:23 PM (224 w, 5 d)

Recent Activity

May 1 2023

epastor accepted D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only.

Looks about right to me, as an extension of D124413 - but I would appreciate it if ayzhao@ can weigh in here, since that was his patch.

May 1 2023, 6:13 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2023

epastor added a comment to D145208: [COFF] Add MC support for emitting IMAGE_WEAK_EXTERN_ANTI_DEPENDENCY symbols.

Looks good to me at a glance. Is this something we should support in MASM as well?

Mar 21 2023, 10:21 AM · Restricted Project, Restricted Project

Jan 22 2023

epastor accepted D142321: [llvm-ml] Disallow '{' and '}' at the start of a statement.
Jan 22 2023, 6:13 PM · Restricted Project, Restricted Project

Dec 29 2022

epastor committed rGa0b7bd4b0704: [MC] [llvm-ml] Add support for the extrn keyword (authored by glandium).
[MC] [llvm-ml] Add support for the extrn keyword
Dec 29 2022, 7:18 AM · Restricted Project, Restricted Project
epastor closed D140679: [MC] [llvm-ml] Add support for the extrn keyword.
Dec 29 2022, 7:18 AM · Restricted Project, Restricted Project
epastor added a comment to D140679: [MC] [llvm-ml] Add support for the extrn keyword.

@epastor could you land this for me?

Dec 29 2022, 7:03 AM · Restricted Project, Restricted Project

Dec 28 2022

epastor accepted D140679: [MC] [llvm-ml] Add support for the extrn keyword.

Thanks for catching this alias!

Dec 28 2022, 6:33 AM · Restricted Project, Restricted Project

Aug 11 2022

epastor committed rG94fae7a581d6: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs (authored by epastor).
[ms] [llvm-ml] Add support for nested PROC/ENDP pairs
Aug 11 2022, 7:19 AM · Restricted Project, Restricted Project
epastor closed D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs.
Aug 11 2022, 7:19 AM · Restricted Project, Restricted Project

Aug 10 2022

epastor updated the diff for D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs.

Fix a missing negation

Aug 10 2022, 1:02 PM · Restricted Project, Restricted Project
epastor added a comment to D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs.

Thanks!

I wonder if ml allows nested procs to refer to the parameters of the outer proc – then we'd have to handle activation records like gcc creates them for its nested functions.

But we don't even implement parameters for proc at all, so that's moot for now :)

Aug 10 2022, 12:59 PM · Restricted Project, Restricted Project
epastor updated the diff for D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs.

Add support for case-insensitive PROC/ENDP matching

Aug 10 2022, 12:33 PM · Restricted Project, Restricted Project
epastor updated the diff for D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs.

Add tests

Aug 10 2022, 12:29 PM · Restricted Project, Restricted Project
epastor committed rGbc9617899c6e: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE (authored by epastor).
[ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE
Aug 10 2022, 10:52 AM · Restricted Project, Restricted Project
epastor closed D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE.
Aug 10 2022, 10:52 AM · Restricted Project, Restricted Project
epastor committed rG4b566933cf7b: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters (authored by epastor).
[ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters
Aug 10 2022, 8:57 AM · Restricted Project, Restricted Project
epastor closed D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters.
Aug 10 2022, 8:57 AM · Restricted Project, Restricted Project
epastor updated the diff for D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE.

Fix remaining nit

Aug 10 2022, 8:52 AM · Restricted Project, Restricted Project
epastor updated the diff for D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE.

Address nits

Aug 10 2022, 8:41 AM · Restricted Project, Restricted Project
epastor updated the diff for D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE.

Fixing test

Aug 10 2022, 8:38 AM · Restricted Project, Restricted Project
epastor updated the diff for D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE.

Add simple test

Aug 10 2022, 8:33 AM · Restricted Project, Restricted Project
epastor added inline comments to D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters.
Aug 10 2022, 8:20 AM · Restricted Project, Restricted Project
epastor updated the diff for D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters.

Removing another accidental reformat

Aug 10 2022, 8:19 AM · Restricted Project, Restricted Project
epastor updated the diff for D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters.

Addressing feedback

Aug 10 2022, 8:17 AM · Restricted Project, Restricted Project

Aug 9 2022

epastor added reviewers for D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE: rnk, thakis, ayzhao.
Aug 9 2022, 2:20 PM · Restricted Project, Restricted Project
epastor added reviewers for D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters: rnk, thakis, ayzhao.
Aug 9 2022, 2:20 PM · Restricted Project, Restricted Project
epastor added reviewers for D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs: rnk, thakis, ayzhao.
Aug 9 2022, 2:19 PM · Restricted Project, Restricted Project
epastor requested review of D131524: [ms] [llvm-ml] Handle OPTION PROLOGUE/EPILOGUE:NONE.
Aug 9 2022, 2:18 PM · Restricted Project, Restricted Project
epastor requested review of D131523: [ms] [llvm-ml] Add support for the (many) optional SEGMENT parameters.
Aug 9 2022, 2:17 PM · Restricted Project, Restricted Project
epastor requested review of D131522: [ms] [llvm-ml] Add support for nested PROC/ENDP pairs.
Aug 9 2022, 2:14 PM · Restricted Project, Restricted Project

Jul 7 2022

epastor committed rG33f2a00023cb: [ms] [llvm-ml] Add support for the remaining binary named operators (authored by epastor).
[ms] [llvm-ml] Add support for the remaining binary named operators
Jul 7 2022, 6:46 PM · Restricted Project, Restricted Project
epastor closed D129299: [ms] [llvm-ml] Add support for the remaining binary named operators.
Jul 7 2022, 6:45 PM · Restricted Project, Restricted Project
epastor requested review of D129299: [ms] [llvm-ml] Add support for the remaining binary named operators.
Jul 7 2022, 9:00 AM · Restricted Project, Restricted Project
epastor committed rG7d1a295484e3: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`) (authored by epastor).
[ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`)
Jul 7 2022, 7:29 AM · Restricted Project, Restricted Project
epastor closed D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).
Jul 7 2022, 7:29 AM · Restricted Project, Restricted Project
epastor updated the diff for D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).

Fix collision with tombstone entry, and also remove one more bit of handling for GNU-as-style directional labels

Jul 7 2022, 6:12 AM · Restricted Project, Restricted Project

Jul 6 2022

epastor updated the diff for D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).

Small update to comments

Jul 6 2022, 9:31 AM · Restricted Project, Restricted Project
epastor updated the diff for D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).

Addressing last comment

Jul 6 2022, 9:29 AM · Restricted Project, Restricted Project
epastor updated the diff for D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).

Rebase to HEAD

Jul 6 2022, 8:09 AM · Restricted Project, Restricted Project
epastor added a comment to D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).

Should these be unnamed labels so they don't appear in the COFF file symbol table? I'm guessing ml64 doesn't produce symbols for these labels, but correct me if I'm wrong.

If that is the case, I suggest:

  • keep the counter
  • store a vector of MCSymbols indexed by label counter
  • use a getOrCreate operation to fill in that vector or read from it to handle support for forward references (@F)
Jul 6 2022, 8:04 AM · Restricted Project, Restricted Project
epastor updated the diff for D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).

Switch to the pre-existing anonymous label support. (Missed this in the first attempt!)

Jul 6 2022, 8:02 AM · Restricted Project, Restricted Project

Jun 30 2022

epastor requested review of D128944: [ms] [llvm-ml] Add support for anonymous labels (`@@`, `@B`, `@F`).
Jun 30 2022, 2:13 PM · Restricted Project, Restricted Project

Jun 3 2022

epastor added a comment to D126931: [llvm-ml] Remove all file extension restrictions.

LGTM, but I'll defer to hans here since he's guided thus far.

Jun 3 2022, 1:42 PM · Restricted Project, Restricted Project

May 31 2022

epastor added a comment to D126425: [llvm-ml] Add support for the .S extension.

It appears to me that MASM doesn't care much about the file extension at all:

[test results omitted]

The fact that /Ta exists suggest maybe it did care at some point, but that may have changed.

May 31 2022, 7:08 AM · Restricted Project, Restricted Project

May 25 2022

epastor accepted D126425: [llvm-ml] Add support for the .S extension.
May 25 2022, 7:08 PM · Restricted Project, Restricted Project
epastor added inline comments to D126425: [llvm-ml] Add support for the .S extension.
May 25 2022, 6:35 PM · Restricted Project, Restricted Project

May 13 2022

epastor added inline comments to D125582: [llvm-ml] Add support for extern proc.
May 13 2022, 2:04 PM · Restricted Project, Restricted Project
epastor accepted D125582: [llvm-ml] Add support for extern proc.
May 13 2022, 2:03 PM · Restricted Project, Restricted Project
epastor added inline comments to D125582: [llvm-ml] Add support for extern proc.
May 13 2022, 1:41 PM · Restricted Project, Restricted Project

May 10 2022

epastor committed rG82c5e302f9e6: [llvm-ml] Implement support for MASM's extern directive (authored by ayzhao).
[llvm-ml] Implement support for MASM's extern directive
May 10 2022, 11:36 AM · Restricted Project, Restricted Project
epastor closed D125273: [llvm-ml] Imlement support for MASM's extern directive.
May 10 2022, 11:36 AM · Restricted Project, Restricted Project
epastor accepted D125273: [llvm-ml] Imlement support for MASM's extern directive.
May 10 2022, 7:08 AM · Restricted Project, Restricted Project

Apr 28 2022

epastor committed rG3333c28fc0dc: [llvm-ml] Improve indirect call parsing (authored by ayzhao).
[llvm-ml] Improve indirect call parsing
Apr 28 2022, 10:18 AM · Restricted Project, Restricted Project
epastor closed D124413: [llvm-ml] Improve indirect call parsing.
Apr 28 2022, 10:17 AM · Restricted Project, Restricted Project

Apr 27 2022

epastor accepted D124413: [llvm-ml] Improve indirect call parsing.

Looks good to me, but probably make sure Hans agrees first.

Apr 27 2022, 6:59 AM · Restricted Project, Restricted Project

Apr 25 2022

epastor added inline comments to D124413: [llvm-ml] Improve indirect call parsing.
Apr 25 2022, 1:39 PM · Restricted Project, Restricted Project

Apr 21 2022

epastor committed rG82ecf9a0b1b3: [LLVM-ML] Add standard LLVM debug flags (authored by epastor).
[LLVM-ML] Add standard LLVM debug flags
Apr 21 2022, 7:15 AM · Restricted Project, Restricted Project
epastor closed D123545: [LLVM-ML] Add standard LLVM debug flags.
Apr 21 2022, 7:15 AM · Restricted Project, Restricted Project

Apr 11 2022

epastor requested review of D123545: [LLVM-ML] Add standard LLVM debug flags.
Apr 11 2022, 1:51 PM · Restricted Project, Restricted Project

Apr 6 2022

epastor accepted D123173: [llvm-ml] Add support for the -o flag.

I'm fine with this and want to remove my request for changes - but please make sure Hans approves as well.

Apr 6 2022, 11:23 AM · Restricted Project, Restricted Project

Apr 5 2022

epastor requested changes to D123173: [llvm-ml] Add support for the -o flag.
Apr 5 2022, 6:21 PM · Restricted Project, Restricted Project

Apr 4 2022

epastor accepted D123068: Add the /nologo flag to llvm-ml.

Thanks!

Apr 4 2022, 1:08 PM · Restricted Project, Restricted Project

Sep 8 2021

epastor added a comment to D109425: [MC] Add Subtarget for MAsmParser call to emitCodeAlignment.

This code is similar to code in AsmParser.cpp (https://github.com/llvm-mirror/llvm/blob/master/lib/MC/MCParser/AsmParser.cpp#L3344-L3351) - looks like that will probably need an update as well, to keep MaxBytesToFill from being interpreted as a pointer?

Yes, I managed to catch that one in D45961 that reference from llvm-mirror might be a little bit out of date. I think https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCParser/AsmParser.cpp#L3457 is where the code is now. Hope I've not missed something.

Sep 8 2021, 7:30 AM · Restricted Project
epastor added a comment to D109425: [MC] Add Subtarget for MAsmParser call to emitCodeAlignment.

This code is similar to code in AsmParser.cpp (https://github.com/llvm-mirror/llvm/blob/master/lib/MC/MCParser/AsmParser.cpp#L3344-L3351) - looks like that will probably need an update as well, to keep MaxBytesToFill from being interpreted as a pointer?

Sep 8 2021, 6:03 AM · Restricted Project

Jul 22 2021

epastor committed rGa4e964a28219: [ms] [llvm-ml] Fix macro case-insensitivity (authored by epastor).
[ms] [llvm-ml] Fix macro case-insensitivity
Jul 22 2021, 12:51 PM
epastor closed D106453: [ms] [llvm-ml] Fix macro case-insensitivity.
Jul 22 2021, 12:51 PM · Restricted Project
epastor updated the diff for D106453: [ms] [llvm-ml] Fix macro case-insensitivity.

Fix copy/paste error in test label

Jul 22 2021, 12:30 PM · Restricted Project
epastor updated the diff for D106454: [ms] [llvm-ml] Match ML's handling of macro parameter expansion.

Rebase on parent

Jul 22 2021, 10:45 AM · Restricted Project
epastor updated the diff for D106453: [ms] [llvm-ml] Fix macro case-insensitivity.

Add all-lowercase test for a mixed-case macro

Jul 22 2021, 10:44 AM · Restricted Project

Jul 21 2021

epastor requested review of D106454: [ms] [llvm-ml] Match ML's handling of macro parameter expansion.
Jul 21 2021, 8:57 AM · Restricted Project
epastor requested review of D106453: [ms] [llvm-ml] Fix macro case-insensitivity.
Jul 21 2021, 8:53 AM · Restricted Project
epastor committed rG69551486fd35: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable… (authored by epastor).
[ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable…
Jul 21 2021, 8:50 AM
epastor closed D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.
Jul 21 2021, 8:50 AM · Restricted Project
epastor committed rG5fba6058965c: [ms] [llvm-ml] Support built-in text macros (authored by epastor).
[ms] [llvm-ml] Support built-in text macros
Jul 21 2021, 8:46 AM
epastor closed D104965: [ms] [llvm-ml] Support built-in text macros.
Jul 21 2021, 8:46 AM · Restricted Project
epastor committed rG4cbb912d7576: [ms] [llvm-ml] Add support for numeric built-in symbols (authored by epastor).
[ms] [llvm-ml] Add support for numeric built-in symbols
Jul 21 2021, 8:43 AM
epastor closed D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.
Jul 21 2021, 8:43 AM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Switch back to gmtime/localtime (not thread-safe, but in a generally-safe location - and more cross-platform)

Jul 21 2021, 7:14 AM · Restricted Project
epastor added inline comments to D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.
Jul 21 2021, 6:55 AM · Restricted Project

Jul 12 2021

epastor updated the diff for D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.

Rebase on parent

Jul 12 2021, 12:43 PM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Rebase on parent

Jul 12 2021, 12:42 PM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Addressed feedback (and rebased on HEAD)

Jul 12 2021, 12:42 PM · Restricted Project
epastor added inline comments to D104965: [ms] [llvm-ml] Support built-in text macros.
Jul 12 2021, 12:16 PM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Add -timestamp and -utc flags to support deterministic builds

Jul 12 2021, 12:14 PM · Restricted Project

Jul 4 2021

epastor retitled D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references from [ms] [llvm-ml] Restrict implicit RIP-relative addressing to symbol references to [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.
Jul 4 2021, 7:29 AM · Restricted Project
epastor updated the diff for D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.

Restrict further to only named-variable references

Jul 4 2021, 7:17 AM · Restricted Project

Jul 2 2021

epastor requested review of D105372: [ms] [llvm-ml] Restrict implicit RIP-relative addressing to named-variable references.
Jul 2 2021, 1:18 PM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Rebase on parent

Jul 2 2021, 11:50 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Fix symbol usage bug

Jul 2 2021, 11:50 AM · Restricted Project
epastor committed rG678211de6d5f: [ms] [llvm-ml] Standardize blocking of lexical substitution (authored by epastor).
[ms] [llvm-ml] Standardize blocking of lexical substitution
Jul 2 2021, 11:20 AM
epastor closed D104196: [ms] [llvm-ml] Standardize blocking of lexical substitution.
Jul 2 2021, 11:20 AM · Restricted Project
epastor updated the diff for D104965: [ms] [llvm-ml] Support built-in text macros.

Rebase on parent

Jul 2 2021, 11:15 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Fix accidental fold with the child commit

Jul 2 2021, 11:05 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Fix an accidental import of MasmParser.cpp from a child commit

Jul 2 2021, 11:02 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Rebase on parent

Jul 2 2021, 10:59 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Rebase on parent

Jul 2 2021, 10:54 AM · Restricted Project
epastor updated the diff for D104196: [ms] [llvm-ml] Standardize blocking of lexical substitution.

Address feedback (including clang-tidy)

Jul 2 2021, 9:47 AM · Restricted Project
epastor added a comment to D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Can you check if ml.exe allows defining a local variable overriding e.g. @Line? What happens then? Does it error? Can you add a test for that?

Jul 2 2021, 8:55 AM · Restricted Project
epastor updated the diff for D104964: [ms] [llvm-ml] Add support for numeric built-in symbols.

Error on redefinition of built-in symbols (matching ML.EXE)

Jul 2 2021, 8:54 AM · Restricted Project

Jun 25 2021

epastor committed rGe074d580b28b: [ms] [llvm-ml] Disable C-style comments (authored by epastor).
[ms] [llvm-ml] Disable C-style comments
Jun 25 2021, 8:13 PM