Page MenuHomePhabricator

epastor (Eric Astor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 14 2019, 3:23 PM (83 w, 3 d)

Recent Activity

Dec 15 2020

epastor added a comment to D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".

CC'ing @epastor as a FYI for the assembly parser bug.

Dec 15 2020, 6:47 AM · Restricted Project

Dec 10 2020

epastor added a comment to D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Still no test, as far as I can tell. I think the suggestion below turns this into a 3-line diff (+ test).

Dec 10 2020, 7:38 AM · Restricted Project
epastor updated the diff for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Rebase on parent

Dec 10 2020, 7:37 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Fix errors in Alias/AliasArgs use, and add tests

Dec 10 2020, 7:37 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Use AliasArgs to simplify

Dec 10 2020, 7:17 AM · Restricted Project
epastor requested review of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Dec 10 2020, 7:07 AM · Restricted Project
epastor added a comment to D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.

Does it wrap around 32-bit in 64-bit output too?

Dec 10 2020, 7:07 AM · Restricted Project

Dec 2 2020

epastor added reviewers for D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives: thakis, rnk.
Dec 2 2020, 1:22 PM · Restricted Project
epastor requested review of D92507: [ms] [llvm-ml] Add support for ALIGN, EVEN, and ORG directives.
Dec 2 2020, 1:21 PM · Restricted Project
epastor added a comment to D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.

The test here doesn't currently warn - because test5 is already defined, and as such the line under t5: is lexed as:

def textequ <redef>
Dec 2 2020, 1:09 PM · Restricted Project
epastor requested review of D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition.
Dec 2 2020, 1:07 PM · Restricted Project
epastor added reviewers for D92504: [ms] [llvm-ml] When warnings are fatal, make sure to fail on warnings: thakis, rnk.
Dec 2 2020, 1:05 PM · Restricted Project
epastor requested review of D92504: [ms] [llvm-ml] When warnings are fatal, make sure to fail on warnings.
Dec 2 2020, 1:04 PM · Restricted Project
epastor requested review of D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros.
Dec 2 2020, 1:03 PM · Restricted Project

Dec 1 2020

epastor added a reviewer for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null: rnk.
Dec 1 2020, 3:06 PM · Restricted Project
epastor committed rGc64037b784ae: [ms] [llvm-ml] Support command-line defines (authored by epastor).
[ms] [llvm-ml] Support command-line defines
Dec 1 2020, 3:06 PM
epastor closed D90059: [ms] [llvm-ml] Support command-line defines.
Dec 1 2020, 3:06 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Dec 1 2020, 2:48 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on HEAD

Dec 1 2020, 2:48 PM · Restricted Project
epastor committed rG8fee2ee9a689: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe (authored by epastor).
[ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe
Dec 1 2020, 2:44 PM
epastor closed D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.
Dec 1 2020, 2:43 PM · Restricted Project
epastor added a comment to D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

(Just to be sure: This is ready to go and not waiting on me, right?)

Dec 1 2020, 12:26 PM · Restricted Project

Nov 30 2020

epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Update for new test files

Nov 30 2020, 1:35 PM · Restricted Project
epastor committed rGe5c17b2deea5: [ms] [llvm-ml] Test macro function invocations in arbitrary positions (authored by epastor).
[ms] [llvm-ml] Test macro function invocations in arbitrary positions
Nov 30 2020, 12:14 PM
epastor closed D89741: [ms] [llvm-ml] Test macro function invocations in arbitrary positions.
Nov 30 2020, 12:14 PM · Restricted Project
epastor retitled D89741: [ms] [llvm-ml] Test macro function invocations in arbitrary positions from [ms] [llvm-ml] Allow macro function invocations in arbitrary positions to [ms] [llvm-ml] Test macro function invocations in arbitrary positions.
Nov 30 2020, 12:13 PM · Restricted Project
epastor updated the diff for D89741: [ms] [llvm-ml] Test macro function invocations in arbitrary positions.

Rename to reflect diminished status

Nov 30 2020, 12:13 PM · Restricted Project
epastor updated the diff for D89741: [ms] [llvm-ml] Test macro function invocations in arbitrary positions.

Rebase on HEAD

Nov 30 2020, 12:12 PM · Restricted Project
epastor committed rGabef659a45ff: [ms] [llvm-ml] Implement the statement expansion operator (authored by epastor).
[ms] [llvm-ml] Implement the statement expansion operator
Nov 30 2020, 11:33 AM
epastor closed D89740: [ms] [llvm-ml] Implement the statement expansion operator.
Nov 30 2020, 11:33 AM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Fix typo in test

Nov 30 2020, 10:32 AM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase to HEAD

Nov 30 2020, 8:38 AM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Remove unrelated test update.

Nov 30 2020, 8:38 AM · Restricted Project

Nov 25 2020

epastor committed rG35828b84a523: [ms] [llvm-ml] Implement the expression expansion operator (authored by epastor).
[ms] [llvm-ml] Implement the expression expansion operator
Nov 25 2020, 1:11 PM
epastor closed D89736: [ms] [llvm-ml] Implement the expression expansion operator.
Nov 25 2020, 1:11 PM · Restricted Project
epastor added a comment to D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Looks like there's no coverage for expanding statements that aren't the echo special case - - could you add coverage for that too? Other than that, lg!

Nov 25 2020, 12:36 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Nov 25 2020, 12:35 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Nov 25 2020, 12:35 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on parent

Nov 25 2020, 12:35 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on parent

Nov 25 2020, 12:35 PM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase on parent

Nov 25 2020, 12:34 PM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Add a test case covering the lack of impact on typical statements

Nov 25 2020, 12:29 PM · Restricted Project

Nov 23 2020

epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Nov 23 2020, 1:32 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Nov 23 2020, 1:32 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Disable IgnoreCase; ml.exe and ml64.exe use case-sensitive flags

Nov 23 2020, 1:32 PM · Restricted Project
epastor added inline comments to D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.
Nov 23 2020, 12:22 PM · Restricted Project
epastor added inline comments to D90059: [ms] [llvm-ml] Support command-line defines.
Nov 23 2020, 12:20 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Nov 23 2020, 12:19 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Nov 23 2020, 12:19 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Accept /c as a flag without warning; it's our current default behavior anyway

Nov 23 2020, 12:14 PM · Restricted Project
epastor abandoned D90060: [ms] [llvm-ml] Add more documentation to unsupported options.
Nov 23 2020, 12:10 PM · Restricted Project
epastor added a comment to D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

I'd argue that we shouldn't have help texts for flags we don't support.

Nov 23 2020, 12:10 PM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Nov 23 2020, 12:10 PM · Restricted Project
epastor updated the diff for D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

Rebase on parent

Nov 23 2020, 12:09 PM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Nov 23 2020, 12:09 PM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on parent

Nov 23 2020, 12:09 PM · Restricted Project
epastor updated the diff for D89741: [ms] [llvm-ml] Test macro function invocations in arbitrary positions.

Rebase on parent

Nov 23 2020, 12:09 PM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase on parent

Nov 23 2020, 12:09 PM · Restricted Project
epastor added inline comments to D89736: [ms] [llvm-ml] Implement the expression expansion operator.
Nov 23 2020, 12:08 PM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Remove "return/else" branches to match LLVM style

Nov 23 2020, 12:07 PM · Restricted Project
epastor committed rG1e41e22323a3: [ms] [llvm-ml] Support purging macro definitions (authored by epastor).
[ms] [llvm-ml] Support purging macro definitions
Nov 23 2020, 12:03 PM
epastor closed D89735: [ms] [llvm-ml] Support purging macro definitions.
Nov 23 2020, 12:03 PM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Rebase on parent (pushed a change further up the stack)

Nov 23 2020, 11:20 AM · Restricted Project
epastor updated the diff for D89735: [ms] [llvm-ml] Support purging macro definitions.

Rebase to HEAD

Nov 23 2020, 11:19 AM · Restricted Project
epastor committed rG454f32e4d572: [ms] [llvm-ml] Support macro function invocations in expressions (authored by epastor).
[ms] [llvm-ml] Support macro function invocations in expressions
Nov 23 2020, 11:17 AM
epastor closed D89734: [ms] [llvm-ml] Support macro function invocations in expressions.
Nov 23 2020, 11:17 AM · Restricted Project

Nov 17 2020

epastor added a comment to D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.

LGTM for llvm-ml.

Nov 17 2020, 7:43 AM · Restricted Project, Restricted Project, Restricted Project

Nov 13 2020

epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Fix an off-by-one error in the recently-added assert.

Nov 13 2020, 2:08 PM · Restricted Project
epastor added a comment to D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Can we also add a test where EndStatementAtEOFStack isn't empty at end-of-file?

Nov 13 2020, 11:07 AM · Restricted Project
epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Add assert() that EndStatementAtEOFStack ends up empty.

Nov 13 2020, 11:06 AM · Restricted Project

Nov 9 2020

epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Add ifdef testing, and fix a minor StringRef vs. std::string issue.

Nov 9 2020, 1:32 PM · Restricted Project
epastor committed rGd657f7cd30ed: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.) (authored by epastor).
[ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.)
Nov 9 2020, 11:02 AM
epastor closed D89733: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.).
Nov 9 2020, 11:01 AM · Restricted Project
epastor committed rG3a71f5519423: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives (authored by epastor).
[ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives
Nov 9 2020, 10:21 AM
epastor closed D89732: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives.
Nov 9 2020, 10:21 AM · Restricted Project

Nov 6 2020

epastor committed rG5afb36080809: [ms] [llvm-ml] Allow arbitrary strings as integer constants (authored by epastor).
[ms] [llvm-ml] Allow arbitrary strings as integer constants
Nov 6 2020, 2:16 PM
epastor closed D90788: [ms] [llvm-ml] Allow arbitrary strings as integer constants.
Nov 6 2020, 2:16 PM · Restricted Project

Nov 5 2020

epastor added a comment to D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Nice!

Do tests still run after the test file renaming to .asm? llvm/test/lit.cfg.py has config.suffixes = ['.ll', '.c', '.test', '.txt', '.s', '.mir', '.yaml'] which includes .test but not .asm. I would expect that you need to edit llvm/test/tools/llvm-ml/lit.local.cfg to have config.suffixes.add('.asm,') for the tests to keep running.

Nov 5 2020, 11:25 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Fix lit.local.cfg (add vs. append)

Nov 5 2020, 11:22 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on parent

Nov 5 2020, 10:44 AM · Restricted Project
epastor updated the diff for D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

Rebase on parent

Nov 5 2020, 10:44 AM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on parent

Nov 5 2020, 10:44 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

After rebasing on parent, fix new test files for invocation style

Nov 5 2020, 10:43 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D90061: [ms] [llvm-ml] Allow the /Zs parameter as a synonym for -filetype=null.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D90060: [ms] [llvm-ml] Add more documentation to unsupported options.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D90059: [ms] [llvm-ml] Support command-line defines.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D89741: [ms] [llvm-ml] Test macro function invocations in arbitrary positions.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D89740: [ms] [llvm-ml] Implement the statement expansion operator.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D89736: [ms] [llvm-ml] Implement the expression expansion operator.

Rebase on HEAD

Nov 5 2020, 10:33 AM · Restricted Project
epastor updated the diff for D89735: [ms] [llvm-ml] Support purging macro definitions.

Rebase on HEAD

Nov 5 2020, 10:32 AM · Restricted Project
epastor updated the diff for D89734: [ms] [llvm-ml] Support macro function invocations in expressions.

Rebase on HEAD

Nov 5 2020, 10:32 AM · Restricted Project
epastor updated the diff for D89733: [ms] [llvm-ml] Support MASM's relational operators (EQ, LT, etc.).

Rebase on HEAD

Nov 5 2020, 10:32 AM · Restricted Project
epastor updated the diff for D89732: [ms] [llvm-ml] Support REPEAT/FOR/WHILE macro-like directives.

Rebase to HEAD

Nov 5 2020, 10:32 AM · Restricted Project
epastor updated the diff for D90058: [ms] [llvm-ml] Introduce command-line compatibility for ml.exe and ml64.exe.

Fix prefixes for LLVM-specific options, and add the .asm tests to the lit config

Nov 5 2020, 10:28 AM · Restricted Project

Nov 4 2020

epastor requested review of D90788: [ms] [llvm-ml] Allow arbitrary strings as integer constants.
Nov 4 2020, 12:56 PM · Restricted Project
epastor committed rGe6cd3eff17fd: Fix -Wsign-compare issue in MasmParser.cpp (authored by epastor).
Fix -Wsign-compare issue in MasmParser.cpp
Nov 4 2020, 12:44 PM
epastor committed rG07c4f1d10b30: [ms] [llvm-ml] Lex MASM strings, including escaping (authored by epastor).
[ms] [llvm-ml] Lex MASM strings, including escaping
Nov 4 2020, 12:30 PM
epastor closed D89731: [ms] [llvm-ml] Lex MASM strings, including escaping.
Nov 4 2020, 12:29 PM · Restricted Project