Page MenuHomePhabricator

Revert "Revert "[libcxx][module-map] creates submodules for private headers""
ClosedPublic

Authored by cjdb on Jun 11 2021, 7:25 PM.

Details

Summary

This reverts commit d9633f229c36f292dab0e5f510ac635cfaf3a798 as a
workaround was discovered.

Diff Detail

Event Timeline

cjdb requested review of this revision.Jun 11 2021, 7:25 PM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2021, 7:25 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
cjdb updated this revision to Diff 351626.Jun 11 2021, 8:18 PM

adds missing inclusion (not reproing locally for some reason)

cjdb updated this revision to Diff 351631.Jun 11 2021, 10:06 PM

another failure not caught locally

cjdb updated this revision to Diff 351635.Jun 11 2021, 10:36 PM

another failure not caught locally (not sure what's going on there)

cjdb updated this revision to Diff 351637.Jun 11 2021, 11:19 PM

Finally managed to repro test failures locally. Still not confident this will pass: building with modules seemed to segfault, but it was also segfaulting when compiling vanilla ToT.

cjdb updated this revision to Diff 351638.Jun 11 2021, 11:21 PM

Uncomments code that was commented out for debugging (tonight's not my night).

cjdb updated this revision to Diff 351681.Jun 12 2021, 12:30 PM

rebases to activate CI

cjdb updated this revision to Diff 352184.Jun 15 2021, 10:40 AM

rebases to activate CI (runtimes build expected to fail since the addressof operator hasn't been moved around yet)

cjdb updated this revision to Diff 352225.Jun 15 2021, 1:02 PM

moves addressof operator deletion

cjdb updated this revision to Diff 352228.Jun 15 2021, 1:14 PM

adds addressof operators back, turns on XFAILs

ldionne added inline comments.Jun 15 2021, 3:01 PM
libcxx/test/std/iterators/iterator.primitives/range.iter.ops/range.iter.ops.next/special_function.compile.pass.cpp
12

Those should be

// XFAIL: clang-11 && modules-build
// XFAIL: clang-12 && modules-build
cjdb updated this revision to Diff 352266.Jun 15 2021, 3:11 PM

corrects XFAILs

cjdb updated this revision to Diff 352332.Jun 15 2021, 9:40 PM

fixes test case that was failing

cjdb updated this revision to Diff 352339.Jun 15 2021, 10:36 PM

fixes build failure

ldionne accepted this revision.Jun 16 2021, 9:31 AM
This revision is now accepted and ready to land.Jun 16 2021, 9:31 AM