Page MenuHomePhabricator

[libcxx][NFC] prepares `<type_traits>` for moving out forward and swap
ClosedPublic

Authored by cjdb on Jun 22 2021, 12:44 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary
  • <type_traits> depends on std::forward, so we replaced it with static_cast<T&&>.
  • swap's return type is confusing, so it's been rearranged to improve readabilitiy.

Diff Detail

Event Timeline

cjdb requested review of this revision.Jun 22 2021, 12:44 PM
cjdb created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2021, 12:44 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jun 22 2021, 1:32 PM
This revision is now accepted and ready to land.Jun 22 2021, 1:32 PM
cjdb closed this revision.Jun 24 2021, 11:01 AM

Merged in https://github.com/llvm/llvm-project/commit/cafae0561920883f3269aa9a89aa4035b6a226e1. Apparently the commit message didn't have the associated differential revision, and so this needs to be manually closed.