This is an archive of the discontinued LLVM Phabricator instance.

[amdgpu] Add `-enable-ocl-mangling-mismatch-workaround`.
ClosedPublic

Authored by hliao on Jun 8 2021, 11:42 AM.

Details

Summary
  • Add -enable-ocl-mangling-mismatch-workaround to work around the mismatch on OCL name mangling so far.

Diff Detail

Unit TestsFailed

Event Timeline

hliao created this revision.Jun 8 2021, 11:42 AM
hliao requested review of this revision.Jun 8 2021, 11:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2021, 11:42 AM
hliao added a comment.EditedJun 8 2021, 11:43 AM

This's the short-term solution until all issues exposed after the frontend change are fixed. This change will be reverted once the frontend change is landed.

This comment was removed by rampitec.
This comment was removed by rampitec.
rampitec accepted this revision.Jun 8 2021, 12:07 PM

LGTM as a short term w/a.

This revision is now accepted and ready to land.Jun 8 2021, 12:07 PM
rampitec requested changes to this revision.Jun 8 2021, 12:08 PM

Oops, too soon. Please add "amdgpu" to the switch.

This revision now requires changes to proceed.Jun 8 2021, 12:08 PM
yaxunl accepted this revision.Jun 8 2021, 12:24 PM

LGTM. Thanks!

hliao updated this revision to Diff 350691.Jun 8 2021, 12:38 PM

Add 'amdgpu-' prefix in that option.

rampitec accepted this revision.Jun 8 2021, 12:39 PM

Thanks!

This revision is now accepted and ready to land.Jun 8 2021, 12:39 PM
This revision was landed with ongoing or failed builds.Jun 8 2021, 12:42 PM
This revision was automatically updated to reflect the committed changes.