Page MenuHomePhabricator

[analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler
ClosedPublic

Authored by vsavchenko on Thu, Jun 3, 1:27 PM.

Details

Summary

After this patch, custom StoreHandlers will also work as expected.

Diff Detail

Event Timeline

vsavchenko created this revision.Thu, Jun 3, 1:27 PM
vsavchenko requested review of this revision.Thu, Jun 3, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jun 3, 1:27 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
NoQ added inline comments.Thu, Jun 10, 11:48 PM
clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
2047

WDYM?

Also maybe downscope it?

2063

Isn't DS always null here?

vsavchenko added inline comments.Fri, Jun 11, 1:35 AM
clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
2047

I meant that the only client for it is undef value printer and we can probably get rid of it altogether, or at least what I did in the very last patch from the stack.

2063

Duh! Yes!
Good catch, I'll remove DS declaration!

vsavchenko marked 2 inline comments as done.

Fix review remarks

NoQ accepted this revision.Mon, Jun 14, 8:49 PM

Great, thanks!

This revision is now accepted and ready to land.Mon, Jun 14, 8:49 PM