Page MenuHomePhabricator

[lldb] Preserve type sugar when using SBValue::Dereference on C++ references
ClosedPublic

Authored by teemperor on Wed, Jun 2, 9:10 AM.

Details

Summary

When checking for type properties we usually want to strip all kind of type sugar from
the type. For example, sugar like Clang's ElaboratedType or typedefs rarely influence
the fundamental behaviour of a type such as its byte size.

However we always need to preserve type sugar for everything else as it does matter
for users that their variable of type size_t instead of unsigned long for example.

This patch fixes one such bug when trying to use the SBValue API to dereference a
a type.

Diff Detail

Event Timeline

teemperor created this revision.Wed, Jun 2, 9:10 AM
teemperor requested review of this revision.Wed, Jun 2, 9:10 AM
werat accepted this revision.Wed, Jun 2, 9:38 AM

Thanks for fixing this!

This revision is now accepted and ready to land.Wed, Jun 2, 9:38 AM
shafik accepted this revision.Wed, Jun 2, 9:57 AM
shafik added a subscriber: shafik.

Nice fix!

This revision was landed with ongoing or failed builds.Wed, Jun 2, 10:23 AM
This revision was automatically updated to reflect the committed changes.