This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][test] Add new tests of bitwise and with constant for the Zbs extension
ClosedPublic

Authored by benshi001 on May 29 2021, 3:15 AM.

Details

Summary

These tests will show how (and r i) will be optimized to
(BCLRI (BCLRI r, i0), i1) or (BCLRI (ANDI r, i0), i1) by future
commits.

Diff Detail

Unit TestsFailed

Event Timeline

benshi001 created this revision.May 29 2021, 3:15 AM
benshi001 requested review of this revision.May 29 2021, 3:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2021, 3:15 AM
benshi001 added a comment.EditedMay 29 2021, 3:16 AM

These tests will show how (and r i) are optimized to

(bclri (bclri r, i0), i1) or (bclri (andi r, i0), i1).

These tests will show how (and r i) are optimized to

(bclri (bclri r, i0), i1) or (bclri (andi r, i0), i1).

Put this in the patch description

Maybe I'm just failing to parse it properly, but the title of this revision doesn't make any sense?

benshi001 updated this revision to Diff 348668.May 29 2021, 6:19 PM
benshi001 updated this revision to Diff 348669.
benshi001 retitled this revision from [RISCV][test] Add new tests of and in the zbs extension to [RISCV][test] Add new tests of bitwise and in the zbs extension.
benshi001 edited the summary of this revision. (Show Details)

These tests will show how (and r i) are optimized to

(bclri (bclri r, i0), i1) or (bclri (andi r, i0), i1).

Put this in the patch description

Thanks. It is done.

craig.topper retitled this revision from [RISCV][test] Add new tests of bitwise and in the zbs extension to [RISCV][test] Add new tests of bitwise and with constant for the Zbs extension.Jun 1 2021, 10:15 AM

I modified the title a little to mention anding with a constant. @jrtc27, does that look good to you?

I modified the title a little to mention anding with a constant. @jrtc27, does that look good to you?

Yes, that looks better thanks

craig.topper accepted this revision.Jun 1 2021, 10:18 AM

LGTM, please use the updated title when committing.

This revision is now accepted and ready to land.Jun 1 2021, 10:18 AM

LGTM, please use the updated title when committing.

Thanks. I have committed with your new title.