This is an archive of the discontinued LLVM Phabricator instance.

[MIRParser] Add machine metadata.
ClosedPublic

Authored by hliao on May 27 2021, 1:03 PM.

Details

Summary
  • Add standalone metadata parsing support so that machine metadata nodes could be populated before and accessed during MIR is parsed.

Diff Detail

Event Timeline

hliao created this revision.May 27 2021, 1:03 PM
hliao requested review of this revision.May 27 2021, 1:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2021, 1:03 PM
arsenm added inline comments.Jun 18 2021, 3:45 PM
llvm/lib/CodeGen/MIRParser/MIParser.cpp
1248

Needs tests for the various parse errors

llvm/test/CodeGen/AArch64/memcpy-scoped-aa.mir
4 ↗(On Diff #348383)

Parser/printer tests should go in test/CodeGen/MIR/*

llvm/test/CodeGen/AMDGPU/memcpy-scoped-aa.mir
221 ↗(On Diff #348383)

Can you drop the register section and some of the other noise?

hliao updated this revision to Diff 353481.Jun 21 2021, 2:04 PM
  • Relocate tests and add extra tests for parsing errors.
  • Enhance the parser to report any missing definitions on forward referenced metadata.
hliao marked 3 inline comments as done.Jun 21 2021, 2:05 PM
hliao updated this revision to Diff 353685.Jun 22 2021, 9:43 AM

Rebase again.

hliao updated this revision to Diff 354035.Jun 23 2021, 11:25 AM

Rebase and kindly PING for review.

hliao updated this revision to Diff 354273.Jun 24 2021, 8:57 AM

Kindly PING after rebasing.

hliao updated this revision to Diff 355047.Jun 28 2021, 2:46 PM

Kindly PING again.

arsenm accepted this revision.Jun 28 2021, 5:12 PM
This revision is now accepted and ready to land.Jun 28 2021, 5:12 PM
This revision was automatically updated to reflect the committed changes.