This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy][NFC] Refactor CopyConfig structure - remove lazy options processing.
ClosedPublic

Authored by avl on May 27 2021, 8:46 AM.

Details

Summary

During reviewing D102277 it was decided to remove lazy options processing
from llvm-objcopy CopyConfig structure. This patch transforms processing of ELF
lazy options into the in-place processing.

Diff Detail

Unit TestsFailed

Event Timeline

avl created this revision.May 27 2021, 8:46 AM
avl requested review of this revision.May 27 2021, 8:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2021, 8:46 AM
avl updated this revision to Diff 348378.May 27 2021, 1:48 PM

added minor refactoring.

avl updated this revision to Diff 348448.May 27 2021, 11:45 PM

changed String flag values to the enum.

jhenderson accepted this revision.May 28 2021, 12:36 AM

LGTM overall. Just a few nits.

FYI, I'm off work all of next week, so it'll be the week after before I can comment on any more patches.

llvm/tools/llvm-objcopy/CommonConfig.h
155

It's not explicitly stated, but reading between the lines, and looking at the example in the coding standards, I think this should be IndirectFunction (and UniqueObject below).

165
llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
503–504

I think this keeps the comment a little more generic, so that if the signature changes, the comment remains valid.

This revision is now accepted and ready to land.May 28 2021, 12:36 AM
avl added a comment.May 28 2021, 5:11 AM

LGTM overall. Just a few nits.

FYI, I'm off work all of next week, so it'll be the week after before I can comment on any more patches.

I see, thanks. And thank you for reviewing.

avl updated this revision to Diff 348505.May 28 2021, 6:00 AM

addressed comments. rebased to have a buildbot report.