This is an archive of the discontinued LLVM Phabricator instance.

Differential D103218

[Fuchsia][CMake] Add missing include path.
ClosedPublic

Authored by haowei on May 26 2021, 5:49 PM.

Details

Reviewers
phosek
mcgrathr
leonardchan
gulfem
Commits
rG0ce58c52d50b: [Fuchsia][CMake] Add missing include path.
Summary

This patch adds include path for missing header files from "sync". This patch also fixes the build failures caused by scudo introduced in D103200.

Diff Detail

Event Timeline

haowei created this revision.May 26 2021, 5:49 PM
Herald added subscribers: cryptoad, mgorny. · View Herald TranscriptMay 26 2021, 5:49 PM
haowei requested review of this revision.May 26 2021, 5:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 5:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B106415: Diff 348135.May 26 2021, 6:03 PM
leonardchan accepted this revision.May 26 2021, 7:48 PM
This revision is now accepted and ready to land.May 26 2021, 7:48 PM
This revision was landed with ongoing or failed builds.May 26 2021, 8:00 PM
Closed by commit rG0ce58c52d50b: [Fuchsia][CMake] Add missing include path. (authored by haowei). · Explain Why
This revision was automatically updated to reflect the committed changes.
haowei added a commit: rG0ce58c52d50b: [Fuchsia][CMake] Add missing include path..
hctim added a subscriber: hctim.May 27 2021, 9:33 AM

Thanks for the keen eye on the Fuchsia bots, I didn't see this!

Revision Contents

PathSize
clang/
cmake/
caches/
2 lines

Diff 348146

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Lines
endforeach() endforeach()
if(FUCHSIA_SDK) if(FUCHSIA_SDK)
set(FUCHSIA_aarch64-unknown-fuchsia_NAME arm64) set(FUCHSIA_aarch64-unknown-fuchsia_NAME arm64)
set(FUCHSIA_i386-unknown-fuchsia_NAME x64) set(FUCHSIA_i386-unknown-fuchsia_NAME x64)
set(FUCHSIA_x86_64-unknown-fuchsia_NAME x64) set(FUCHSIA_x86_64-unknown-fuchsia_NAME x64)
set(FUCHSIA_riscv64-unknown-fuchsia_NAME riscv64) set(FUCHSIA_riscv64-unknown-fuchsia_NAME riscv64)
foreach(target i386-unknown-fuchsia;x86_64-unknown-fuchsia;aarch64-unknown-fuchsia;riscv64-unknown-fuchsia) foreach(target i386-unknown-fuchsia;x86_64-unknown-fuchsia;aarch64-unknown-fuchsia;riscv64-unknown-fuchsia)
set(FUCHSIA_${target}_COMPILER_FLAGS "--target=${target} -I${FUCHSIA_SDK}/pkg/fdio/include") set(FUCHSIA_${target}_COMPILER_FLAGS "--target=${target} -I${FUCHSIA_SDK}/pkg/sync/include -I${FUCHSIA_SDK}/pkg/fdio/include")
set(FUCHSIA_${target}_LINKER_FLAGS "-L${FUCHSIA_SDK}/arch/${FUCHSIA_${target}_NAME}/lib") set(FUCHSIA_${target}_LINKER_FLAGS "-L${FUCHSIA_SDK}/arch/${FUCHSIA_${target}_NAME}/lib")
set(FUCHSIA_${target}_SYSROOT "${FUCHSIA_SDK}/arch/${FUCHSIA_${target}_NAME}/sysroot") set(FUCHSIA_${target}_SYSROOT "${FUCHSIA_SDK}/arch/${FUCHSIA_${target}_NAME}/sysroot")
endforeach() endforeach()
foreach(target i386-unknown-fuchsia;x86_64-unknown-fuchsia;aarch64-unknown-fuchsia;riscv64-unknown-fuchsia) foreach(target i386-unknown-fuchsia;x86_64-unknown-fuchsia;aarch64-unknown-fuchsia;riscv64-unknown-fuchsia)
# Set the per-target builtins options. # Set the per-target builtins options.
list(APPEND BUILTIN_TARGETS "${target}") list(APPEND BUILTIN_TARGETS "${target}")
set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "") set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "")
▲ Show 20 Lines • Show All 143 Lines • Show Last 20 Lines