Page MenuHomePhabricator

gulfem (Gulfem Savrun Yeniceri)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 19 2020, 10:52 AM (5 w, 21 h)

Recent Activity

Wed, Nov 18

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Wed, Nov 18, 6:11 PM · Restricted Project, Restricted Project

Wed, Nov 11

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Wed, Nov 11, 8:29 PM · Restricted Project, Restricted Project

Tue, Nov 10

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Tue, Nov 10, 5:33 PM · Restricted Project, Restricted Project

Mon, Nov 9

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Mon, Nov 9, 6:08 PM · Restricted Project, Restricted Project

Thu, Nov 5

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Thu, Nov 5, 11:38 AM · Restricted Project, Restricted Project
gulfem updated the diff for D90275: [clang][IR] Add support for leaf attribute.

Remove direct from description and ObjCMethod for Obj functionality

Thu, Nov 5, 11:22 AM · Restricted Project, Restricted Project

Wed, Nov 4

gulfem added a comment to D90275: [clang][IR] Add support for leaf attribute.

The more I think about it, the more I think we should never create a leaf/nocallback definition. Only declarations should carry that attribute.

Leaf attribute is specifically intended for library functions and I think all the existing usage of leaf attribute is in the library function declarations.
For ex, it is only used in syscalls in Fuchsia.
Therefore, I'm not sure whether it is really necessary to ban leaf attribute in function definitions.
Even though function attributes are typically intended to be used in the function declaration, compilers do not have policy to forbid using them in the function definition.

Wed, Nov 4, 1:18 PM · Restricted Project, Restricted Project
gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Wed, Nov 4, 10:50 AM · Restricted Project, Restricted Project

Tue, Nov 3

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Tue, Nov 3, 5:26 PM · Restricted Project, Restricted Project
gulfem updated the diff for D90275: [clang][IR] Add support for leaf attribute.

Add a target into the test case

Tue, Nov 3, 5:01 PM · Restricted Project, Restricted Project
gulfem added a comment to D90275: [clang][IR] Add support for leaf attribute.

The more I think about it, the more I think we should never create a leaf/nocallback definition. Only declarations should carry that attribute.

I'm also still not convinced nocallback is a good name. @efriedma @aqjune @fhahn @reames What are your thoughts on the name. My earlier idea was inaccesiblecodeonly, as it matches the inaccisblememonly idea. I'm not married to it, nocallback is just not great IMHO as direct calls back into the caller TU are also forbidden and there is already !callback.

Tue, Nov 3, 12:20 PM · Restricted Project, Restricted Project

Mon, Nov 2

gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Mon, Nov 2, 5:28 PM · Restricted Project, Restricted Project
gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Mon, Nov 2, 1:38 PM · Restricted Project, Restricted Project
gulfem updated the diff for D90275: [clang][IR] Add support for leaf attribute.

Update the attribute documentation

Mon, Nov 2, 12:23 PM · Restricted Project, Restricted Project
gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Mon, Nov 2, 11:25 AM · Restricted Project, Restricted Project
gulfem added inline comments to D90275: [clang][IR] Add support for leaf attribute.
Mon, Nov 2, 11:11 AM · Restricted Project, Restricted Project
gulfem updated the diff for D90275: [clang][IR] Add support for leaf attribute.

Addressed the comments about the documentation

Mon, Nov 2, 11:10 AM · Restricted Project, Restricted Project

Thu, Oct 29

gulfem updated the diff for D90275: [clang][IR] Add support for leaf attribute.

Fix the typo in the test case

Thu, Oct 29, 4:52 PM · Restricted Project, Restricted Project
gulfem updated the diff for D90275: [clang][IR] Add support for leaf attribute.

Add IR and bitcode tests

Thu, Oct 29, 4:40 PM · Restricted Project, Restricted Project

Tue, Oct 27

gulfem added a comment to D90275: [clang][IR] Add support for leaf attribute.

There is an RFC going out with this prototype as reference. When there is consensus on the RFC, this will get in shape for landing with complete tests and all.

Great. I didn't find anything when I looked for leaf in my cfe-dev inbox. Could someone put a link here, maybe directly into the commit message as it will be useful even after this goes in. Thanks :)

Tue, Oct 27, 5:41 PM · Restricted Project, Restricted Project
gulfem added reviewers for D90275: [clang][IR] Add support for leaf attribute: phosek, leonardchan, haowei, mcgrathr.
Tue, Oct 27, 5:26 PM · Restricted Project, Restricted Project
gulfem requested review of D90275: [clang][IR] Add support for leaf attribute.
Tue, Oct 27, 5:21 PM · Restricted Project, Restricted Project