Page MenuHomePhabricator

gulfem (Gulfem Savrun Yeniceri)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 19 2020, 10:52 AM (89 w, 1 d)

Recent Activity

Jun 3 2022

gulfem added a reviewer for D126586: [InstrProf][WIP] Implement boolean counters in coverage: mcgrathr.
Jun 3 2022, 6:06 PM · Restricted Project, Restricted Project, Restricted Project
gulfem updated the summary of D126586: [InstrProf][WIP] Implement boolean counters in coverage.
Jun 3 2022, 6:06 PM · Restricted Project, Restricted Project, Restricted Project
gulfem updated the diff for D126586: [InstrProf][WIP] Implement boolean counters in coverage.

Describe the high-level changes to adding and subtracting counters.

Jun 3 2022, 6:05 PM · Restricted Project, Restricted Project, Restricted Project
gulfem requested review of D127040: [InstrProf][WIP] Implement boolean counters in coverage.
Jun 3 2022, 6:02 PM · Restricted Project, Restricted Project, Restricted Project

May 27 2022

gulfem added reviewers for D126586: [InstrProf][WIP] Implement boolean counters in coverage: phosek, paulkirth, abrachet.
May 27 2022, 8:26 PM · Restricted Project, Restricted Project, Restricted Project
gulfem updated the summary of D126586: [InstrProf][WIP] Implement boolean counters in coverage.
May 27 2022, 8:23 PM · Restricted Project, Restricted Project, Restricted Project
gulfem requested review of D126586: [InstrProf][WIP] Implement boolean counters in coverage.
May 27 2022, 8:22 PM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

gulfem added a comment to D124490: [InstrProf] Minimal Block Coverage.

Hi @ellis,

This is exciting for us! We are interested in using single byte booleans for source-based code coverage, and I am currently working on the implementation.
We are trying to find a good solution to the problem that you described that missing counts cannot be inferred by doing arithmetic on other block counts when we use boolean counters.
For ex, in an if statement, else part is not instrumented, and its counter is inferred by subtracting parent and then counters.
When we use the boolean values for counters, this cannot be done anymore.
Simpler approach is to instrument more basic blocks, but we are exploring approaches that add counters to minimal blocks.
One of the biggest differences of coverage and PGO is that counters are emitted by traversing AST nodes in the front-end for coverage, whereas they are emitted by traversing CFG nodes for PGO.
The algorithm that you introduced is based on CFG traversal. I'm looking at that to see whether this can be repurposed for coverage.

A few questions:

  1. You mentioned that "we found that only ~60% of basic blocks need to be instrumented". With boolean counters, do you how much that has changed?
  2. Size reduction is great! Do you have any data on the impact of block coverage on compilation time and runtime performance? For coverage, we are also aiming runtime performance with boolean counters.
  3. Did you do any verification to compare the correctness of block coverage like comparing it against block counts?

It seems like we are trying to solve similar problems in different contexts, so we would be very interested in collaboration.

I'm happy to see interest in coverage instrumentation!

  1. Let me clarify. The existing "Kirchhoff circuit law" optimization used for 64 bit counters allows us to instrument a subset of basic blocks. IIRC we need to instrument slightly more than 60% of basic blocks to do this. For the minimal block coverage algorithm I've implemented here, we also only need to instrument ~60% of basic blocks. Of course, the blocks we instrument are not the same in both algorithms, but the number of blocks is roughly the same.
  2. I haven't analyzed compilation time, but the theoretical runtime is O(|E| * |V|). For runtime performance, I also haven't measured this but my intuition is that this is very close to optimal since we are adding a single store in as few blocks as possible. In some cases there is some choice in which blocks to instrument and so we could try to make better decisions there, e.g., choose to instrument a rarely executed block rather than one in a tight loop.
  3. My colleague Julian Mestre actually proved that the algorithm produces a correct instrumentation and also that it produces a minimal instrumentation. So we cannot find a coverage that instruments fewer blocks. We are planning on publishing these results in a paper, but that might not be for some time.

That's great!

I've implemented BlockCoverageInference to assume we are instrumenting Blocks in a CFG, but there is nothing special about blocks. This algorithm will work on any directed graph with entry and exit nodes. I think we can extend this class to support a more general graph and use it for AST coverage. Let me know if you think this could work.

CoverageMappingGen.cpp adds counters while traversing AST. For ex, this is how counters are added for an if statement.
https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CoverageMappingGen.cpp#L1383
I'm currently building the prototype for using boolean counters in coverage, and I'm planning to upload a WIP review soon.
After that, we can discuss further whether BlockCoverageInference can be generalized.

May 19 2022, 6:54 PM · Restricted Project, Restricted Project, Restricted Project

May 17 2022

gulfem added a comment to D124490: [InstrProf] Minimal Block Coverage.

This is exciting for us! We are interested in using single byte booleans for source-based code coverage, and I am currently working on the implementation.
We are trying to find a good solution to the problem that you described that missing counts cannot be inferred by doing arithmetic on other block counts when we use boolean counters.
For ex, in an if statement, else part is not instrumented, and its counter is inferred by subtracting parent and then counters.
When we use the boolean values for counters, this cannot be done anymore.
Simpler approach is to instrument more basic blocks, but we are exploring approaches that add counters to minimal blocks.
One of the biggest differences of coverage and PGO is that counters are emitted by traversing AST nodes in the front-end for coverage, whereas they are emitted by traversing CFG nodes for PGO.
The algorithm that you introduced is based on CFG traversal. I'm looking at that to see whether this can be repurposed for coverage.

May 17 2022, 5:48 PM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

gulfem added a comment to D119544: Deferred Concept Instantiation Implementation.

Then pipe that to a file (note the -E I added at the end). You should get a file that looks like some slightly-wonky C++ code.

I got the following output after running it via -E.

May 2 2022, 12:54 PM · Restricted Project, Restricted Project
gulfem added a comment to D119544: Deferred Concept Instantiation Implementation.

Ah shucks... Thanks for the heads up. Is there any chance to get you to get me a pre-processed version of this failure to play with? I've not had luck compiling/running libc++ tests in the past.

May 2 2022, 12:02 PM · Restricted Project, Restricted Project
gulfem added a comment to D119544: Deferred Concept Instantiation Implementation.

We started seeing several test failures after this commit:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8815265760499763361/overview

May 2 2022, 11:06 AM · Restricted Project, Restricted Project

Apr 5 2022

gulfem added a reverting change for rGc7f91e227a79: [InstrProfiling] No runtime hook for unused funcs: rGbcf8f2188bd5: Revert "[InstrProfiling] No runtime hook for unused funcs".
Apr 5 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project
gulfem committed rGbcf8f2188bd5: Revert "[InstrProfiling] No runtime hook for unused funcs" (authored by gulfem).
Revert "[InstrProfiling] No runtime hook for unused funcs"
Apr 5 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project
gulfem added a reverting change for D122336: [InstrProfiling] No runtime hook for unused funcs: rGbcf8f2188bd5: Revert "[InstrProfiling] No runtime hook for unused funcs".
Apr 5 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2022

gulfem added a comment to D122336: [InstrProfiling] No runtime hook for unused funcs.

@davidxl,
I added comments in https://github.com/llvm/llvm-project/commit/ead8586645f54de16cfc6fa26028d818efc425f2

Mar 25 2022, 5:30 PM · Restricted Project, Restricted Project, Restricted Project
gulfem committed rGead8586645f5: [InstrProfiling] Add comments for no runtime hook (authored by gulfem).
[InstrProfiling] Add comments for no runtime hook
Mar 25 2022, 5:28 PM · Restricted Project, Restricted Project
gulfem added inline comments to D122336: [InstrProfiling] No runtime hook for unused funcs.
Mar 25 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
gulfem committed rGc7f91e227a79: [InstrProfiling] No runtime hook for unused funcs (authored by gulfem).
[InstrProfiling] No runtime hook for unused funcs
Mar 25 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project
gulfem closed D122336: [InstrProfiling] No runtime hook for unused funcs.
Mar 25 2022, 10:03 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

gulfem added a comment to D122336: [InstrProfiling] No runtime hook for unused funcs.

So long as it doesn't change behavior expected by tapi on Darwin, I think it's OK. I doubt any other platforms are similarly affected.

I don't think it should impact TAPI because it relies on needsRuntimeHookUnconditionally function, which only returns false for Fuchsia.
So, this patch only affects the behavior of pulling in profile runtime for unused functions in Fuchsia.

Mar 24 2022, 5:08 PM · Restricted Project, Restricted Project, Restricted Project
gulfem added a comment to D122336: [InstrProfiling] No runtime hook for unused funcs.

Sorry for ay delayed replies - I've switched teams at Apple and find it difficult to keep up with llvm reviews.

it's my understanding is that we might be generating coverage record for unused functions for TAPI.

Coverage function records are emitted for unused functions because the tooling needs to know which file/line ranges require a "0" execution count.

Thanks for the background @vsk. That means that we need to generate a coverage record even for unused functions.
Do you have any objection to the current solution (not pulling in profile runtime for such cases)?

Mar 24 2022, 5:00 PM · Restricted Project, Restricted Project, Restricted Project
gulfem added a reverting change for rG30cb49b44e4e: [clang][deps] NFC: De-duplicate clang-cl tests: rG6bb836af2a60: Revert "[clang][deps] NFC: De-duplicate clang-cl tests".
Mar 24 2022, 11:13 AM · Restricted Project
gulfem committed rG6bb836af2a60: Revert "[clang][deps] NFC: De-duplicate clang-cl tests" (authored by gulfem).
Revert "[clang][deps] NFC: De-duplicate clang-cl tests"
Mar 24 2022, 11:13 AM · Restricted Project
gulfem added a reverting change for D121812: [clang][deps] NFC: De-duplicate clang-cl tests: rG6bb836af2a60: Revert "[clang][deps] NFC: De-duplicate clang-cl tests".
Mar 24 2022, 11:13 AM · Restricted Project, Restricted Project
gulfem added a comment to D122336: [InstrProfiling] No runtime hook for unused funcs.

Should this be fixed in Clang (not generating coverage record)? Adding the logic here is a little confusing.

Mar 24 2022, 10:37 AM · Restricted Project, Restricted Project, Restricted Project
gulfem updated the diff for D122336: [InstrProfiling] No runtime hook for unused funcs.

Addressed phosek's comment.

Mar 24 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project
gulfem added a comment to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Sorry for the breakage and thanks for reporting this! This is a real bug uncovered by your build using /opt. I have a fix here: D122385.

Thanks for the fix. Could it be possible to land the fix asap?
If not, could you please revert this patch, and reland with the fix?

Mar 24 2022, 8:47 AM · Restricted Project, Restricted Project

Mar 23 2022

gulfem added a comment to D121812: [clang][deps] NFC: De-duplicate clang-cl tests.

Newly added tests ClangScanDeps/cl-output.c and ClangScanDeps/cl-xclang.c started failing in our Mac toolchain builds:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8818888168677577537/overview
Here's the link to the log:
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8818888168677577537/+/u/clang/test/stdout

Mar 23 2022, 3:34 PM · Restricted Project, Restricted Project
gulfem added reviewers for D122336: [InstrProfiling] No runtime hook for unused funcs: vsk, davidxl.
Mar 23 2022, 11:27 AM · Restricted Project, Restricted Project, Restricted Project
gulfem added reviewers for D122336: [InstrProfiling] No runtime hook for unused funcs: phosek, mcgrathr.
Mar 23 2022, 11:24 AM · Restricted Project, Restricted Project, Restricted Project
gulfem requested review of D122336: [InstrProfiling] No runtime hook for unused funcs.
Mar 23 2022, 11:22 AM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

gulfem added a comment to D122084: [X86] combineAddOrSubToADCOrSBB - Fold ADD/SUB + (AND(SRL(X,Y),1) -> ADC/SBB+BT(X,Y).

@gulfem The original patch that I think caused this was reverted and an updated version committed with better type legalization - please can you confirm that fixes the build issues you saw?

Mar 22 2022, 8:42 AM · Restricted Project, Restricted Project

Mar 21 2022

gulfem added a comment to D122084: [X86] combineAddOrSubToADCOrSBB - Fold ADD/SUB + (AND(SRL(X,Y),1) -> ADC/SBB+BT(X,Y).

This patch has caused a segmentation fault in our builders:
https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-linux-x64/b8819074785049801761/overview

[2784/4086] Linking CXX executable bin/clang-ast-dump
FAILED: bin/clang-ast-dump 
: && /b/s/w/ir/x/w/staging/llvm_build/./bin/clang++ --sysroot=/b/s/w/ir/x/w/cipd/linux -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -flto -ffile-prefix-map=/b/s/w/ir/x/w/staging/llvm_build/tools/clang/stage2-bins=../staging/llvm_build/tools/clang/stage2-bins -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -static-libstdc++ -stdlib=libc++ -static-libstdc++ -fuse-ld=lld -Wl,--color-diagnostics -flto    -Wl,--lto-O0 -Wl,--gc-sections tools/clang/lib/Tooling/DumpTool/CMakeFiles/clang-ast-dump.dir/ASTSrcLocProcessor.cpp.o tools/clang/lib/Tooling/DumpTool/CMakeFiles/clang-ast-dump.dir/ClangSrcLocDump.cpp.o -o bin/clang-ast-dump  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMOption.a  lib/libLLVMFrontendOpenMP.a  lib/libLLVMSupport.a  -lpthread  lib/libclangAST.a  lib/libclangASTMatchers.a  lib/libclangBasic.a  lib/libclangDriver.a  lib/libclangFrontend.a  lib/libclangSerialization.a  lib/libclangToolingCore.a  lib/libclangDriver.a  lib/libLLVMWindowsDriver.a  lib/libLLVMOption.a  lib/libclangParse.a  lib/libclangSema.a  lib/libclangEdit.a  lib/libclangAnalysis.a  lib/libclangASTMatchers.a  lib/libclangAST.a  lib/libLLVMFrontendOpenMP.a  lib/libLLVMScalarOpts.a  lib/libLLVMAggressiveInstCombine.a  lib/libLLVMInstCombine.a  lib/libLLVMTransformUtils.a  lib/libLLVMAnalysis.a  lib/libLLVMProfileData.a  lib/libLLVMSymbolize.a  lib/libLLVMDebugInfoPDB.a  lib/libLLVMDebugInfoMSF.a  lib/libLLVMDebugInfoDWARF.a  lib/libtf_xla_runtime.a  lib/Analysis/InlinerSizeModel.o  lib/libLLVMObject.a  lib/libLLVMMCParser.a  lib/libLLVMMC.a  lib/libLLVMDebugInfoCodeView.a  lib/libLLVMTextAPI.a  lib/libLLVMBitReader.a  lib/libLLVMCore.a  lib/libLLVMBinaryFormat.a  lib/libLLVMRemarks.a  lib/libLLVMBitstreamReader.a  lib/libclangRewrite.a  lib/libclangLex.a  lib/libclangBasic.a  lib/libLLVMSupport.a  -lrt  -ldl  -lpthread  -lm  /b/s/w/ir/x/w/staging/zlib_install/lib/libz.a  lib/libLLVMDemangle.a && :
clang++: error: unable to execute command: Segmentation fault
Mar 21 2022, 8:41 PM · Restricted Project, Restricted Project

Feb 18 2022

gulfem committed rG4961bb477d05: [gwp_asan] Add missing <algorithm> include (authored by gulfem).
[gwp_asan] Add missing <algorithm> include
Feb 18 2022, 5:15 PM
gulfem committed rG3d728ef0ba28: [scudo] Add missing <algorithm> include (authored by gulfem).
[scudo] Add missing <algorithm> include
Feb 18 2022, 5:15 PM
gulfem closed D120172: [gwp_asan] Add missing <algorithm> include.
Feb 18 2022, 5:15 PM · Restricted Project
gulfem closed D120171: [scudo] Add missing <algorithm> include.
Feb 18 2022, 5:15 PM · Restricted Project
gulfem added reviewers for D120172: [gwp_asan] Add missing <algorithm> include: phosek, mcgrathr.
Feb 18 2022, 5:07 PM · Restricted Project
gulfem requested review of D120172: [gwp_asan] Add missing <algorithm> include.
Feb 18 2022, 5:06 PM · Restricted Project
gulfem added reviewers for D120171: [scudo] Add missing <algorithm> include: cryptoad, phosek.
Feb 18 2022, 5:03 PM · Restricted Project
gulfem requested review of D120171: [scudo] Add missing <algorithm> include.
Feb 18 2022, 5:01 PM · Restricted Project

Feb 15 2022

gulfem added a comment to D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header..

Sorry for the noise, and this was an issue caused from our side.
We fixed the issue, and it should be ok to reland this patch.

Feb 15 2022, 5:12 PM · Restricted Project, Restricted Project
gulfem added a comment to D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header..

We started seeing the following issue before this patch got reverted in https://llvm.googlesource.com/llvm-project/+/987c7f407d1414a023f03eb788bb97667b479f27.

[48618/254381] CC efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o
FAILED: efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o
../../../recipe_cleanup/clangc7enxobn/bin/clang -MD -MF efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o.d -o efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o -D_LIBCPP_DISABLE_VISIBILITY_ANNOTAT...
In file included from ../../src/firmware/gigaboot/src/avb.c:17:
In file included from ../../src/firmware/gigaboot/src/utf_conversion.h:6:
../../zircon/system/public/zircon/types.h:554:9: error: unknown type name 'atomic_int'
typedef atomic_int zx_futex_t;
        ^
1 error generated.
Feb 15 2022, 10:57 AM · Restricted Project, Restricted Project

Feb 14 2022

gulfem added a comment to D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands.

The following two tests started failing in our bots:

Clang :: Driver/darwin-ld-platform-version-target-version.c
Clang :: Driver/darwin-zippered-target-version.c

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8822219707275734081/overview

Feb 14 2022, 4:03 PM · Restricted Project

Jan 13 2022

gulfem added a comment to rG07ddfa95e3b5: GlobalISel: Add G_ASSERT_ALIGN hint instruction.

We started seeing a failure in Fuchsia toolchain bots building on mac.

FAILED: libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o 
/opt/s/w/ir/x/w/staging/llvm_install/bin/clang++ --target=arm64-apple-darwin --sysroot=/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -DNDEBUG -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilibcxx/include/c++build -I/opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color --target=arm64-apple-darwin --sysroot=/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -isysroot /opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk --target=arm64-apple-darwin --sysroot=/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -DLIBCXX_BUILDING_LIBCXXABI -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -I/opt/s/w/ir/x/w/staging/runtimes_build/include/c++/v1 -std=c++20 -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o -c /opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src/locale.cpp
Assertion failed: (RB && "Expected source register to have a register bank?"), function assignInstr, file llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp, line 637.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.	Program arguments: /opt/s/w/ir/x/w/staging/llvm_install/bin/clang++ --target=arm64-apple-darwin --sysroot=/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -DNDEBUG -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilibcxx/include/c++build -I/opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color --target=arm64-apple-darwin --sysroot=/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -isysroot /opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk --target=arm64-apple-darwin --sysroot=/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -DLIBCXX_BUILDING_LIBCXXABI -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -I/opt/s/w/ir/x/w/staging/runtimes_build/include/c++/v1 -std=c++20 -MD -MT libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o -MF libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o.d -o libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.o -c /opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src/locale.cpp
1.	<eof> parser at end of file
2.	Code generation
3.	Running pass 'Function Pass Manager' on module '/opt/s/w/ir/x/w/llvm-llvm-project/libcxx/src/locale.cpp'.
4.	Running pass 'RegBankSelect' on function '@_ZThn16_NKSt3__215time_get_bynameIcNS_19istreambuf_iteratorIcNS_11char_traitsIcEEEEE3__cEv'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  clang++                  0x000000010325dcbb llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 43
1  clang++                  0x000000010325cb08 llvm::sys::RunSignalHandlers() + 248
2  clang++                  0x000000010325d120 llvm::sys::CleanupOnSignal(unsigned long) + 208
3  clang++                  0x000000010319afca (anonymous namespace)::CrashRecoveryContextImpl::HandleCrash(int, unsigned long) + 106
4  clang++                  0x000000010319b18e CrashRecoverySignalHandler(int) + 110
5  libsystem_platform.dylib 0x00007fff203edd7d _sigtramp + 29
6  libsystem_platform.dylib 000000000000000000 _sigtramp + 18446603339975172768
7  libsystem_c.dylib        0x00007fff202fd406 abort + 125
8  libsystem_c.dylib        0x00007fff202fc7d8 err + 0
9  clang++                  0x0000000104039d2f llvm::RegBankSelect::assignInstr(llvm::MachineInstr&) + 1311
10 clang++                  0x000000010403a00c llvm::RegBankSelect::runOnMachineFunction(llvm::MachineFunction&) + 684
11 clang++                  0x00000001025458ce llvm::MachineFunctionPass::runOnFunction(llvm::Function&) + 366
12 clang++                  0x000000010296fc97 llvm::FPPassManager::runOnFunction(llvm::Function&) + 919
13 clang++                  0x0000000102978251 llvm::FPPassManager::runOnModule(llvm::Module&) + 65
14 clang++                  0x0000000102970388 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1288
15 clang++                  0x0000000103595802 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, std::__2::unique_ptr<llvm::raw_pwrite_stream, std::__2::default_delete<llvm::raw_pwrite_stream> >) + 4146
16 clang++                  0x000000010390d0be clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) + 1774
17 clang++                  0x0000000104b86c84 clang::ParseAST(clang::Sema&, bool, bool) + 564
18 clang++                  0x0000000103cdebb3 clang::FrontendAction::Execute() + 99
19 clang++                  0x0000000103c4c68f clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) + 831
20 clang++                  0x0000000103d68479 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) + 697
21 clang++                  0x000000010180f3cf cc1_main(llvm::ArrayRef<char const*>, char const*, void*) + 1487
22 clang++                  0x000000010180cffe ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) + 286
23 clang++                  0x0000000103a7fff7 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef> >, std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> >*, bool*) const::$_1>(long) + 23
24 clang++                  0x000000010319aedc llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) + 236
25 clang++                  0x0000000103a7fbf8 clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef> >, std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> >*, bool*) const + 296
26 clang++                  0x0000000103a49fb6 clang::driver::Compilation::ExecuteCommand(clang::driver::Command const&, clang::driver::Command const*&) const + 726
27 clang++                  0x0000000103a4a3ed clang::driver::Compilation::ExecuteJobs(clang::driver::JobList const&, llvm::SmallVectorImpl<std::__2::pair<int, clang::driver::Command const*> >&) const + 125
28 clang++                  0x0000000103a63a9c clang::driver::Driver::ExecuteCompilation(clang::driver::Compilation&, llvm::SmallVectorImpl<std::__2::pair<int, clang::driver::Command const*> >&) + 396
29 clang++                  0x000000010180c608 main + 10728
30 libdyld.dylib            0x00007fff203c3f3d start + 1
31 libdyld.dylib            0x0000000000000043 start + 18446603339975344391
clang-14: error: clang frontend command failed with exit code 134 (use -v to see invocation)
Fuchsia clang version 14.0.0 (https://llvm.googlesource.com/a/llvm-project 1e36bd8516f23e2eaf9c3c6c2005a8cf66070896)
Target: arm64-apple-darwin
Thread model: posix
InstalledDir: /opt/s/w/ir/x/w/staging/llvm_install/bin
clang-14: note: diagnostic msg: 
********************

https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8825196557921787265/+/u/runtimes/build/stdout
I think it might be related to this patch. Do you have any ideas?

Jan 13 2022, 10:51 AM

Jan 12 2022

gulfem added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Thank you @var-const, fe958b140ab37acf316f5b98318e75ba2119d5a2 fixed the issue that we were seeing in the Fuchsia toolchain bots.
I think you can also revert 9e634b35ff51d0eb2b38013111491e88bdbae388 as there is no need for that.

Jan 12 2022, 9:24 AM · Restricted Project

Jan 11 2022

gulfem added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Would you mind reverting it unless the issue can be fixed quickly?

Jan 11 2022, 2:30 PM · Restricted Project
gulfem added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

This patch seems to break the Fuchsia builds.

Failed Tests (1):
  libc++ :: std/algorithms/algorithms.results/in_out_result.pass.cpp

https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8825352420796900577/+/u/clang/test/stdout

Jan 11 2022, 10:37 AM · Restricted Project

Dec 27 2021

gulfem committed rGf261e258ecc0: [profile] Fix writing binary id into profiles (authored by gulfem).
[profile] Fix writing binary id into profiles
Dec 27 2021, 11:42 AM
gulfem closed D115830: [profile] Fix writing binary id into profiles.
Dec 27 2021, 11:42 AM · Restricted Project

Dec 15 2021

gulfem added a comment to D102039: [profile] Add binary id into profiles.

I uploaded https://reviews.llvm.org/D115830 to fix the issue.

Dec 15 2021, 3:58 PM · Restricted Project, Restricted Project
gulfem added reviewers for D115830: [profile] Fix writing binary id into profiles: mcgrathr, phosek.
Dec 15 2021, 2:13 PM · Restricted Project
gulfem updated the summary of D115830: [profile] Fix writing binary id into profiles.
Dec 15 2021, 2:10 PM · Restricted Project
gulfem updated the summary of D115830: [profile] Fix writing binary id into profiles.
Dec 15 2021, 2:08 PM · Restricted Project
gulfem requested review of D115830: [profile] Fix writing binary id into profiles.
Dec 15 2021, 2:07 PM · Restricted Project
gulfem added a comment to D102039: [profile] Add binary id into profiles.

@vitalybuka, it looks like we can have have multiple note segments in the program header, and each note segment can contain multiple notes.
Thank you @mcgrathr for pointing that out.
I think your case is like that, and I'll push a fix for that.

Dec 15 2021, 10:58 AM · Restricted Project, Restricted Project
gulfem added inline comments to D102039: [profile] Add binary id into profiles.
Dec 15 2021, 10:31 AM · Restricted Project, Restricted Project

Dec 11 2021

gulfem committed rGe5a8af7a90c6: [Passes] Fix relative lookup table converter pass (authored by gulfem).
[Passes] Fix relative lookup table converter pass
Dec 11 2021, 8:40 PM
gulfem closed D115571: [Passes] Fix relative lookup table converter pass.
Dec 11 2021, 8:40 PM · Restricted Project

Dec 10 2021

gulfem added reviewers for D115571: [Passes] Fix relative lookup table converter pass: phosek, jrtc27, leonardchan.
Dec 10 2021, 7:41 PM · Restricted Project
gulfem added inline comments to D94355: [Passes] Add relative lookup table converter pass.
Dec 10 2021, 7:39 PM · Restricted Project, Restricted Project
gulfem requested review of D115571: [Passes] Fix relative lookup table converter pass.
Dec 10 2021, 7:35 PM · Restricted Project

Dec 8 2021

gulfem added a comment to D102039: [profile] Add binary id into profiles.

Yes, looks like both LLVM servers are down https://lab.llvm.org/
FYI The special about that staging bot is that it is Ubuntu with recent
glibc 2.34. Our primary bot runs exactly the same build on Debian with
glibc 2.28 and the test passes there. It can be glibc or other dependencies.

Dec 8 2021, 10:07 AM · Restricted Project, Restricted Project

Dec 3 2021

gulfem added inline comments to D102039: [profile] Add binary id into profiles.
Dec 3 2021, 6:15 PM · Restricted Project, Restricted Project

Nov 9 2021

gulfem added a comment to D108942: [compiler-rt] Add more diagnostic to InstrProfError.

I missed the latest patchset. I have a few more comments, feel free to address those in follow up changes.

@phosek, I also addressed your comments in:
https://github.com/llvm/llvm-project/commit/126e7611c70ca41782aa851c2bec132607eb8127

Nov 9 2021, 1:14 PM · Restricted Project
gulfem added a comment to D108942: [compiler-rt] Add more diagnostic to InstrProfError.

@gulfem This is failing on some buildbots: https://lab.llvm.org/buildbot/#/builders/109/builds/25948 please can you take a look?

The test seems to require zlib which means either that dependency needs to be removed, or a "REQUIRES: zlib" needs to be added.

Nov 9 2021, 1:13 PM · Restricted Project
gulfem committed rG126e7611c70c: [compiler-rt] Fix diagnostic in InstrProfError (authored by gulfem).
[compiler-rt] Fix diagnostic in InstrProfError
Nov 9 2021, 12:31 PM
gulfem committed rGee88b8d63e47: [compiler-rt] Add more diagnostic to InstrProfError (authored by gulfem).
[compiler-rt] Add more diagnostic to InstrProfError
Nov 9 2021, 10:08 AM
gulfem closed D108942: [compiler-rt] Add more diagnostic to InstrProfError.
Nov 9 2021, 10:08 AM · Restricted Project
gulfem added a comment to D108942: [compiler-rt] Add more diagnostic to InstrProfError.

I find it cleaner just to expand known malformed errors into its own error category. WIth that the change can also be minimized.

Nov 9 2021, 8:57 AM · Restricted Project
gulfem updated the diff for D108942: [compiler-rt] Add more diagnostic to InstrProfError.

Addressed reviwer comments

Nov 9 2021, 8:49 AM · Restricted Project

Oct 26 2021

gulfem added a comment to D112082: [libunwind] Use the from-scratch testing configuration by default.

Hi @ldionne,
I had a bad internet connection yesterday, and I just found a chance to respond to you today.
With your reland, Fuchsia builders seems fine.

Oct 26 2021, 8:52 AM · Restricted Project, Restricted Project
gulfem added a comment to D108942: [compiler-rt] Add more diagnostic to InstrProfError.

@davidxl and @phosek did you have a chance to look at the latest revision?

Oct 26 2021, 8:34 AM · Restricted Project

Oct 20 2021

gulfem added a comment to D112082: [libunwind] Use the from-scratch testing configuration by default.

Thanks for the revert @ldionne

Oct 20 2021, 3:06 PM · Restricted Project, Restricted Project

Oct 12 2021

gulfem committed rG9a70eb918e2a: [profile] Remove emitting symbolizer markup (authored by gulfem).
[profile] Remove emitting symbolizer markup
Oct 12 2021, 6:43 PM
gulfem closed D111674: [profile] Remove emitting symbolizer markup.
Oct 12 2021, 6:43 PM · Restricted Project
gulfem added a reviewer for D111674: [profile] Remove emitting symbolizer markup: phosek.
Oct 12 2021, 1:20 PM · Restricted Project
gulfem requested review of D111674: [profile] Remove emitting symbolizer markup.
Oct 12 2021, 1:19 PM · Restricted Project

Oct 8 2021

gulfem updated the diff for D108942: [compiler-rt] Add more diagnostic to InstrProfError.
  1. Addressed Petr's comments
  2. Add two malformed profile tests
  3. Change error messages in existing malformed profile tests
Oct 8 2021, 4:13 PM · Restricted Project

Sep 24 2021

gulfem added a comment to rGe470f9268a44: [Polly] Implement user-directed loop distribution/fission..

If you click on the arrow on the lefthand side below the test failure (`..ManualOptimization/distribute_illegal_pragmaloc.ll), you can see the output.
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8835240512651522065/overview

Sep 24 2021, 10:30 AM
gulfem added a comment to rGe470f9268a44: [Polly] Implement user-directed loop distribution/fission..

After you relanded this patch, we still see a test failure in Fuchsia.
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8835240512651522065/overview
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8835240512651522065/+/u/clang/test/stdout

Failed Tests (1):
  Polly :: ScheduleOptimizer/ManualOptimization/distribute_illegal_pragmaloc.ll
Sep 24 2021, 9:35 AM

Sep 23 2021

gulfem added a comment to rG52c30adc7dfe: [Polly] Implement user-directed loop distribution/fission..

ScheduleOptimizer/ManualOptimization/distribute_illegal_pragmaloc.ll test seems to break our Fuchsia builds.
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8835281291365444849/+/u/clang/test/stdout

Sep 23 2021, 2:37 PM

Sep 22 2021

gulfem added a comment to D110188: [compiler-rt][profile] Add padding after binary IDs.

Thanks for the fix @leonardchan
Other type of paddings are added in:
https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/profile/InstrProfilingBuffer.c#L86

Sep 22 2021, 7:03 PM · Restricted Project, Restricted Project

Sep 21 2021

gulfem added a comment to D103938: Diagnose -Wunused-value based on CFG reachability.

We also started seeing similar libc++ test failures in our Fuchsia builds:
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8835548361443044001/+/u/clang/test/stdout

Failed Tests (89):
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/assign.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/copy.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/ctor_result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/ctor_sseq.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/default.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/discard.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/io.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/seed_result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/seed_sseq.pass.cpp
  libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/values.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.bin/eval_param.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.pconst/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.pconst/eval_param.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.samp/rand.dist.samp.plinear/eval_param.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.real/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.lcong/assign.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.lcong/copy.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.lcong/ctor_result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.lcong/result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.lcong/values.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/assign.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/copy.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/ctor_result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/ctor_sseq.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/default.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/discard.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/eval.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/io.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/seed_result_type.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/seed_sseq.pass.cpp
  libc++ :: std/numerics/rand/rand.eng/rand.eng.mers/values.pass.cpp
  libc++ :: std/numerics/rand/rand.predef/mt19937_64.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.cons/char_ptr_ctor.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.cons/default.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.cons/string_ctor.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.cons/ull_ctor.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.hash/bitset.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.hash/enabled_hash.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/all.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/any.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/count.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/flip_all.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/flip_one.out_of_range.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/flip_one.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/index.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/index_const.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/left_shift.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/left_shift_eq.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/none.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/not_all.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/op_and_eq.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/op_eq_eq.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/op_or_eq.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/op_xor_eq.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/reset_all.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/reset_one.out_of_range.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/reset_one.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/right_shift.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/right_shift_eq.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/set_all.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/set_one.out_of_range.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/set_one.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/size.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/test.out_of_range.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/test.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/to_string.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.members/to_ulong.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.operators/op_and.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.operators/op_not.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.operators/op_or.pass.cpp
  libc++ :: std/utilities/template.bitset/bitset.operators/stream_in.pass.cpp
  libc++ :: std/utilities/variant/variant.hash/hash.pass.cpp
  libc++ :: std/utilities/variant/variant.relops/relops.pass.cpp
  libc++ :: std/utilities/variant/variant.relops/relops_bool_conv.fail.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.assign/move.pass.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.status/index.pass.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.status/valueless_by_exception.pass.cpp
  libc++ :: std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp
  libc++ :: std/utilities/variant/variant.visit/visit.pass.cpp
  libc++ :: std/utilities/variant/variant.visit/visit_return_type.pass.cpp
Sep 21 2021, 9:22 AM · Restricted Project, Restricted Project

Sep 7 2021

gulfem added a comment to D102531: PR45881: Properly use CXXThisOverride for templated lambda.

I'll commit this by the end of the day if @rsmith wasn't able to take a look.

Sounds good, thank you very much!

Sep 7 2021, 11:02 AM · Restricted Project
gulfem added a comment to D102531: PR45881: Properly use CXXThisOverride for templated lambda.

Any update on this review? Our builds are still broken.

Sep 7 2021, 10:44 AM · Restricted Project

Sep 3 2021

gulfem added a comment to D108696: [Coroutines] [Frontend] Lookup in std namespace first.

We started seeing the following test failures in our Fuchsia builds after this patch:

Failed Tests (10):
  libc++ :: libcxx/experimental/language.support/support.coroutines/dialect_support.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/coroutine.handle/coroutine.handle.prom/promise.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/await_result.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/expected.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/go.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp
  libc++ :: std/experimental/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp
Sep 3 2021, 10:32 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2021

gulfem updated the summary of D109122: [profile] Extend binary id profile test.
Sep 1 2021, 7:02 PM · Restricted Project
gulfem updated the summary of D109122: [profile] Extend binary id profile test.
Sep 1 2021, 7:01 PM · Restricted Project
gulfem added reviewers for D109122: [profile] Extend binary id profile test: phosek, vsk, davidxl.
Sep 1 2021, 7:01 PM · Restricted Project
gulfem requested review of D109122: [profile] Extend binary id profile test.
Sep 1 2021, 6:59 PM · Restricted Project
gulfem added a comment to D102531: PR45881: Properly use CXXThisOverride for templated lambda.

@aaron.ballman would it be possible for you to review this patch, so we can fix our broken builds?

Sep 1 2021, 10:46 AM · Restricted Project
gulfem added a comment to D102531: PR45881: Properly use CXXThisOverride for templated lambda.

We recently enabled assertions in our Fuchsia builds, and our builds started to fail:

Sep 1 2021, 10:43 AM · Restricted Project

Aug 30 2021

gulfem added reviewers for D108942: [compiler-rt] Add more diagnostic to InstrProfError: phosek, vsk, davidxl.
Aug 30 2021, 1:16 PM · Restricted Project
gulfem requested review of D108942: [compiler-rt] Add more diagnostic to InstrProfError.
Aug 30 2021, 1:14 PM · Restricted Project

Aug 16 2021

gulfem committed rG6c0e6f91d7f0: [profile] Add static keyword to binary id functions (authored by gulfem).
[profile] Add static keyword to binary id functions
Aug 16 2021, 12:37 PM
gulfem closed D108154: [profile] Add static keyword to binary id functions.
Aug 16 2021, 12:37 PM · Restricted Project
gulfem added a reviewer for D108154: [profile] Add static keyword to binary id functions: phosek.
Aug 16 2021, 12:03 PM · Restricted Project
gulfem requested review of D108154: [profile] Add static keyword to binary id functions.
Aug 16 2021, 12:02 PM · Restricted Project