This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Build scudo_standalone on Android and Fuchsia.
AcceptedPublic

Authored by hctim on May 26 2021, 1:00 PM.

Details

Summary

This should be fine now, and is necessary for D102543.

Diff Detail

Event Timeline

hctim created this revision.May 26 2021, 1:00 PM
hctim requested review of this revision.May 26 2021, 1:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 1:00 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

I think Fuchsia doesn't need COMPILER_RT_HAS_AUXV since it's only used in Linux parts.

hctim updated this revision to Diff 348103.May 26 2021, 2:53 PM

Relax AUXV requirement on Fuchsia.

cryptoad accepted this revision.May 26 2021, 2:56 PM
This revision is now accepted and ready to land.May 26 2021, 2:56 PM
This revision was automatically updated to reflect the committed changes.
hctim reopened this revision.May 26 2021, 4:57 PM
This revision is now accepted and ready to land.May 26 2021, 4:57 PM
hctim updated this revision to Diff 348129.May 26 2021, 4:58 PM

Turns out there were some other things that are necessary to turn on the bots. This patch contains some of those things:

  1. Remove -fno-emulated-tls from the scudo buildflags under Android. This can be removed because there should be no conflict with the platform TLS now that it's guarded by SCUDO_HAS_PLATFORM_TLS_SLOT.
  2. Add some function declarations in some of the tests that are part of the NDK headers, but are guarded by NDK API level declarations.

A little more patching to do to get it working here, I think lit is still trying to enumerate the unit tests by executing --gtest_list_tests on the host rather than on the device, but I'm looking into it.