Page MenuHomePhabricator

[Attributor] Fix AAExecutionDomain returning true on invalid states
ClosedPublic

Authored by jhuber6 on May 26 2021, 10:26 AM.

Details

Summary

This patch fixes a problem with the AAExecutionDomain attributor not
checking if it is in a valid state. This can cause it to incorrectly
return that a block is executed in a single threaded context after the
attributor failed for any reason.

Diff Detail

Event Timeline

jhuber6 created this revision.May 26 2021, 10:26 AM
jhuber6 requested review of this revision.May 26 2021, 10:26 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

We need a test. A callback call should do it.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 22 2021, 3:30 PM
This revision was automatically updated to reflect the committed changes.