This is an archive of the discontinued LLVM Phabricator instance.

[mlir][doc] Fix links and indentation of mlir::ModuleOp description
ClosedPublic

Authored by zero9178 on May 23 2021, 4:55 AM.

Details

Summary

All lines after the first are currently indented by one char further to the left than the first line. This leads to the first character of each sentence being cut from the resulting Markdown file after compilation. The text also contains 3 references to sections of other markdown files. One was missing the file, while the other two had outdated files, leading to 404 errors in the documentation.

Current text on https://mlir.llvm.org/docs/Dialects/Builtin/ before this patch for reference:

A module represents a top-level container operation. It contains a single graph region](#control-flow-and-ssacfg-regions) containing a single block hich can contain any operations and does not have a terminator. Operations ithin this region cannot implicitly capture values defined outside the module, .e. Modules are IsolatedFromAbove . Modules have n optional symbol name which can be used to refer o them in operations.

Diff Detail

Event Timeline

zero9178 created this revision.May 23 2021, 4:55 AM
zero9178 requested review of this revision.May 23 2021, 4:55 AM
mehdi_amini accepted this revision.May 23 2021, 10:00 AM
This revision is now accepted and ready to land.May 23 2021, 10:00 AM