This is in preparation for the -Wunused-but-set-variable warning.
Several variables I have just removed outright, including
Someone familiar with this code should probably look at these and determine whether these variables not being used could have lead to buggy behavior.
Sure, all sounds good - if you can, please reach out to the authors of any of the semantics changing changes (the ones related to the Changed values in transformations) to see if they could add missing test coverage.
Might want to CC/respond to whoever wrote this to see if someone missed test coverage for this code.
Maybe in a separate patch would be good to switch this around to:
if (!LoLoop.Preheader) return Changed; LoLoop.Start = SearchForStart(LoLoop.Preheader);
Also might be worth reaching out to authors to check that this change is intended & possibly tested.
ABISysV_ppc.cpp feels a bit like this should be used to calculate some offset, but I don't think that's for this review to figure out what is wrong there. The other LLDB changes LGTM.
Was already checked in unused and I don't see what we would need that for, LGTM.
This code was apparently rendered obsolete by 89870cebcb0c9996f49336a21e72b80511f37341 so LGTM