[LLParser] Remove outdated deplibs

[TH3CHARLie]

Summary

The comment mentions deplibs should be removed in 4.0. Removing it in this patch.

[TH3CHARLie]

fix compliation errors

[compnerd]

While I can appreciate the removal of deprecated functionality, I think that some sort of mention of this on llvm-dev at least 2 weeks prior to the removal is warranted. It impacts any downstream projects which may still be relying on a feature.

libcxxabi/test/test_demangle.pass.cpp

12418

This should not be removed, its a name undecoration test case.

[TH3CHARLie]

Hi! Thanks for reviewing this revision. It's my first attempt to refactor the lib codebase. You are right and I wasn't aware the potential impact. I'll file email to llvm-dev and see if we can proceed this refactoring two weeks later.

[MaskRay]

See D73422

[TH3CHARLie]

Revert removed test

[TH3CHARLie]

Hi @compnerd , I've posted a thread (https://lists.llvm.org/pipermail/llvm-dev/2021-May/150690.html) at llvm-dev two weeks ago and received some positive feedbacks, could you please take another look and see if we can move forward?

[TH3CHARLie]

Hi @MaskRay could you please take a look? thanks!

[TH3CHARLie]

Hi @lattner I wonder if you could review this patch given you support this on llvm-dev email list. Thanks in advance!

[compnerd]

Given the thread on the mailing list, I think that this is fine as long as there is an accompanying test to validate the bitcode deserialization continues to work. Id wait a few days more to see if @dexonsmith has an opinion.

[dexonsmith]

In D102763#2815285, @compnerd wrote:

Given the thread on the mailing list, I think that this is fine as long as there is an accompanying test to validate the bitcode deserialization continues to work. Id wait a few days more to see if @dexonsmith has an opinion.

LGTM too (sorry for any delay; on vacation).

Note two historical quirks about this "Remove in 4.0" comment, which has experienced some bitrot.

1. In the past, the community assumed that 4.0 would break compatibility with 3.x (like 3.0 did with 2.x). We since dropped that (and went from 3.9 to 4.0 without breaking compatibility), but I guess some of the boilerplate comments are still around. I think such comments in the bitcode parser were already removed since we don't anticipate breaking compatibility "ever".
2. In the past, LLVM parsed (and auto-upgraded) old textual IR. At some point we dropped that requirement. We still parse some non-canonical forms of textual IR as a convenience (mainly to avoid having to update old testcases), but we're allowed to break compatibility when it "makes sense", unrelated to specific version numbers.

[lattner]

Thanks!

[TH3CHARLie]

Thank everyone for the reviews and further clarification, I believe we reach an agreement this is ready to land. committing it now.

libcxxabi/test/test_demangle.pass.cpp

     {"_ZN4llvm8LLParser19ValidateEndOfModuleEv", "llvm::LLParser::ValidateEndOfModule()"},
     {"_ZN4llvm8LLParser31ResolveForwardRefBlockAddressesEPNS_8FunctionERSt6vectorISt4pairINS_5ValIDEPNS_11GlobalValueEESaIS8_EEPNS0_16PerFunctionStateE", "llvm::LLParser::ResolveForwardRefBlockAddresses(llvm::Function*, std::vector<std::pair<llvm::ValID, llvm::GlobalValue*>, std::allocator<std::pair<llvm::ValID, llvm::GlobalValue*> > >&, llvm::LLParser::PerFunctionState*)"},
     {"_ZN4llvm8LLParser16PerFunctionState5GetBBERKSsNS_5SMLocE", "llvm::LLParser::PerFunctionState::GetBB(std::string const&, llvm::SMLoc)"},
     {"_ZN4llvm8LLParser16PerFunctionState5GetBBEjNS_5SMLocE", "llvm::LLParser::PerFunctionState::GetBB(unsigned int, llvm::SMLoc)"},
     {"_ZN4llvm8LLParser12ParseDeclareEv", "llvm::LLParser::ParseDeclare()"},
     {"_ZN4llvm8LLParser11ParseDefineEv", "llvm::LLParser::ParseDefine()"},
     {"_ZN4llvm8LLParser14ParseModuleAsmEv", "llvm::LLParser::ParseModuleAsm()"},
     {"_ZN4llvm8LLParser21ParseTargetDefinitionEv", "llvm::LLParser::ParseTargetDefinition()"},
-    {"_ZN4llvm8LLParser12ParseDepLibsEv", "llvm::LLParser::ParseDepLibs()"},
     {"_ZN4llvm8LLParser16ParseUnnamedTypeEv", "llvm::LLParser::ParseUnnamedType()"},
     {"_ZN4llvm8LLParser14ParseNamedTypeEv", "llvm::LLParser::ParseNamedType()"},
     {"_ZN4llvm8LLParser18ParseUnnamedGlobalEv", "llvm::LLParser::ParseUnnamedGlobal()"},
     {"_ZN4llvm8LLParser16ParseNamedGlobalEv", "llvm::LLParser::ParseNamedGlobal()"},
     {"_ZN4llvm8LLParser23ParseStandaloneMetadataEv", "llvm::LLParser::ParseStandaloneMetadata()"},
     {"_ZN4llvm8LLParser18ParseNamedMetadataEv", "llvm::LLParser::ParseNamedMetadata()"},
     {"_ZN4llvm8LLParser23ParseOptionalVisibilityERj", "llvm::LLParser::ParseOptionalVisibility(unsigned int&)"},
     {"_ZN4llvm8LLParser11ParseGlobalERKSsNS_5SMLocEjbj", "llvm::LLParser::ParseGlobal(std::string const&, llvm::SMLoc, unsigned int, bool, unsigned int)"},

llvm/include/llvm/AsmParser/LLParser.h

private:
     // Top-Level Entities
     bool parseTopLevelEntities();
     bool validateEndOfModule(bool UpgradeDebugInfo);
     bool validateEndOfIndex();
     bool parseTargetDefinitions();
     bool parseTargetDefinition();
     bool parseModuleAsm();
     bool parseSourceFileName();
-    bool parseDepLibs(); // FIXME: Remove in 4.0.
     bool parseUnnamedType();
     bool parseNamedType();
     bool parseDeclare();
     bool parseDefine();
 
     bool parseGlobalType(bool &IsConstant);
     bool parseUnnamedGlobal();
     bool parseNamedGlobal();

llvm/lib/AsmParser/LLLexer.cpp

#define KEYWORD(STR)                                                           \
   KEYWORD(from);
   KEYWORD(tail);
   KEYWORD(musttail);
   KEYWORD(notail);
   KEYWORD(target);
   KEYWORD(triple);
   KEYWORD(source_filename);
   KEYWORD(unwind);
-  KEYWORD(deplibs);             // FIXME: Remove in 4.0.
   KEYWORD(datalayout);
   KEYWORD(volatile);
   KEYWORD(atomic);
   KEYWORD(unordered);
   KEYWORD(monotonic);
   KEYWORD(acquire);
   KEYWORD(release);
   KEYWORD(acq_rel);

llvm/lib/AsmParser/LLParser.cpp

while (true) {
     case lltok::kw_define:
       if (parseDefine())
         return true;
       break;
     case lltok::kw_module:
       if (parseModuleAsm())
         return true;
       break;
-    case lltok::kw_deplibs:
-      if (parseDepLibs())
-        return true;
-      break;
     case lltok::LocalVarID:
       if (parseUnnamedType())
         return true;
       break;
     case lltok::LocalVar:
       if (parseNamedType())
         return true;
       break;
bool LLParser::parseSourceFileName() {
   if (parseToken(lltok::equal, "expected '=' after source_filename") ||
       parseStringConstant(SourceFileName))
     return true;
   if (M)
     M->setSourceFileName(SourceFileName);
   return false;
 }
 
-/// toplevelentity
-///   ::= 'deplibs' '=' '[' ']'
-///   ::= 'deplibs' '=' '[' STRINGCONSTANT (',' STRINGCONSTANT)* ']'
-/// FIXME: Remove in 4.0. Currently parse, but ignore.
-bool LLParser::parseDepLibs() {
-  assert(Lex.getKind() == lltok::kw_deplibs);
-  Lex.Lex();
-  if (parseToken(lltok::equal, "expected '=' after deplibs") ||
-      parseToken(lltok::lsquare, "expected '=' after deplibs"))
-    return true;
-
-  if (EatIfPresent(lltok::rsquare))
-    return false;
-
-  do {
-    std::string Str;
-    if (parseStringConstant(Str))
-      return true;
-  } while (EatIfPresent(lltok::comma));
-
-  return parseToken(lltok::rsquare, "expected ']' at end of list");
-}
-
 /// parseUnnamedType:
 ///   ::= LocalVarID '=' 'type' type
 bool LLParser::parseUnnamedType() {
   LocTy TypeLoc = Lex.getLoc();
   unsigned TypeID = Lex.getUIntVal();
   Lex.Lex(); // eat LocalVarID;
 
   if (parseToken(lltok::equal, "expected '=' after name") ||