Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Maybe additional info about upper bound (if dst or src is local/global buffer; getDerefenceableBytes API) may be interesting too?
Is there anything you would want to share from llvm/lib/Transforms/Utils/AutoInitRemark.cpp ? You can see some examples in llvm/test/Transforms/Util/trivial-auto-var-init-call.ll.
This looks great! Adding Jessica since she reviewed the original auto-init patches too.
llvm/lib/Transforms/Utils/MemoryOpRemark.cpp | ||
---|---|---|
31 | Switch over instruction’s opcode? |
llvm/include/llvm/Transforms/Utils/MemoryOpRemark.h | ||
---|---|---|
48 | Nit: I am not sure if describe is the best fit here. I used inspect in other places which is probably even worse now that I'm looking back. Maybe something like canHandle? | |
llvm/lib/Transforms/Utils/MemoryOpRemark.cpp | ||
115 | Maybe "Inlined" is better? |
llvm/include/llvm/Transforms/Utils/MemoryOpRemark.h | ||
---|---|---|
48 | Other ideas: appliesTo, understands, accepts/accept. I don't have a strong preference. Also, s/inspect/visit/ seemed appropriate. | |
llvm/lib/Transforms/Utils/MemoryOpRemark.cpp | ||
31 | I'm not sure that would simplify this much, since CallInst/IntrinsicInst aren't leaves. |
Hi @jroelofs,
we've started getting the warnings for newly created file llvm/lib/Transforms/Utils/MemoryOpRemark.cpp on the cross toolchain builders:
c:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\transforms\utils\memoryopremark.cpp(123) : warning C4715: 'llvm::MemoryOpRemark::remarkName': not all control paths return a value c:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\transforms\utils\memoryopremark.cpp(381) : warning C4715: 'llvm::AutoInitRemark::remarkName': not all control paths return a value
one of the builds as example: https://lab.llvm.org/buildbot/#/builders/119/builds/3889
there is no return for the method's argument unknown value.
Would you take care of it?
Nit: I am not sure if describe is the best fit here. I used inspect in other places which is probably even worse now that I'm looking back. Maybe something like canHandle?