This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Refactor shouldExpandAtomicRMWInIR(). NFC.
ClosedPublic

Authored by rampitec on May 12 2021, 2:22 PM.

Details

Summary

This is logic simplification for better readability.

Diff Detail

Event Timeline

rampitec created this revision.May 12 2021, 2:22 PM
rampitec requested review of this revision.May 12 2021, 2:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2021, 2:22 PM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added inline comments.May 12 2021, 2:23 PM
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
12113

I think the previous demorganed version is easier

rampitec added inline comments.May 12 2021, 2:25 PM
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
12113

Is it? I had some troubles reading it. I do not have a strong opinion though.

rampitec updated this revision to Diff 344963.May 12 2021, 2:29 PM
rampitec marked an inline comment as done.

Reverted one line as requested by Matt.

arsenm accepted this revision.May 12 2021, 4:28 PM
This revision is now accepted and ready to land.May 12 2021, 4:28 PM
This revision was landed with ongoing or failed builds.May 12 2021, 4:39 PM
This revision was automatically updated to reflect the committed changes.