This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] migrate sparse operations into new sparse tensor dialect
ClosedPublic

Authored by aartbik on Apr 29 2021, 2:33 PM.

Details

Summary

This is the very first step toward removing the glue and clutter from linalg and
replace it with proper sparse tensor types. This revision migrates the LinalgSparseOps
into SparseTensorOps of a sparse tensor dialect. This also provides a new home for
sparse tensor related transformation.

NOTE: the actual replacement with sparse tensor types (and removal of linalg glue/clutter) will follow but I am trying to keep the amount of changes per revision manageable.

Diff Detail

Event Timeline

aartbik created this revision.Apr 29 2021, 2:33 PM
aartbik requested review of this revision.Apr 29 2021, 2:33 PM
aartbik added inline comments.
mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt
40

@rriddle you prove once again that you are a genius by spotting a missing dependency from a mile away ;-)

What changed from the previous revision? If it is only a CMake dependency feel free to skip the review and just reland with the fix (other please clarify what needs to be re-reviewed). Thanks!

What changed from the previous revision? If it is only a CMake dependency feel free to skip the review and just reland with the fix (other please clarify what needs to be re-reviewed). Thanks!

Thanks @mehdi_amini
Yes, just that one line where I praise @rriddle (he already spotted this after the revision went in, but before the breakage ;-)

This revision was not accepted when it landed; it landed in state Needs Review.Apr 29 2021, 3:52 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.