This is an archive of the discontinued LLVM Phabricator instance.

Differential D101083

[cmake] Configure policy CMP0116
ClosedPublic

Authored by kastiglione on Apr 22 2021, 10:13 AM.

Details

Reviewers
JDevlieghere
Commits
rG638d84b60b7e: [cmake] Configure policy CMP0116
Summary

Using cmake >=3.20 results in many warnings about this new policy. This change silences the warnings by explicitly declaring use of the "OLD" behavior.

This policy currently affects only one place: the tablegen() function in TableGen.cmake.

Diff Detail

Event Timeline

kastiglione created this revision.Apr 22 2021, 10:13 AM
Herald added a subscriber: mgorny. · View Herald TranscriptApr 22 2021, 10:13 AM
kastiglione requested review of this revision.Apr 22 2021, 10:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 10:13 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B100317: Diff 339700.Apr 22 2021, 12:04 PM
JDevlieghere accepted this revision.Apr 22 2021, 6:43 PM

LGTM

This revision is now accepted and ready to land.Apr 22 2021, 6:43 PM
This revision was landed with ongoing or failed builds.Apr 23 2021, 8:57 AM
Closed by commit rG638d84b60b7e: [cmake] Configure policy CMP0116 (authored by kastiglione). · Explain Why
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rG638d84b60b7e: [cmake] Configure policy CMP0116.
Kayjukh mentioned this in D99616: [CMake] Explicitly set CMP0116 policy.Jun 26 2021, 7:28 AM
kastiglione mentioned this in D112497: [lldb] Configure CMake policy CMP0116 for standalone builds.Oct 25 2021, 3:52 PM
kastiglione mentioned this in rG65dae8b2f20c: [lldb] Configure CMake policy CMP0116 for standalone builds.Oct 25 2021, 4:29 PM

Revision Contents

PathSize
llvm/
6 lines

Diff 340060

llvm/CMakeLists.txt

# See docs/CMake.html for instructions about how to build LLVM with CMake. # See docs/CMake.html for instructions about how to build LLVM with CMake.
cmake_minimum_required(VERSION 3.13.4) cmake_minimum_required(VERSION 3.13.4)
# CMP0116: Ninja generators transform `DEPFILE`s from `add_custom_command()`
# New in CMake 3.20. https://cmake.org/cmake/help/latest/policy/CMP0116.html
if(POLICY CMP0116)
cmake_policy(SET CMP0116 OLD)
endif()
set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON) set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)
if(NOT DEFINED LLVM_VERSION_MAJOR) if(NOT DEFINED LLVM_VERSION_MAJOR)
set(LLVM_VERSION_MAJOR 13) set(LLVM_VERSION_MAJOR 13)
endif() endif()
if(NOT DEFINED LLVM_VERSION_MINOR) if(NOT DEFINED LLVM_VERSION_MINOR)
set(LLVM_VERSION_MINOR 0) set(LLVM_VERSION_MINOR 0)
endif() endif()
▲ Show 20 Lines • Show All 1,122 Lines • Show Last 20 Lines