This is an archive of the discontinued LLVM Phabricator instance.

Differential D112497

[lldb] Configure CMake policy CMP0116 for standalone builds
ClosedPublic

Authored by kastiglione on Oct 25 2021, 3:52 PM.

Details

Reviewers
JDevlieghere
Commits
rG65dae8b2f20c: [lldb] Configure CMake policy CMP0116 for standalone builds
Summary

Using CMake >=3.20 results in many warnings about this new policy. This change silences the warnings by explicitly declaring use of the "OLD" behavior.

This applies D101083 to LLDBStandalone.cmake.

Diff Detail

Event Timeline

kastiglione created this revision.Oct 25 2021, 3:52 PM
Herald added a subscriber: mgorny. · View Herald TranscriptOct 25 2021, 3:52 PM
kastiglione requested review of this revision.Oct 25 2021, 3:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 3:52 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
JDevlieghere accepted this revision.Oct 25 2021, 3:52 PM

LGTM

This revision is now accepted and ready to land.Oct 25 2021, 3:52 PM
Harbormaster completed remote builds in B130572: Diff 382146.Oct 25 2021, 3:54 PM
Closed by commit rG65dae8b2f20c: [lldb] Configure CMake policy CMP0116 for standalone builds (authored by kastiglione). · Explain WhyOct 25 2021, 4:29 PM
This revision was automatically updated to reflect the committed changes.
kastiglione added a commit: rG65dae8b2f20c: [lldb] Configure CMake policy CMP0116 for standalone builds.

Revision Contents

PathSize
lldb/
cmake/
modules/
6 lines

Diff 382153

lldb/cmake/modules/LLDBStandalone.cmake

# CMP0116: Ninja generators transform `DEPFILE`s from `add_custom_command()`
# New in CMake 3.20. https://cmake.org/cmake/help/latest/policy/CMP0116.html
if(POLICY CMP0116)
cmake_policy(SET CMP0116 OLD)
endif()
option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF) option(LLVM_INSTALL_TOOLCHAIN_ONLY "Only include toolchain files in the 'install' target." OFF)
find_package(LLVM REQUIRED CONFIG HINTS ${LLVM_DIR} NO_CMAKE_FIND_ROOT_PATH) find_package(LLVM REQUIRED CONFIG HINTS ${LLVM_DIR} NO_CMAKE_FIND_ROOT_PATH)
find_package(Clang REQUIRED CONFIG HINTS ${Clang_DIR} ${LLVM_DIR}/../clang NO_CMAKE_FIND_ROOT_PATH) find_package(Clang REQUIRED CONFIG HINTS ${Clang_DIR} ${LLVM_DIR}/../clang NO_CMAKE_FIND_ROOT_PATH)
# We set LLVM_CMAKE_DIR so that GetSVN.cmake is found correctly when building SVNVersion.inc # We set LLVM_CMAKE_DIR so that GetSVN.cmake is found correctly when building SVNVersion.inc
set(LLVM_CMAKE_DIR ${LLVM_CMAKE_DIR} CACHE PATH "Path to LLVM CMake modules") set(LLVM_CMAKE_DIR ${LLVM_CMAKE_DIR} CACHE PATH "Path to LLVM CMake modules")
▲ Show 20 Lines • Show All 98 Lines • Show Last 20 Lines