Page MenuHomePhabricator

[clang-tidy] Change shebang from python to python3
AcceptedPublic

Authored by hokein on Apr 22 2021, 2:23 AM.

Details

Summary

Diff Detail

Unit TestsFailed

TimeTest
330 msx64 debian > Clang.CodeGen::builtins-ppc-quadword-noi128.c
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/13.0.0/include -nostdsysteminc -O2 -target-feature +altivec -target-feature +power8-vector -triple powerpc64le-unknown-unknown -emit-llvm /mnt/disks/ssd0/agent/llvm-project/clang/test/CodeGen/builtins-ppc-quadword-noi128.c -o - | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/clang/test/CodeGen/builtins-ppc-quadword-noi128.c -check-prefix=CHECK-LE
470 msx64 windows > Clang.CodeGen::builtins-ppc-quadword-noi128.c
Script: -- : 'RUN: at line 3'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w16c2-1\llvm-project\premerge-checks\build\lib\clang\13.0.0\include -nostdsysteminc -O2 -target-feature +altivec -target-feature +power8-vector -triple powerpc64le-unknown-unknown -emit-llvm C:\ws\w16c2-1\llvm-project\premerge-checks\clang\test\CodeGen\builtins-ppc-quadword-noi128.c -o - | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\clang\test\CodeGen\builtins-ppc-quadword-noi128.c -check-prefix=CHECK-LE

Event Timeline

hokein created this revision.Apr 22 2021, 2:23 AM
hokein requested review of this revision.Apr 22 2021, 2:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 2:23 AM
hokein edited the summary of this revision. (Show Details)Apr 22 2021, 2:36 AM
hokein added reviewers: tdl-g, aaron.ballman.
hokein edited the summary of this revision. (Show Details)
keith added a subscriber: keith.Apr 22 2021, 9:26 AM

I also have this patch https://reviews.llvm.org/D100692 which changes run-clang-tidy.py this way as well, specifically because it utilizes some python3 features in shutil.which

tdl-g accepted this revision.Apr 22 2021, 10:34 AM

I'll defer to the consensus on https://lists.llvm.org/pipermail/cfe-dev/2021-April/068047.html regarding whether or not there are gotchas for requiring python3,, but assuming tests have confirmed that each of these scripts are python3 compatible, this seems reasonable to me.

This revision is now accepted and ready to land.Apr 22 2021, 10:34 AM
keith added a comment.Fri, Jul 9, 10:15 AM

Doesn't seem like anything changed on the mailing list side, should we land this now?