- User Since
- May 7 2020, 11:04 AM (72 w, 5 d)
Aug 10 2021
Jul 7 2021
Apr 22 2021
I'll defer to the consensus on https://lists.llvm.org/pipermail/cfe-dev/2021-April/068047.html regarding whether or not there are gotchas for requiring python3,, but assuming tests have confirmed that each of these scripts are python3 compatible, this seems reasonable to me.
Jan 14 2021
Jan 12 2021
Jan 5 2021
Ah, if it's just an optimization that makes sense. I still think it's worth having a test case to confirm that one of the specially-handled cases works.
Jan 4 2021
Dec 4 2020
Looks great, just one comment.
Nov 30 2020
Nov 20 2020
Nov 18 2020
Oct 22 2020
Oct 15 2020
Just one comment about the tests.
Aug 11 2020
Jun 25 2020
Jun 23 2020
Jun 19 2020
Interesting, in all three of those cases, it's reasonable to replace the entire expression, thus eliminating the macro. None of those "tear" the macro; if we had a case like
LGTM. I found the change description confusing, since it talks about the selection() stencil but the code is all about the cat() stencil. I realize (now) that the former is deprecated in favor of the latter. But the change description is still confusing.
May 28 2020
We see this broke the build for shared-lib config http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/1879
May 26 2020
Thanks again, addressed all comments.
Fixed length of visual separator.
May 20 2020
Thanks, all, for the additional comments. I addressed them all except for the suggestion to add an options-specific test. I'm not against it, but (as I mention in the comment) I'm also unsure how to meaningfully test the include-inserting-related options.
Addressed second round of comments.
May 19 2020
Thanks, all for the comments. I believe I've addressed all comments. Note that TransformerClangTidyCheck interacts awkwardly with StoreOptions; I have a FIXME to clean that up.
Addressed review comments.
May 15 2020
Eugene, thank you for the comments, I'll address them soon. For the moment I'm trying to figure out what's up with the list.rst changes.