Page MenuHomePhabricator

tdl-g (Tom Lokovic)
User

Projects

User does not belong to any projects.

User Details

User Since
May 7 2020, 11:04 AM (72 w, 5 d)

Recent Activity

Aug 10 2021

tdl-g requested review of D107837: abseil-string-find-str-contains should not propose an edit for the three-parameter version of find()..
Aug 10 2021, 8:57 AM · Restricted Project

Jul 7 2021

tdl-g accepted D105551: [libTooling] Add support for implicit `this` to `buildAddressOf`..
Jul 7 2021, 10:24 AM · Restricted Project

Apr 22 2021

tdl-g accepted D101037: [clang-tidy] Change shebang from python to python3.

I'll defer to the consensus on https://lists.llvm.org/pipermail/cfe-dev/2021-April/068047.html regarding whether or not there are gotchas for requiring python3,, but assuming tests have confirmed that each of these scripts are python3 compatible, this seems reasonable to me.

Apr 22 2021, 10:34 AM · Restricted Project

Jan 14 2021

tdl-g accepted D93703: [libTooling] Change `addInclude` to use expansion locs..
Jan 14 2021, 6:42 AM · Restricted Project

Jan 12 2021

tdl-g accepted D94453: [clang-tidy][NFC] Add test for Transformer-based checks with diagnostics..
Jan 12 2021, 11:39 AM · Restricted Project, Restricted Project
tdl-g accepted D94453: [clang-tidy][NFC] Add test for Transformer-based checks with diagnostics..
Jan 12 2021, 8:13 AM · Restricted Project, Restricted Project

Jan 5 2021

tdl-g accepted D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s..
Jan 5 2021, 9:42 AM · Restricted Project
tdl-g added a comment to D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s..

Ah, if it's just an optimization that makes sense. I still think it's worth having a test case to confirm that one of the specially-handled cases works.

Jan 5 2021, 8:27 AM · Restricted Project

Jan 4 2021

tdl-g added inline comments to D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s..
Jan 4 2021, 6:05 AM · Restricted Project
tdl-g accepted D93695: [clang-tidy] Update uses of deprecated Transformer APIs in StringFindStrContainsCheck..
Jan 4 2021, 6:00 AM · Restricted Project

Dec 4 2020

tdl-g added inline comments to D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics..
Dec 4 2020, 12:07 PM · Restricted Project
tdl-g accepted D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics..

Looks great, just one comment.

Dec 4 2020, 11:29 AM · Restricted Project

Nov 30 2020

tdl-g accepted D92340: [libTooling][NFC] Remove deprecated Clang Transformer declarations.
Nov 30 2020, 12:05 PM · Restricted Project

Nov 20 2020

tdl-g accepted D91872: [libTooling] Update Transformer's `node` combinator to include the trailing semicolon for decls..
Nov 20 2020, 9:05 AM · Restricted Project

Nov 18 2020

tdl-g accepted D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly..
Nov 18 2020, 9:45 AM · Restricted Project

Oct 22 2020

tdl-g accepted D89961: [libTooling] Add function to Transformer to create a no-op edit..
Oct 22 2020, 2:13 PM · Restricted Project

Oct 15 2020

tdl-g accepted D89468: [libTooling] Change `after` range-selector to operate only on source ranges.
Oct 15 2020, 1:42 PM · Restricted Project
tdl-g requested changes to D89468: [libTooling] Change `after` range-selector to operate only on source ranges.

Just one comment about the tests.

Oct 15 2020, 7:49 AM · Restricted Project

Aug 11 2020

tdl-g accepted D85734: [libTooling] Move RewriteRule include edits to ASTEdit granularity..
Aug 11 2020, 8:38 AM · Restricted Project

Jun 25 2020

tdl-g accepted D82592: [libTooling] Rename overloaded `range` range selector..
Jun 25 2020, 1:05 PM · Restricted Project

Jun 23 2020

tdl-g accepted D82225: [libTooling] Delete deprecated `Stencil` combinators..
Jun 23 2020, 10:10 AM · Restricted Project

Jun 19 2020

tdl-g added a comment to D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros..

Interesting, in all three of those cases, it's reasonable to replace the entire expression, thus eliminating the macro. None of those "tear" the macro; if we had a case like

Jun 19 2020, 10:19 AM · Restricted Project
tdl-g added a comment to D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros..

LGTM. I found the change description confusing, since it talks about the selection() stencil but the code is all about the cat() stencil. I realize (now) that the former is deprecated in favor of the latter. But the change description is still confusing.

Jun 19 2020, 8:37 AM · Restricted Project
tdl-g accepted D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros..
Jun 19 2020, 8:37 AM · Restricted Project

May 28 2020

tdl-g added a comment to D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

We see this broke the build for shared-lib config http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/1879

May 28 2020, 10:28 AM · Restricted Project, Restricted Project

May 26 2020

tdl-g added a comment to D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Thanks again, addressed all comments.

May 26 2020, 8:06 AM · Restricted Project, Restricted Project
tdl-g updated the diff for D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Fixed length of visual separator.

May 26 2020, 8:06 AM · Restricted Project, Restricted Project

May 20 2020

tdl-g added a comment to D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Thanks, all, for the additional comments. I addressed them all except for the suggestion to add an options-specific test. I'm not against it, but (as I mention in the comment) I'm also unsure how to meaningfully test the include-inserting-related options.

May 20 2020, 7:34 AM · Restricted Project, Restricted Project
tdl-g updated the diff for D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Addressed second round of comments.

May 20 2020, 7:34 AM · Restricted Project, Restricted Project

May 19 2020

tdl-g added a comment to D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Thanks, all for the comments. I believe I've addressed all comments. Note that TransformerClangTidyCheck interacts awkwardly with StoreOptions; I have a FIXME to clean that up.

May 19 2020, 12:03 PM · Restricted Project, Restricted Project
tdl-g updated the diff for D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Addressed review comments.

May 19 2020, 12:02 PM · Restricted Project, Restricted Project

May 15 2020

tdl-g added a comment to D80023: [clang-tidy] Add abseil-string-find-str-contains checker..

Eugene, thank you for the comments, I'll address them soon. For the moment I'm trying to figure out what's up with the list.rst changes.

May 15 2020, 1:03 PM · Restricted Project, Restricted Project
tdl-g created D80023: [clang-tidy] Add abseil-string-find-str-contains checker..
May 15 2020, 11:24 AM · Restricted Project, Restricted Project