Page MenuHomePhabricator

[Debug-Info] [NFC] return void for some attributes adding functions
ClosedPublic

Authored by shchenz on Apr 22 2021, 12:11 AM.

Details

Summary

Make following function return void:

  • addLabel()
  • addSectionLabel
  • addSectionDelta

This aligns with other attributes adding functions.

Diff Detail

Event Timeline

shchenz created this revision.Apr 22 2021, 12:11 AM
shchenz requested review of this revision.Apr 22 2021, 12:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 12:11 AM
dblaikie accepted this revision.Apr 22 2021, 7:52 AM

Looks good, thanks!

This revision is now accepted and ready to land.Apr 22 2021, 7:52 AM
This revision was landed with ongoing or failed builds.Apr 23 2021, 1:17 AM
This revision was automatically updated to reflect the committed changes.